Paul Morelle
ece83df99a
It may happen than the routing map is cleared while rendering a qweb
view. For example, if an asset bundle is regenerated, the previous one
is unlinked, which causes a cache clearing.
Previously-generated EndPoint objects aren't found any more in the new
routing map, so `request.endpoint` cannot be used any more after a cache
clearing.
This commit adds hash and comparison magic methods on http.EndPoint so
that EndPoint objects created by a previous routing map generation can
still be used after a cache clearing.
Two tests were added: one to test the comparison and hash methods, and
the other to test them in a real-case rendering.
Commit 80a04f7ebed fixed this bug too, but introduced another issue
which caused many OPW, so it was quickly reverted by deb23450f18 along
with its performance improvement 33167b3928c. This commit replaces
80a04f7ebed with another way to fix the issue.
A third test has been added in order to avoid reintroducing this other
issue.
By the way, this commit also removes the EndPoint.arguments attribute,
as commit 17f1992698 removed all usages of this attribute in Odoo 9.0,
but left this initialization here.
OPW-2834546
OPW-2834549
OPW-2834625
X-original-commit: bdc45422f5c715782b147eecda2403386ba7eb4a
Part-of: odoo/odoo#91034
306 lines
14 KiB
Python
306 lines
14 KiB
Python
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from unittest.mock import patch
|
|
from odoo.http import root
|
|
from lxml import html
|
|
|
|
from odoo.tests import common, HttpCase, tagged
|
|
from odoo.tests.common import HOST
|
|
from odoo.tools import config, mute_logger
|
|
from odoo.addons.website.tools import MockRequest
|
|
|
|
|
|
@tagged('-at_install', 'post_install')
|
|
class TestPage(common.TransactionCase):
|
|
def setUp(self):
|
|
super(TestPage, self).setUp()
|
|
View = self.env['ir.ui.view']
|
|
Page = self.env['website.page']
|
|
Menu = self.env['website.menu']
|
|
|
|
self.base_view = View.create({
|
|
'name': 'Base',
|
|
'type': 'qweb',
|
|
'arch': '<div>content</div>',
|
|
'key': 'test.base_view',
|
|
})
|
|
|
|
self.extension_view = View.create({
|
|
'name': 'Extension',
|
|
'mode': 'extension',
|
|
'inherit_id': self.base_view.id,
|
|
'arch': '<div position="inside">, extended content</div>',
|
|
'key': 'test.extension_view',
|
|
})
|
|
|
|
self.page_1 = Page.create({
|
|
'view_id': self.base_view.id,
|
|
'url': '/page_1',
|
|
})
|
|
|
|
self.page_1_menu = Menu.create({
|
|
'name': 'Page 1 menu',
|
|
'page_id': self.page_1.id,
|
|
'website_id': 1,
|
|
})
|
|
|
|
def test_copy_page(self):
|
|
View = self.env['ir.ui.view']
|
|
Page = self.env['website.page']
|
|
Menu = self.env['website.menu']
|
|
# Specific page
|
|
self.specific_view = View.create({
|
|
'name': 'Base',
|
|
'type': 'qweb',
|
|
'arch': '<div>Specific View</div>',
|
|
'key': 'test.specific_view',
|
|
})
|
|
self.page_specific = Page.create({
|
|
'view_id': self.specific_view.id,
|
|
'url': '/page_specific',
|
|
'website_id': 1,
|
|
})
|
|
self.page_specific_menu = Menu.create({
|
|
'name': 'Page Specific menu',
|
|
'page_id': self.page_specific.id,
|
|
'website_id': 1,
|
|
})
|
|
total_pages = Page.search_count([])
|
|
total_menus = Menu.search_count([])
|
|
# Copying a specific page should create a new page with an unique URL (suffixed by -X)
|
|
Page.clone_page(self.page_specific.id, clone_menu=True)
|
|
cloned_page = Page.search([('url', '=', '/page_specific-1')])
|
|
cloned_menu = Menu.search([('url', '=', '/page_specific-1')])
|
|
self.assertEqual(len(cloned_page), 1, "A page with an URL /page_specific-1 should've been created")
|
|
self.assertEqual(Page.search_count([]), total_pages + 1, "Should have cloned the page")
|
|
# It should also copy its menu with new url/name/page_id (if the page has a menu)
|
|
self.assertEqual(len(cloned_menu), 1, "A specific page (with a menu) being cloned should have it's menu also cloned")
|
|
self.assertEqual(cloned_menu.page_id, cloned_page, "The new cloned menu and the new cloned page should be linked (m2o)")
|
|
self.assertEqual(Menu.search_count([]), total_menus + 1, "Should have cloned the page menu")
|
|
Page.clone_page(self.page_specific.id, page_name="about-us", clone_menu=True)
|
|
cloned_page_about_us = Page.search([('url', '=', '/about-us')])
|
|
cloned_menu_about_us = Menu.search([('url', '=', '/about-us')])
|
|
self.assertEqual(len(cloned_page_about_us), 1, "A page with an URL /about-us should've been created")
|
|
self.assertEqual(len(cloned_menu_about_us), 1, "A specific page (with a menu) being cloned should have it's menu also cloned")
|
|
self.assertEqual(cloned_menu_about_us.page_id, cloned_page_about_us, "The new cloned menu and the new cloned page should be linked (m2o)")
|
|
# It should also copy its menu with new url/name/page_id (if the page has a menu)
|
|
self.assertEqual(Menu.search_count([]), total_menus + 2, "Should have cloned the page menu")
|
|
|
|
total_pages = Page.search_count([])
|
|
total_menus = Menu.search_count([])
|
|
|
|
# Copying a generic page should create a specific page with same URL
|
|
Page.clone_page(self.page_1.id, clone_menu=True)
|
|
cloned_generic_page = Page.search([('url', '=', '/page_1'), ('id', '!=', self.page_1.id), ('website_id', '!=', False)])
|
|
self.assertEqual(len(cloned_generic_page), 1, "A generic page being cloned should create a specific one for the current website")
|
|
self.assertEqual(cloned_generic_page.url, self.page_1.url, "The URL of the cloned specific page should be the same as the generic page it has been cloned from")
|
|
self.assertEqual(Page.search_count([]), total_pages + 1, "Should have cloned the generic page as a specific page for this website")
|
|
self.assertEqual(Menu.search_count([]), total_menus, "It should not create a new menu as the generic page's menu belong to another website")
|
|
# Except if the URL already exists for this website (its the case now that we already cloned it once)
|
|
Page.clone_page(self.page_1.id, clone_menu=True)
|
|
cloned_generic_page_2 = Page.search([('url', '=', '/page_1-1'), ('id', '!=', self.page_1.id)])
|
|
self.assertEqual(len(cloned_generic_page_2), 1, "A generic page being cloned should create a specific page with a new URL if there is already a specific page with that URL")
|
|
|
|
def test_cow_page(self):
|
|
Menu = self.env['website.menu']
|
|
Page = self.env['website.page']
|
|
View = self.env['ir.ui.view']
|
|
|
|
# backend write, no COW
|
|
total_pages = Page.search_count([])
|
|
total_menus = Menu.search_count([])
|
|
total_views = View.search_count([])
|
|
self.page_1.write({'arch': '<div>modified base content</div>'})
|
|
self.assertEqual(total_pages, Page.search_count([]))
|
|
self.assertEqual(total_menus, Menu.search_count([]))
|
|
self.assertEqual(total_views, View.search_count([]))
|
|
|
|
# edit through frontend
|
|
self.page_1.with_context(website_id=1).write({'arch': '<div>website 1 content</div>'})
|
|
|
|
# 1. should have created website-specific copies for:
|
|
# - page
|
|
# - view x2 (base view + extension view)
|
|
# 2. should not have created menu copy as menus are not shared/COW
|
|
# 3. and shouldn't have touched original records
|
|
self.assertEqual(total_pages + 1, Page.search_count([]))
|
|
self.assertEqual(total_menus, Menu.search_count([]))
|
|
self.assertEqual(total_views + 2, View.search_count([]))
|
|
|
|
self.assertEqual(self.page_1.arch, '<div>modified base content</div>')
|
|
self.assertEqual(bool(self.page_1.website_id), False)
|
|
|
|
new_page = Page.search([('url', '=', '/page_1'), ('id', '!=', self.page_1.id)])
|
|
self.assertEqual(new_page.website_id.id, 1)
|
|
self.assertEqual(new_page.view_id.inherit_children_ids[0].website_id.id, 1)
|
|
self.assertEqual(new_page.arch, '<div>website 1 content</div>')
|
|
|
|
def test_cow_extension_view(self):
|
|
''' test cow on extension view itself (like web_editor would do in the frontend) '''
|
|
Menu = self.env['website.menu']
|
|
Page = self.env['website.page']
|
|
View = self.env['ir.ui.view']
|
|
|
|
# nothing special should happen when editing through the backend
|
|
total_pages = Page.search_count([])
|
|
total_menus = Menu.search_count([])
|
|
total_views = View.search_count([])
|
|
self.extension_view.write({'arch': '<div>modified extension content</div>'})
|
|
self.assertEqual(self.extension_view.arch, '<div>modified extension content</div>')
|
|
self.assertEqual(total_pages, Page.search_count([]))
|
|
self.assertEqual(total_menus, Menu.search_count([]))
|
|
self.assertEqual(total_views, View.search_count([]))
|
|
|
|
# When editing through the frontend a website-specific copy
|
|
# for the extension view should be created. When rendering the
|
|
# original website.page on website 1 it will look differently
|
|
# due to this new extension view.
|
|
self.extension_view.with_context(website_id=1).write({'arch': '<div>website 1 content</div>'})
|
|
self.assertEqual(total_pages, Page.search_count([]))
|
|
self.assertEqual(total_menus, Menu.search_count([]))
|
|
self.assertEqual(total_views + 1, View.search_count([]))
|
|
|
|
self.assertEqual(self.extension_view.arch, '<div>modified extension content</div>')
|
|
self.assertEqual(bool(self.page_1.website_id), False)
|
|
|
|
new_view = View.search([('name', '=', 'Extension'), ('website_id', '=', 1)])
|
|
self.assertEqual(new_view.arch, '<div>website 1 content</div>')
|
|
self.assertEqual(new_view.website_id.id, 1)
|
|
|
|
def test_cou_page_backend(self):
|
|
Page = self.env['website.page']
|
|
View = self.env['ir.ui.view']
|
|
|
|
# currently the view unlink of website.page can't handle views with inherited views
|
|
self.extension_view.unlink()
|
|
|
|
self.page_1.unlink()
|
|
self.assertEqual(Page.search_count([('url', '=', '/page_1')]), 0)
|
|
self.assertEqual(View.search_count([('name', 'in', ('Base', 'Extension'))]), 0)
|
|
|
|
def test_cou_page_frontend(self):
|
|
Page = self.env['website.page']
|
|
View = self.env['ir.ui.view']
|
|
Website = self.env['website']
|
|
|
|
website2 = self.env['website'].create({
|
|
'name': 'My Second Website',
|
|
'domain': '',
|
|
})
|
|
|
|
# currently the view unlink of website.page can't handle views with inherited views
|
|
self.extension_view.unlink()
|
|
|
|
website_id = 1
|
|
self.page_1.with_context(website_id=website_id).unlink()
|
|
|
|
self.assertEqual(bool(self.base_view.exists()), False)
|
|
self.assertEqual(bool(self.page_1.exists()), False)
|
|
# Not COU but deleting a page will delete its menu (cascade)
|
|
self.assertEqual(bool(self.page_1_menu.exists()), False)
|
|
|
|
pages = Page.search([('url', '=', '/page_1')])
|
|
self.assertEqual(len(pages), Website.search_count([]) - 1, "A specific page for every website should have been created, except for the one from where we deleted the generic one.")
|
|
self.assertTrue(website_id not in pages.mapped('website_id').ids, "The website from which we deleted the generic page should not have a specific one.")
|
|
self.assertTrue(website_id not in View.search([('name', 'in', ('Base', 'Extension'))]).mapped('website_id').ids, "Same for views")
|
|
|
|
@tagged('-at_install', 'post_install')
|
|
class WithContext(HttpCase):
|
|
def setUp(self):
|
|
super().setUp()
|
|
Page = self.env['website.page']
|
|
View = self.env['ir.ui.view']
|
|
self.base_view = View.create({
|
|
'name': 'Base',
|
|
'type': 'qweb',
|
|
'arch': '''<t name="Homepage" t-name="website.base_view">
|
|
<t t-call="website.layout">
|
|
I am a generic page
|
|
</t>
|
|
</t>''',
|
|
'key': 'test.base_view',
|
|
})
|
|
self.page = Page.create({
|
|
'view_id': self.base_view.id,
|
|
'url': '/page_1',
|
|
'is_published': True,
|
|
})
|
|
|
|
def test_unpublished_page(self):
|
|
specific_page = self.page.copy({'website_id': self.env['website'].get_current_website().id})
|
|
specific_page.write({'is_published': False, 'arch': self.page.arch.replace('I am a generic page', 'I am a specific page')})
|
|
|
|
self.authenticate(None, None)
|
|
r = self.url_open(specific_page.url)
|
|
self.assertEqual(r.status_code, 404, "Restricted users should see a 404 and not the generic one as we unpublished the specific one")
|
|
|
|
self.authenticate('admin', 'admin')
|
|
r = self.url_open(specific_page.url)
|
|
self.assertEqual(r.status_code, 200, "Admin should see the specific unpublished page")
|
|
self.assertEqual('I am a specific page' in r.text, True, "Admin should see the specific unpublished page")
|
|
|
|
def test_search(self):
|
|
dbname = common.get_db_name()
|
|
admin_uid = self.env.ref('base.user_admin').id
|
|
website = self.env['website'].get_current_website()
|
|
|
|
robot = self.xmlrpc_object.execute(
|
|
dbname, admin_uid, 'admin',
|
|
'website', 'search_pages', [website.id], 'info'
|
|
)
|
|
self.assertIn({'loc': '/website/info'}, robot)
|
|
|
|
pages = self.xmlrpc_object.execute(
|
|
dbname, admin_uid, 'admin',
|
|
'website', 'search_pages', [website.id], 'page'
|
|
)
|
|
self.assertIn(
|
|
'/page_1',
|
|
[p['loc'] for p in pages],
|
|
)
|
|
|
|
@mute_logger('odoo.http')
|
|
def test_03_error_page_debug(self):
|
|
with MockRequest(self.env, website=self.env['website'].browse(1)):
|
|
self.base_view.arch = self.base_view.arch.replace('I am a generic page', '<t t-esc="15/0"/>')
|
|
|
|
# first call, no debug, traceback should not be visible
|
|
r = self.url_open(self.page.url)
|
|
self.assertEqual(r.status_code, 500, "15/0 raise a 500 error page")
|
|
self.assertNotIn('ZeroDivisionError: division by zero', r.text, "Error should not be shown when not in debug.")
|
|
|
|
# second call, enable debug, traceback should be visible
|
|
r = self.url_open(self.page.url + '?debug=1')
|
|
self.assertEqual(r.status_code, 500, "15/0 raise a 500 error page (2)")
|
|
self.assertIn('ZeroDivisionError: division by zero', r.text, "Error should be shown in debug.")
|
|
|
|
# third call, no explicit debug but it should be enabled by
|
|
# the session, traceback should be visible
|
|
r = self.url_open(self.page.url)
|
|
self.assertEqual(r.status_code, 500, "15/0 raise a 500 error page (2)")
|
|
self.assertIn('ZeroDivisionError: division by zero', r.text, "Error should be shown in debug.")
|
|
|
|
def test_04_visitor_no_session(self):
|
|
with patch.object(root.session_store, 'save') as session_save,\
|
|
MockRequest(self.env, website=self.env['website'].browse(1)):
|
|
# no session should be saved for website visitor
|
|
self.url_open(self.page.url).raise_for_status()
|
|
session_save.assert_not_called()
|
|
|
|
def test_homepage_not_slash_url(self):
|
|
website = self.env['website'].browse([1])
|
|
# Set another page (/page_1) as homepage
|
|
website.write({
|
|
'homepage_id': self.page.id,
|
|
'domain': f"http://{HOST}:{config['http_port']}",
|
|
})
|
|
assert self.page.url != '/'
|
|
|
|
r = self.url_open('/')
|
|
r.raise_for_status()
|
|
self.assertEqual(r.status_code, 200,
|
|
"There should be no crash when a public user is accessing `/` which is rerouting to another page with a different URL.")
|
|
root_html = html.fromstring(r.content)
|
|
canonical_url = root_html.xpath('//link[@rel="canonical"]')[0].attrib['href']
|
|
self.assertEqual(canonical_url, website.domain + "/")
|