qdp-odoo
01216345e2
It was very confusing for the user to distinct account.payment and payment.transaction. From now on, the transactions are technical objects and, in the backend, we only refer to it in log messages (Front end will be adapted in the same fashion later on). They are hidden in debug mode in accounting\configuration\payments as their purpose is now purely technical/log This commit also aims to reduce the gap between the accounting app and the transactions: account.payment objects are created/validated upon completion of transaction. To ease the capture/voiding of pending transactions, the related buttons are now displayed directly on the SO/invoice instead of the transactions. Was task: https://www.odoo.com/web#id=35857&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720 Was PR #24043 [FIX] add domain based on journal to payment tokens Was opw: https://www.odoo.com/web?debug#id=1828206&view_type=form&model=project.task&menu_id=5200
200 lines
8.6 KiB
Python
200 lines
8.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
from odoo.addons.payment.models.payment_acquirer import ValidationError
|
|
from odoo.addons.payment.tests.common import PaymentAcquirerCommon
|
|
from odoo.addons.payment_paypal.controllers.main import PaypalController
|
|
from werkzeug import urls
|
|
|
|
from odoo.tools import mute_logger
|
|
from odoo.tests import tagged
|
|
|
|
from lxml import objectify
|
|
|
|
|
|
class PaypalCommon(PaymentAcquirerCommon):
|
|
|
|
def setUp(self):
|
|
super(PaypalCommon, self).setUp()
|
|
|
|
self.paypal = self.env.ref('payment.payment_acquirer_paypal')
|
|
|
|
# some CC
|
|
self.amex = (('378282246310005', '123'), ('371449635398431', '123'))
|
|
self.amex_corporate = (('378734493671000', '123'))
|
|
self.autralian_bankcard = (('5610591081018250', '123'))
|
|
self.dinersclub = (('30569309025904', '123'), ('38520000023237', '123'))
|
|
self.discover = (('6011111111111117', '123'), ('6011000990139424', '123'))
|
|
self.jcb = (('3530111333300000', '123'), ('3566002020360505', '123'))
|
|
self.mastercard = (('5555555555554444', '123'), ('5105105105105100', '123'))
|
|
self.visa = (('4111111111111111', '123'), ('4012888888881881', '123'), ('4222222222222', '123'))
|
|
self.dankord_pbs = (('76009244561', '123'), ('5019717010103742', '123'))
|
|
self.switch_polo = (('6331101999990016', '123'))
|
|
|
|
|
|
@tagged('post_install', '-at_install', 'external', '-standard')
|
|
class PaypalForm(PaypalCommon):
|
|
|
|
def test_10_paypal_form_render(self):
|
|
base_url = self.env['ir.config_parameter'].get_param('web.base.url')
|
|
# be sure not to do stupid things
|
|
self.paypal.write({'paypal_email_account': 'tde+paypal-facilitator@odoo.com', 'fees_active': False})
|
|
self.assertEqual(self.paypal.environment, 'test', 'test without test environment')
|
|
|
|
# ----------------------------------------
|
|
# Test: button direct rendering
|
|
# ----------------------------------------
|
|
|
|
# render the button
|
|
res = self.paypal.render(
|
|
'test_ref0', 0.01, self.currency_euro.id,
|
|
values=self.buyer_values)
|
|
|
|
form_values = {
|
|
'cmd': '_xclick',
|
|
'business': 'tde+paypal-facilitator@odoo.com',
|
|
'item_name': 'YourCompany: test_ref0',
|
|
'item_number': 'test_ref0',
|
|
'first_name': 'Norbert',
|
|
'last_name': 'Buyer',
|
|
'amount': '0.01',
|
|
'currency_code': 'EUR',
|
|
'address1': 'Huge Street 2/543',
|
|
'city': 'Sin City',
|
|
'zip': '1000',
|
|
'country': 'BE',
|
|
'email': 'norbert.buyer@example.com',
|
|
'return': urls.url_join(base_url, PaypalController._return_url),
|
|
'notify_url': urls.url_join(base_url, PaypalController._notify_url),
|
|
'cancel_return': urls.url_join(base_url, PaypalController._cancel_url),
|
|
}
|
|
|
|
# check form result
|
|
tree = objectify.fromstring(res)
|
|
|
|
data_set = tree.xpath("//input[@name='data_set']")
|
|
self.assertEqual(len(data_set), 1, 'paypal: Found %d "data_set" input instead of 1' % len(data_set))
|
|
self.assertEqual(data_set[0].get('data-action-url'), 'https://www.sandbox.paypal.com/cgi-bin/webscr', 'paypal: wrong form POST url')
|
|
for form_input in tree.input:
|
|
if form_input.get('name') in ['submit', 'data_set']:
|
|
continue
|
|
self.assertEqual(
|
|
form_input.get('value'),
|
|
form_values[form_input.get('name')],
|
|
'paypal: wrong value for input %s: received %s instead of %s' % (form_input.get('name'), form_input.get('value'), form_values[form_input.get('name')])
|
|
)
|
|
|
|
def test_11_paypal_form_with_fees(self):
|
|
# be sure not to do stupid things
|
|
self.assertEqual(self.paypal.environment, 'test', 'test without test environment')
|
|
|
|
# update acquirer: compute fees
|
|
self.paypal.write({
|
|
'fees_active': True,
|
|
'fees_dom_fixed': 1.0,
|
|
'fees_dom_var': 0.35,
|
|
'fees_int_fixed': 1.5,
|
|
'fees_int_var': 0.50,
|
|
})
|
|
|
|
# render the button
|
|
res = self.paypal.render(
|
|
'test_ref0', 12.50, self.currency_euro.id,
|
|
values=self.buyer_values)
|
|
|
|
# check form result
|
|
handling_found = False
|
|
tree = objectify.fromstring(res)
|
|
|
|
data_set = tree.xpath("//input[@name='data_set']")
|
|
self.assertEqual(len(data_set), 1, 'paypal: Found %d "data_set" input instead of 1' % len(data_set))
|
|
self.assertEqual(data_set[0].get('data-action-url'), 'https://www.sandbox.paypal.com/cgi-bin/webscr', 'paypal: wrong form POST url')
|
|
for form_input in tree.input:
|
|
if form_input.get('name') in ['handling']:
|
|
handling_found = True
|
|
self.assertEqual(form_input.get('value'), '1.57', 'paypal: wrong computed fees')
|
|
self.assertTrue(handling_found, 'paypal: fees_active did not add handling input in rendered form')
|
|
|
|
@mute_logger('odoo.addons.payment_paypal.models.payment', 'ValidationError')
|
|
def test_20_paypal_form_management(self):
|
|
# be sure not to do stupid things
|
|
self.assertEqual(self.paypal.environment, 'test', 'test without test environment')
|
|
|
|
# typical data posted by paypal after client has successfully paid
|
|
paypal_post_data = {
|
|
'protection_eligibility': u'Ineligible',
|
|
'last_name': u'Poilu',
|
|
'txn_id': u'08D73520KX778924N',
|
|
'receiver_email': u'dummy',
|
|
'payment_status': u'Pending',
|
|
'payment_gross': u'',
|
|
'tax': u'0.00',
|
|
'residence_country': u'FR',
|
|
'address_state': u'Alsace',
|
|
'payer_status': u'verified',
|
|
'txn_type': u'web_accept',
|
|
'address_street': u'Av. de la Pelouse, 87648672 Mayet',
|
|
'handling_amount': u'0.00',
|
|
'payment_date': u'03:21:19 Nov 18, 2013 PST',
|
|
'first_name': u'Norbert',
|
|
'item_name': u'test_ref_2',
|
|
'address_country': u'France',
|
|
'charset': u'windows-1252',
|
|
'custom': u'',
|
|
'notify_version': u'3.7',
|
|
'address_name': u'Norbert Poilu',
|
|
'pending_reason': u'multi_currency',
|
|
'item_number': u'test_ref_2',
|
|
'receiver_id': u'dummy',
|
|
'transaction_subject': u'',
|
|
'business': u'dummy',
|
|
'test_ipn': u'1',
|
|
'payer_id': u'VTDKRZQSAHYPS',
|
|
'verify_sign': u'An5ns1Kso7MWUdW4ErQKJJJ4qi4-AVoiUf-3478q3vrSmqh08IouiYpM',
|
|
'address_zip': u'75002',
|
|
'address_country_code': u'FR',
|
|
'address_city': u'Paris',
|
|
'address_status': u'unconfirmed',
|
|
'mc_currency': u'EUR',
|
|
'shipping': u'0.00',
|
|
'payer_email': u'tde+buyer@odoo.com',
|
|
'payment_type': u'instant',
|
|
'mc_gross': u'1.95',
|
|
'ipn_track_id': u'866df2ccd444b',
|
|
'quantity': u'1'
|
|
}
|
|
|
|
# should raise error about unknown tx
|
|
with self.assertRaises(ValidationError):
|
|
self.env['payment.transaction'].form_feedback(paypal_post_data, 'paypal')
|
|
|
|
# create tx
|
|
tx = self.env['payment.transaction'].create({
|
|
'amount': 1.95,
|
|
'acquirer_id': self.paypal.id,
|
|
'currency_id': self.currency_euro.id,
|
|
'reference': 'test_ref_2',
|
|
'partner_name': 'Norbert Buyer',
|
|
'partner_country_id': self.country_france.id})
|
|
|
|
# validate it
|
|
tx.form_feedback(paypal_post_data, 'paypal')
|
|
# check
|
|
self.assertEqual(tx.state, 'pending', 'paypal: wrong state after receiving a valid pending notification')
|
|
self.assertEqual(tx.state_message, 'multi_currency', 'paypal: wrong state message after receiving a valid pending notification')
|
|
self.assertEqual(tx.acquirer_reference, '08D73520KX778924N', 'paypal: wrong txn_id after receiving a valid pending notification')
|
|
self.assertFalse(tx.date, 'paypal: validation date should not be updated whenr receiving pending notification')
|
|
|
|
# update tx
|
|
tx.write({
|
|
'state': 'draft',
|
|
'acquirer_reference': False})
|
|
|
|
# update notification from paypal
|
|
paypal_post_data['payment_status'] = 'Completed'
|
|
# validate it
|
|
tx.form_feedback(paypal_post_data, 'paypal')
|
|
# check
|
|
self.assertEqual(tx.state, 'done', 'paypal: wrong state after receiving a valid pending notification')
|
|
self.assertEqual(tx.acquirer_reference, '08D73520KX778924N', 'paypal: wrong txn_id after receiving a valid pending notification')
|
|
self.assertEqual(tx.date, '2013-11-18 11:21:19', 'paypal: wrong validation date')
|