Thibault Delavallée
c6003af734
RATIONALE
Manual onchange is necessary because you spot an issue (or customer complains).
Automatic update through computed feild is only there to try to add missing
pieces of information but cannot decide which is the correct field value to keep.
SPECIFICATIONS
Keep an explicit onchange on partner_id. Rationale : if user explicitly
changes the partner in interface, he wants to update the whole customer
information. If partner_id is updated in code (e.g. updating your personal
information after registeration in website_event_sale) fields with a value
should not be reset as we do not know which one is the correct one.
How it should behave as following
* computed fields based on partner_id should only update missing
information. Indeed automated code cannot decide which information
is more accurate;
* interface should allow to update all customer related information
at once. We consider event users really want to update all fields
Tests are added to ensure behavior is not modified without notice.
LINKS
Task ID 2089156
Community PR odoo/odoo#42911
140 lines
6.5 KiB
Python
140 lines
6.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
import datetime
|
|
|
|
from dateutil.relativedelta import relativedelta
|
|
|
|
from odoo.addons.event.tests.common import TestEventCommon
|
|
from odoo.exceptions import ValidationError
|
|
from odoo.tests.common import Form
|
|
from odoo.tools import mute_logger
|
|
|
|
|
|
class TestEventUI(TestEventCommon):
|
|
|
|
def test_event_registration_partner_sync(self):
|
|
""" Ensure onchange on partner_id is kept for interface, not for computed
|
|
fields. """
|
|
registration_form = Form(self.env['event.registration'].with_context(
|
|
default_name='WrongName',
|
|
default_event_id=self.event_0.id
|
|
))
|
|
self.assertEqual(registration_form.event_id, self.event_0)
|
|
self.assertEqual(registration_form.name, 'WrongName')
|
|
self.assertFalse(registration_form.email)
|
|
self.assertFalse(registration_form.phone)
|
|
self.assertFalse(registration_form.mobile)
|
|
|
|
# trigger onchange
|
|
registration_form.partner_id = self.customer
|
|
self.assertEqual(registration_form.name, self.customer.name)
|
|
self.assertEqual(registration_form.email, self.customer.email)
|
|
self.assertEqual(registration_form.phone, self.customer.phone)
|
|
self.assertEqual(registration_form.mobile, self.customer.mobile)
|
|
|
|
# save, check record matches Form values
|
|
registration = registration_form.save()
|
|
self.assertEqual(registration.partner_id, self.customer)
|
|
self.assertEqual(registration.name, self.customer.name)
|
|
self.assertEqual(registration.email, self.customer.email)
|
|
self.assertEqual(registration.phone, self.customer.phone)
|
|
self.assertEqual(registration.mobile, self.customer.mobile)
|
|
|
|
# allow writing on some fields independently from customer config
|
|
registration.write({'phone': False, 'mobile': False})
|
|
self.assertFalse(registration.phone)
|
|
self.assertFalse(registration.mobile)
|
|
|
|
# reset partner should not reset other fields
|
|
registration.write({'partner_id': False})
|
|
self.assertEqual(registration.partner_id, self.env['res.partner'])
|
|
self.assertEqual(registration.name, self.customer.name)
|
|
self.assertEqual(registration.email, self.customer.email)
|
|
self.assertFalse(registration.phone)
|
|
self.assertFalse(registration.mobile)
|
|
|
|
# update to a new partner not through UI -> update only void feilds
|
|
customer2 = self.env['res.partner'].create({
|
|
'name': 'Constantin Customer 2',
|
|
'email': 'constantin2@test.example.com',
|
|
'country_id': self.env.ref('base.be').id,
|
|
'phone': '0456987654',
|
|
'mobile': '0456654321',
|
|
})
|
|
registration.write({'partner_id': customer2.id})
|
|
self.assertEqual(registration.partner_id, customer2)
|
|
self.assertEqual(registration.name, self.customer.name)
|
|
self.assertEqual(registration.email, self.customer.email)
|
|
self.assertEqual(registration.phone, customer2.phone)
|
|
self.assertEqual(registration.mobile, customer2.mobile)
|
|
|
|
|
|
class TestEventFlow(TestEventCommon):
|
|
|
|
@mute_logger('odoo.addons.base.models.ir_model', 'odoo.models')
|
|
def test_event_auto_confirm(self):
|
|
""" Basic event management with auto confirmation """
|
|
# EventUser creates a new event: ok
|
|
test_event = self.env['event.event'].with_user(self.user_eventmanager).create({
|
|
'name': 'TestEvent',
|
|
'auto_confirm': True,
|
|
'date_begin': datetime.datetime.now() + relativedelta(days=-1),
|
|
'date_end': datetime.datetime.now() + relativedelta(days=1),
|
|
'seats_max': 2,
|
|
'seats_availability': 'limited',
|
|
})
|
|
self.assertTrue(test_event.auto_confirm)
|
|
|
|
# EventUser create registrations for this event
|
|
test_reg1 = self.env['event.registration'].with_user(self.user_eventuser).create({
|
|
'name': 'TestReg1',
|
|
'event_id': test_event.id,
|
|
})
|
|
self.assertEqual(test_reg1.state, 'open', 'Event: auto_confirmation of registration failed')
|
|
self.assertEqual(test_event.seats_reserved, 1, 'Event: wrong number of reserved seats after confirmed registration')
|
|
test_reg2 = self.env['event.registration'].with_user(self.user_eventuser).create({
|
|
'name': 'TestReg2',
|
|
'event_id': test_event.id,
|
|
})
|
|
self.assertEqual(test_reg2.state, 'open', 'Event: auto_confirmation of registration failed')
|
|
self.assertEqual(test_event.seats_reserved, 2, 'Event: wrong number of reserved seats after confirmed registration')
|
|
|
|
# EventUser create registrations for this event: too much registrations
|
|
with self.assertRaises(ValidationError):
|
|
self.env['event.registration'].with_user(self.user_eventuser).create({
|
|
'name': 'TestReg3',
|
|
'event_id': test_event.id,
|
|
})
|
|
|
|
# EventUser validates registrations
|
|
test_reg1.action_set_done()
|
|
self.assertEqual(test_reg1.state, 'done', 'Event: wrong state of attended registration')
|
|
self.assertEqual(test_event.seats_used, 1, 'Event: incorrect number of attendees after closing registration')
|
|
test_reg2.action_set_done()
|
|
self.assertEqual(test_reg1.state, 'done', 'Event: wrong state of attended registration')
|
|
self.assertEqual(test_event.seats_used, 2, 'Event: incorrect number of attendees after closing registration')
|
|
|
|
@mute_logger('odoo.addons.base.models.ir_model', 'odoo.models')
|
|
def test_event_flow(self):
|
|
""" Advanced event flow: no auto confirmation, manage minimum / maximum
|
|
seats, ... """
|
|
# EventUser creates a new event: ok
|
|
test_event = self.env['event.event'].with_user(self.user_eventmanager).create({
|
|
'name': 'TestEvent',
|
|
'date_begin': datetime.datetime.now() + relativedelta(days=-1),
|
|
'date_end': datetime.datetime.now() + relativedelta(days=1),
|
|
'seats_availability': 'limited',
|
|
'seats_max': 10,
|
|
})
|
|
self.assertFalse(test_event.auto_confirm)
|
|
|
|
# EventUser create registrations for this event -> no auto confirmation
|
|
test_reg1 = self.env['event.registration'].with_user(self.user_eventuser).create({
|
|
'name': 'TestReg1',
|
|
'event_id': test_event.id,
|
|
})
|
|
self.assertEqual(
|
|
test_reg1.state, 'draft',
|
|
'Event: new registration should not be confirmed with auto_confirmation parameter being False')
|