Xavier Morel
9ebbfdac73
Fixes a large number of cases where strings are translated then
formatted, instead of letting `_()` do the formatting internally,
which allows it to recover from incorrect translations (missing,
broken, or extra placeholders).
Also
- removes translation markers entirely when there's nothing to
translate e.g. `_("%s - %s")` is not useful
- fixes a few messes which lead to only partial translatability
(DRY is generally a bad idea when translations are involved, even
more so when you don't make the variable part translatable)
- fixes a few nearby issues noticed at the same time
- replaces a few `"%s"` by `%r`, which should automatically quote
strings relatively appropriately
- fixes translated strings which use `\` to escape a newline (in order
to fill-paragraph): `\` escapes only the newline, if the
continuation string is indented this results in a bunch of spaces
ending in the string to translate, which is pretty garbage for the
translator, using implicit concatenation works much better
Note: some of the updates revert f-string parameters to %, because
babel (2.9) apparently has trouble with f-strings and blows up trying
to extract them.
Not in scope:
Helping translators fix translatable strings e.g. any translation
string with more than one placeholder probably should use keyword
placeholders
- Provides more context / data to the translator to make sense of the
sentence.
- Allows reordering the translated terms, which can be necessary
depending on the sentence and language.
closes odoo/odoo#139314
Related: odoo/enterprise#49311
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
31 lines
1.3 KiB
Python
31 lines
1.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import api, models, _
|
|
from odoo.exceptions import UserError
|
|
|
|
|
|
class PosInvoiceReport(models.AbstractModel):
|
|
_name = 'report.point_of_sale.report_invoice'
|
|
_description = 'Point of Sale Invoice Report'
|
|
|
|
@api.model
|
|
def _get_report_values(self, docids, data=None):
|
|
PosOrder = self.env['pos.order']
|
|
ids_to_print = []
|
|
invoiced_posorders_ids = []
|
|
selected_orders = PosOrder.browse(docids)
|
|
for order in selected_orders.filtered(lambda o: o.account_move):
|
|
ids_to_print.append(order.account_move.id)
|
|
invoiced_posorders_ids.append(order.id)
|
|
not_invoiced_orders_ids = list(set(docids) - set(invoiced_posorders_ids))
|
|
if not_invoiced_orders_ids:
|
|
not_invoiced_posorders = PosOrder.browse(not_invoiced_orders_ids)
|
|
not_invoiced_orders_names = [a.name for a in not_invoiced_posorders]
|
|
raise UserError(_('No link to an invoice for %s.', ', '.join(not_invoiced_orders_names)))
|
|
|
|
return {
|
|
'docs': self.env['account.move'].sudo().browse(ids_to_print),
|
|
'qr_code_urls': self.env['report.account.report_invoice'].sudo()._get_report_values(ids_to_print)['qr_code_urls']
|
|
}
|