Xavier Morel
9ebbfdac73
Fixes a large number of cases where strings are translated then
formatted, instead of letting `_()` do the formatting internally,
which allows it to recover from incorrect translations (missing,
broken, or extra placeholders).
Also
- removes translation markers entirely when there's nothing to
translate e.g. `_("%s - %s")` is not useful
- fixes a few messes which lead to only partial translatability
(DRY is generally a bad idea when translations are involved, even
more so when you don't make the variable part translatable)
- fixes a few nearby issues noticed at the same time
- replaces a few `"%s"` by `%r`, which should automatically quote
strings relatively appropriately
- fixes translated strings which use `\` to escape a newline (in order
to fill-paragraph): `\` escapes only the newline, if the
continuation string is indented this results in a bunch of spaces
ending in the string to translate, which is pretty garbage for the
translator, using implicit concatenation works much better
Note: some of the updates revert f-string parameters to %, because
babel (2.9) apparently has trouble with f-strings and blows up trying
to extract them.
Not in scope:
Helping translators fix translatable strings e.g. any translation
string with more than one placeholder probably should use keyword
placeholders
- Provides more context / data to the translator to make sense of the
sentence.
- Allows reordering the translated terms, which can be necessary
depending on the sentence and language.
closes odoo/odoo#139314
Related: odoo/enterprise#49311
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
34 lines
1.0 KiB
Python
34 lines
1.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
from odoo import api, models, _
|
|
from odoo.exceptions import UserError
|
|
|
|
|
|
class ResUsers(models.Model):
|
|
_inherit = 'res.users'
|
|
|
|
@api.model
|
|
def get_password_policy(self):
|
|
params = self.env['ir.config_parameter'].sudo()
|
|
return {
|
|
'minlength': int(params.get_param('auth_password_policy.minlength', default=0)),
|
|
}
|
|
|
|
def _set_password(self):
|
|
self._check_password_policy(self.mapped('password'))
|
|
|
|
super(ResUsers, self)._set_password()
|
|
|
|
def _check_password_policy(self, passwords):
|
|
failures = []
|
|
params = self.env['ir.config_parameter'].sudo()
|
|
|
|
minlength = int(params.get_param('auth_password_policy.minlength', default=0))
|
|
for password in passwords:
|
|
if not password:
|
|
continue
|
|
if len(password) < minlength:
|
|
failures.append(_("Passwords must have at least %d characters, got %d.", minlength, len(password)))
|
|
|
|
if failures:
|
|
raise UserError(u'\n\n '.join(failures))
|