Purpose ======= When trying the translate a sql_contraint message after an integrity error we use the current cursor in a 'with', just to make a SELECT query. That way, the cursor is commited at the end of the with statement, trying to commit the inconsitent state of the cursor that was the reason of the integrity error. Just close the cursor, as we only fetch translations from the database. closes odoo/odoo#36458 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
178 lines
8.1 KiB
Python
178 lines
8.1 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
from contextlib import closing
|
|
from functools import wraps
|
|
import logging
|
|
from psycopg2 import IntegrityError, OperationalError, errorcodes
|
|
import random
|
|
import threading
|
|
import time
|
|
|
|
import odoo
|
|
from odoo.exceptions import UserError, ValidationError, QWebException
|
|
from odoo.models import check_method_name
|
|
from odoo.tools.translate import translate, translate_sql_constraint
|
|
from odoo.tools.translate import _
|
|
|
|
from . import security
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
PG_CONCURRENCY_ERRORS_TO_RETRY = (errorcodes.LOCK_NOT_AVAILABLE, errorcodes.SERIALIZATION_FAILURE, errorcodes.DEADLOCK_DETECTED)
|
|
MAX_TRIES_ON_CONCURRENCY_FAILURE = 5
|
|
|
|
def dispatch(method, params):
|
|
(db, uid, passwd ) = params[0], int(params[1]), params[2]
|
|
|
|
# set uid tracker - cleaned up at the WSGI
|
|
# dispatching phase in odoo.service.wsgi_server.application
|
|
threading.current_thread().uid = uid
|
|
|
|
params = params[3:]
|
|
if method == 'obj_list':
|
|
raise NameError("obj_list has been discontinued via RPC as of 6.0, please query ir.model directly!")
|
|
if method not in ['execute', 'execute_kw']:
|
|
raise NameError("Method not available %s" % method)
|
|
security.check(db,uid,passwd)
|
|
registry = odoo.registry(db).check_signaling()
|
|
fn = globals()[method]
|
|
with registry.manage_changes():
|
|
res = fn(db, uid, *params)
|
|
return res
|
|
|
|
def check(f):
|
|
@wraps(f)
|
|
def wrapper(___dbname, *args, **kwargs):
|
|
""" Wraps around OSV functions and normalises a few exceptions
|
|
"""
|
|
dbname = ___dbname # NOTE: this forbid to use "___dbname" as arguments in http routes
|
|
|
|
def tr(src, ttype):
|
|
# We try to do the same as the _(), but without the frame
|
|
# inspection, since we aready are wrapping an osv function
|
|
# trans_obj = self.get('ir.translation') cannot work yet :(
|
|
ctx = {}
|
|
if not kwargs:
|
|
if args and isinstance(args[-1], dict):
|
|
ctx = args[-1]
|
|
elif isinstance(kwargs, dict):
|
|
if 'context' in kwargs:
|
|
ctx = kwargs['context']
|
|
elif 'kwargs' in kwargs and kwargs['kwargs'].get('context'):
|
|
# http entry points such as call_kw()
|
|
ctx = kwargs['kwargs'].get('context')
|
|
else:
|
|
try:
|
|
from odoo.http import request
|
|
ctx = request.env.context
|
|
except Exception:
|
|
pass
|
|
|
|
lang = ctx and ctx.get('lang')
|
|
if not (lang or hasattr(src, '__call__')):
|
|
return src
|
|
|
|
# We open a *new* cursor here, one reason is that failed SQL
|
|
# queries (as in IntegrityError) will invalidate the current one.
|
|
with closing(odoo.sql_db.db_connect(dbname).cursor()) as cr:
|
|
if ttype == 'sql_constraint':
|
|
res = translate_sql_constraint(cr, key=key, lang=lang)
|
|
else:
|
|
res = translate(cr, name=False, source_type=ttype,
|
|
lang=lang, source=src)
|
|
return res or src
|
|
|
|
def _(src):
|
|
return tr(src, 'code')
|
|
|
|
tries = 0
|
|
while True:
|
|
try:
|
|
if odoo.registry(dbname)._init and not odoo.tools.config['test_enable']:
|
|
raise odoo.exceptions.Warning('Currently, this database is not fully loaded and can not be used.')
|
|
return f(dbname, *args, **kwargs)
|
|
except (OperationalError, QWebException) as e:
|
|
if isinstance(e, QWebException):
|
|
cause = e.qweb.get('cause')
|
|
if isinstance(cause, OperationalError):
|
|
e = cause
|
|
else:
|
|
raise
|
|
# Automatically retry the typical transaction serialization errors
|
|
if e.pgcode not in PG_CONCURRENCY_ERRORS_TO_RETRY:
|
|
raise
|
|
if tries >= MAX_TRIES_ON_CONCURRENCY_FAILURE:
|
|
_logger.info("%s, maximum number of tries reached" % errorcodes.lookup(e.pgcode))
|
|
raise
|
|
wait_time = random.uniform(0.0, 2 ** tries)
|
|
tries += 1
|
|
_logger.info("%s, retry %d/%d in %.04f sec..." % (errorcodes.lookup(e.pgcode), tries, MAX_TRIES_ON_CONCURRENCY_FAILURE, wait_time))
|
|
time.sleep(wait_time)
|
|
except IntegrityError as inst:
|
|
registry = odoo.registry(dbname)
|
|
key = inst.diag.constraint_name
|
|
if key in registry._sql_constraints:
|
|
raise ValidationError(tr(key, 'sql_constraint') or inst.pgerror)
|
|
if inst.pgcode in (errorcodes.NOT_NULL_VIOLATION, errorcodes.FOREIGN_KEY_VIOLATION, errorcodes.RESTRICT_VIOLATION):
|
|
msg = _('The operation cannot be completed:')
|
|
_logger.debug("IntegrityError", exc_info=True)
|
|
try:
|
|
# Get corresponding model and field
|
|
model = field = None
|
|
for name, rclass in registry.items():
|
|
if inst.diag.table_name == rclass._table:
|
|
model = rclass
|
|
field = model._fields.get(inst.diag.column_name)
|
|
break
|
|
if inst.pgcode == errorcodes.NOT_NULL_VIOLATION:
|
|
# This is raised when a field is set with `required=True`. 2 cases:
|
|
# - Create/update: a mandatory field is not set.
|
|
# - Delete: another model has a not nullable using the deleted record.
|
|
msg += '\n'
|
|
msg += _(
|
|
'- Create/update: a mandatory field is not set.\n'
|
|
'- Delete: another model requires the record being deleted. If possible, archive it instead.'
|
|
)
|
|
if model:
|
|
msg += '\n\n{} {} ({}), {} {} ({})'.format(
|
|
_('Model:'), model._description, model._name,
|
|
_('Field:'), field.string if field else _('Unknown'), field.name if field else _('Unknown'),
|
|
)
|
|
elif inst.pgcode == errorcodes.FOREIGN_KEY_VIOLATION:
|
|
# This is raised when a field is set with `ondelete='restrict'`, at
|
|
# unlink only.
|
|
msg += _(' another model requires the record being deleted. If possible, archive it instead.')
|
|
constraint = inst.diag.constraint_name
|
|
if model or constraint:
|
|
msg += '\n\n{} {} ({}), {} {}'.format(
|
|
_('Model:'), model._description if model else _('Unknown'), model._name if model else _('Unknown'),
|
|
_('Constraint:'), constraint if constraint else _('Unknown'),
|
|
)
|
|
except Exception:
|
|
pass
|
|
raise ValidationError(msg)
|
|
else:
|
|
raise ValidationError(inst.args[0])
|
|
|
|
return wrapper
|
|
|
|
def execute_cr(cr, uid, obj, method, *args, **kw):
|
|
recs = odoo.api.Environment(cr, uid, {}).get(obj)
|
|
if recs is None:
|
|
raise UserError(_("Object %s doesn't exist") % obj)
|
|
return odoo.api.call_kw(recs, method, args, kw)
|
|
|
|
|
|
def execute_kw(db, uid, obj, method, args, kw=None):
|
|
return execute(db, uid, obj, method, *args, **kw or {})
|
|
|
|
@check
|
|
def execute(db, uid, obj, method, *args, **kw):
|
|
threading.currentThread().dbname = db
|
|
with odoo.registry(db).cursor() as cr:
|
|
check_method_name(method)
|
|
res = execute_cr(cr, uid, obj, method, *args, **kw)
|
|
if res is None:
|
|
_logger.info('The method %s of the object %s can not return `None` !', method, obj)
|
|
return res
|