Romain Derie
371cbe472b
Due to the end part of the regex `(?=$|/)`, it will not find and thus not unslug string if they end up with a query string or and anchor except if there is a trailing slash before. First, it's unlikely that there will be a trailing slash as it's not common and on top of that, Odoo try to enforce non trailing slash in URL. Second, it's not that hard to makes those cases work. Before this commit, the following string would "match" and be unslug: - /blog-1 - /blog-1/ - /blog-1/register - /blog-1/?qs=2 - /blog-1/#anchor But those would not: - /blog-1?qs=2 - /blog-1#anchor Part-of: odoo/odoo#107782
88 lines
2.2 KiB
Python
88 lines
2.2 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.addons.http_routing.models.ir_http import slugify, unslug
|
|
from odoo.tests.common import BaseCase
|
|
|
|
|
|
class TestUnslug(BaseCase):
|
|
|
|
def test_unslug(self):
|
|
tests = {
|
|
'': (None, None),
|
|
'foo': (None, None),
|
|
'foo-': (None, None),
|
|
'-': (None, None),
|
|
'foo-1': ('foo', 1),
|
|
'foo-bar-1': ('foo-bar', 1),
|
|
'foo--1': ('foo', -1),
|
|
'1': (None, 1),
|
|
'1-1': ('1', 1),
|
|
'--1': (None, None),
|
|
'foo---1': (None, None),
|
|
'foo1': (None, None),
|
|
# qs & anchor & trailing slash
|
|
'foo-1/': ('foo', 1),
|
|
'foo-1/?qs=1': ('foo', 1),
|
|
'foo-1/#anchor': ('foo', 1),
|
|
'foo-1?qs=1': ('foo', 1),
|
|
'foo-1#anchor': ('foo', 1),
|
|
}
|
|
|
|
for slug, expected in tests.items():
|
|
self.assertEqual(unslug(slug), expected, "%r case failed" % slug)
|
|
|
|
class TestTitleToSlug(BaseCase):
|
|
"""
|
|
Those tests should pass with or without python-slugify
|
|
See website/models/website.py slugify method
|
|
"""
|
|
|
|
def test_spaces(self):
|
|
self.assertEqual(
|
|
"spaces",
|
|
slugify(u" spaces ")
|
|
)
|
|
|
|
def test_unicode(self):
|
|
self.assertEqual(
|
|
"heterogeneite",
|
|
slugify(u"hétérogénéité")
|
|
)
|
|
|
|
def test_underscore(self):
|
|
self.assertEqual(
|
|
"one-two",
|
|
slugify(u"one_two")
|
|
)
|
|
|
|
def test_caps(self):
|
|
self.assertEqual(
|
|
"camelcase",
|
|
slugify(u"CamelCase")
|
|
)
|
|
|
|
def test_special_chars(self):
|
|
self.assertEqual(
|
|
"o-d-o-o",
|
|
slugify(u"o!#d{|\o/@~o&%^?")
|
|
)
|
|
|
|
def test_str_to_unicode(self):
|
|
self.assertEqual(
|
|
"espana",
|
|
slugify("España")
|
|
)
|
|
|
|
def test_numbers(self):
|
|
self.assertEqual(
|
|
"article-1",
|
|
slugify(u"Article 1")
|
|
)
|
|
|
|
def test_all(self):
|
|
self.assertEqual(
|
|
"do-you-know-martine-a-la-plage",
|
|
slugify(u"Do YOU know 'Martine à la plage' ?")
|
|
)
|