Xavier Morel
9ebbfdac73
Fixes a large number of cases where strings are translated then
formatted, instead of letting `_()` do the formatting internally,
which allows it to recover from incorrect translations (missing,
broken, or extra placeholders).
Also
- removes translation markers entirely when there's nothing to
translate e.g. `_("%s - %s")` is not useful
- fixes a few messes which lead to only partial translatability
(DRY is generally a bad idea when translations are involved, even
more so when you don't make the variable part translatable)
- fixes a few nearby issues noticed at the same time
- replaces a few `"%s"` by `%r`, which should automatically quote
strings relatively appropriately
- fixes translated strings which use `\` to escape a newline (in order
to fill-paragraph): `\` escapes only the newline, if the
continuation string is indented this results in a bunch of spaces
ending in the string to translate, which is pretty garbage for the
translator, using implicit concatenation works much better
Note: some of the updates revert f-string parameters to %, because
babel (2.9) apparently has trouble with f-strings and blows up trying
to extract them.
Not in scope:
Helping translators fix translatable strings e.g. any translation
string with more than one placeholder probably should use keyword
placeholders
- Provides more context / data to the translator to make sense of the
sentence.
- Allows reordering the translated terms, which can be necessary
depending on the sentence and language.
closes odoo/odoo#139314
Related: odoo/enterprise#49311
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
43 lines
1.8 KiB
Python
43 lines
1.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
import json
|
|
from odoo import _
|
|
from odoo import http
|
|
from odoo.http import request
|
|
|
|
|
|
class Twitter(http.Controller):
|
|
@http.route(['/website_twitter/reload'], type='json', auth="user", website=True)
|
|
def twitter_reload(self):
|
|
return request.website.fetch_favorite_tweets()
|
|
|
|
@http.route(['/website_twitter/get_favorites'], type='json', auth="public", website=True)
|
|
def get_tweets(self, limit=20):
|
|
key = request.website.twitter_api_key
|
|
secret = request.website.twitter_api_secret
|
|
screen_name = request.website.twitter_screen_name
|
|
debug = request.env['res.users'].has_group('website.group_website_restricted_editor')
|
|
if not key or not secret:
|
|
if debug:
|
|
return {"error": _("Please set the Twitter API Key and Secret in the Website Settings.")}
|
|
return []
|
|
if not screen_name:
|
|
if debug:
|
|
return {"error": _("Please set a Twitter screen name to load favorites from, "
|
|
"in the Website Settings (it does not have to be yours)")}
|
|
return []
|
|
TwitterTweets = request.env['website.twitter.tweet']
|
|
tweets = TwitterTweets.search(
|
|
[('website_id', '=', request.website.id),
|
|
('screen_name', '=', screen_name)],
|
|
limit=int(limit), order="tweet_id desc")
|
|
if len(tweets) < 12:
|
|
if debug:
|
|
return {"error": _("Twitter user @%(username)s has less than 12 favorite tweets. "
|
|
"Please add more or choose a different screen name.",
|
|
username=screen_name)}
|
|
else:
|
|
return []
|
|
return tweets.mapped(lambda t: json.loads(t.tweet))
|