PURPOSE Improve performances of various Odoo code bits. SPECIFICATIONS Use a read_group to compute number of checks to print, using a search_count instead of a search. LINKS Task ID-2281297 PR odoo/odoo#53053 PR odoo/enterprise#11299 X-original-commit: 7035b99b09152f224e74eed7d6b67a8ab04fdce8
138 lines
5.6 KiB
Python
138 lines
5.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
import re
|
|
from odoo import models, fields, api, _
|
|
from odoo.exceptions import ValidationError
|
|
|
|
class AccountJournal(models.Model):
|
|
_inherit = "account.journal"
|
|
|
|
check_manual_sequencing = fields.Boolean(
|
|
string='Manual Numbering',
|
|
default=False,
|
|
help="Check this option if your pre-printed checks are not numbered.",
|
|
)
|
|
check_sequence_id = fields.Many2one(
|
|
comodel_name='ir.sequence',
|
|
string='Check Sequence',
|
|
readonly=True,
|
|
copy=False,
|
|
help="Checks numbering sequence.",
|
|
)
|
|
check_next_number = fields.Char(
|
|
string='Next Check Number',
|
|
compute='_compute_check_next_number',
|
|
inverse='_inverse_check_next_number',
|
|
help="Sequence number of the next printed check.",
|
|
)
|
|
check_printing_payment_method_selected = fields.Boolean(
|
|
compute='_compute_check_printing_payment_method_selected',
|
|
help="Technical feature used to know whether check printing was enabled as payment method.",
|
|
)
|
|
|
|
@api.depends('check_manual_sequencing')
|
|
def _compute_check_next_number(self):
|
|
for journal in self:
|
|
sequence = journal.check_sequence_id
|
|
if sequence:
|
|
journal.check_next_number = sequence.get_next_char(sequence.number_next_actual)
|
|
else:
|
|
journal.check_next_number = 1
|
|
|
|
def _inverse_check_next_number(self):
|
|
for journal in self:
|
|
if journal.check_next_number and not re.match(r'^[0-9]+$', journal.check_next_number):
|
|
raise ValidationError(_('Next Check Number should only contains numbers.'))
|
|
if int(journal.check_next_number) < journal.check_sequence_id.number_next_actual:
|
|
raise ValidationError(_(
|
|
"The last check number was %s. In order to avoid a check being rejected "
|
|
"by the bank, you can only use a greater number.",
|
|
journal.check_sequence_id.number_next_actual
|
|
))
|
|
if journal.check_sequence_id:
|
|
journal.check_sequence_id.sudo().number_next_actual = int(journal.check_next_number)
|
|
journal.check_sequence_id.sudo().padding = len(journal.check_next_number)
|
|
|
|
@api.depends('type')
|
|
def _compute_outbound_payment_method_ids(self):
|
|
super()._compute_outbound_payment_method_ids()
|
|
for journal in self:
|
|
if journal.type == 'cash':
|
|
check_method = self.env.ref('account_check_printing.account_payment_method_check')
|
|
journal.outbound_payment_method_ids -= check_method
|
|
|
|
@api.depends('outbound_payment_method_ids')
|
|
def _compute_check_printing_payment_method_selected(self):
|
|
for journal in self:
|
|
journal.check_printing_payment_method_selected = any(
|
|
pm.code == 'check_printing'
|
|
for pm in journal.outbound_payment_method_ids
|
|
)
|
|
|
|
@api.model
|
|
def create(self, vals):
|
|
rec = super(AccountJournal, self).create(vals)
|
|
if not rec.check_sequence_id:
|
|
rec._create_check_sequence()
|
|
return rec
|
|
|
|
@api.returns('self', lambda value: value.id)
|
|
def copy(self, default=None):
|
|
rec = super(AccountJournal, self).copy(default)
|
|
rec._create_check_sequence()
|
|
return rec
|
|
|
|
def _create_check_sequence(self):
|
|
""" Create a check sequence for the journal """
|
|
for journal in self:
|
|
journal.check_sequence_id = self.env['ir.sequence'].sudo().create({
|
|
'name': journal.name + _(" : Check Number Sequence"),
|
|
'implementation': 'no_gap',
|
|
'padding': 5,
|
|
'number_increment': 1,
|
|
'company_id': journal.company_id.id,
|
|
})
|
|
|
|
def _default_outbound_payment_methods(self):
|
|
methods = super(AccountJournal, self)._default_outbound_payment_methods()
|
|
return methods + self.env.ref('account_check_printing.account_payment_method_check')
|
|
|
|
@api.model
|
|
def _enable_check_printing_on_bank_journals(self):
|
|
""" Enables check printing payment method and add a check sequence on bank journals.
|
|
Called upon module installation via data file.
|
|
"""
|
|
check_method = self.env.ref('account_check_printing.account_payment_method_check')
|
|
for bank_journal in self.search([('type', '=', 'bank')]):
|
|
bank_journal._create_check_sequence()
|
|
bank_journal.outbound_payment_method_ids += check_method
|
|
|
|
def get_journal_dashboard_datas(self):
|
|
domain_checks_to_print = [
|
|
('journal_id', '=', self.id),
|
|
('payment_method_id.code', '=', 'check_printing'),
|
|
('state', '=', 'posted')
|
|
]
|
|
return dict(
|
|
super(AccountJournal, self).get_journal_dashboard_datas(),
|
|
num_checks_to_print=self.env['account.payment'].search_count(domain_checks_to_print),
|
|
)
|
|
|
|
def action_checks_to_print(self):
|
|
check_method = self.env.ref('account_check_printing.account_payment_method_check')
|
|
return {
|
|
'name': _('Checks to Print'),
|
|
'type': 'ir.actions.act_window',
|
|
'view_mode': 'list,form,graph',
|
|
'res_model': 'account.payment',
|
|
'context': dict(
|
|
self.env.context,
|
|
search_default_checks_to_send=1,
|
|
journal_id=self.id,
|
|
default_journal_id=self.id,
|
|
default_payment_type='outbound',
|
|
default_payment_method_id=check_method.id,
|
|
),
|
|
}
|