Issue
-----
- Currently the cron can take too much time and timeout.
In case of timeout process data are rollback.
The sync per user also crash and stop the process for all user and make
the transaction rollback
In both case we cannot ensure that all user will end up synchronized
- The real time sync can end up in deadlock:
If you create a holiday, it trigger a write on the user and the
creation of an event that will be synchronize with google
The synchronization may ask for a new token if this request fail
a new cursor is create to empty on the user the refresh token.
2 cursor that are trying to write on the same record => Deadlock
- Bad refresh token management
When the refresh token is not anymore valid it's erased but
the calendar_token and validity are kept. Is odoo consider
the token valid it will try to sync an event with google|microsoft
despite the refresh token is not valid anymore. Of course this lead to
an error and the impossibility to create an event anymore without
manually wiping the calendar_token and calendar_token_validity
- Error 401 are handled in context manager
(google|microsoft)_calendar_token, but get_*_calendar_token never raise
http error only user error.
Solution
---------
- Improve cron resilience
- Commit between each user and rollback in case of issue for a user
- Solve the issue when stop < start
- Solve issue with rrule not being the first element in the list
of recurrence
- Improve perf when searching for organizer
- In order to limit the volume during the first synchronization, we only
synchronized event from x days in the past to x days in the future with
x = 365 by default
- Limit the number of event to synchronize to google each time to 200,
since this operation is time consuming (1 request is sent per event)
- Avoid deadlock
A new cursor is not needed, we only need to ensure that write on the
user is done with a clean cursor and will be commited despite the error
raise. So rollabck before the write and commit explicitly afterwards
- Erase properly all the token and the token validity if the refresh token is not valid anymore
- For google calendar, erase also the token in case of 401
error: Wrong client id, this mean the database parameter have been
change and all the user should reconfigure the synchronization
- Directly handle error 401 with error 400 in refresh_token method
closes odoo/odoo#66250
X-original-commit: 486f69abad6226e5ce016ad89a0eeb103d709a3f
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
139 lines
6.5 KiB
Python
139 lines
6.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
import logging
|
|
import requests
|
|
from odoo.addons.microsoft_calendar.models.microsoft_sync import microsoft_calendar_token
|
|
from datetime import timedelta
|
|
|
|
from odoo import api, fields, models, _
|
|
from odoo.exceptions import UserError
|
|
from odoo.loglevels import exception_to_unicode
|
|
from odoo.addons.microsoft_calendar.utils.microsoft_calendar import MicrosoftCalendarService, InvalidSyncToken
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
class User(models.Model):
|
|
_inherit = 'res.users'
|
|
|
|
microsoft_calendar_sync_token = fields.Char('Microsoft Next Sync Token', copy=False)
|
|
microsoft_synchronization_stopped = fields.Boolean('Outlook Synchronization stopped', copy=False)
|
|
|
|
def __init__(self, pool, cr):
|
|
""" Override of __init__ to add access rights.
|
|
Access rights are disabled by default, but allowed
|
|
on some specific fields defined in self.SELF_{READ/WRITE}ABLE_FIELDS.
|
|
"""
|
|
microsoft_calendar_fields = [
|
|
'microsoft_synchronization_stopped',
|
|
]
|
|
init_res = super(User, self).__init__(pool, cr)
|
|
# duplicate list to avoid modifying the original reference
|
|
type(self).SELF_READABLE_FIELDS = type(self).SELF_READABLE_FIELDS + microsoft_calendar_fields
|
|
type(self).SELF_WRITEABLE_FIELDS = type(self).SELF_WRITEABLE_FIELDS + microsoft_calendar_fields
|
|
return init_res
|
|
|
|
def _microsoft_calendar_authenticated(self):
|
|
return bool(self.sudo().microsoft_calendar_rtoken)
|
|
|
|
def _get_microsoft_calendar_token(self):
|
|
self.ensure_one()
|
|
if self.microsoft_calendar_rtoken and not self._is_microsoft_calendar_valid():
|
|
self._refresh_microsoft_calendar_token()
|
|
return self.microsoft_calendar_token
|
|
|
|
def _is_microsoft_calendar_valid(self):
|
|
return self.microsoft_calendar_token_validity and self.microsoft_calendar_token_validity >= (fields.Datetime.now() + timedelta(minutes=1))
|
|
|
|
def _refresh_microsoft_calendar_token(self):
|
|
self.ensure_one()
|
|
get_param = self.env['ir.config_parameter'].sudo().get_param
|
|
client_id = get_param('microsoft_calendar_client_id')
|
|
client_secret = get_param('microsoft_calendar_client_secret')
|
|
|
|
if not client_id or not client_secret:
|
|
raise UserError(_("The account for the Outlook Calendar service is not configured."))
|
|
|
|
headers = {"content-type": "application/x-www-form-urlencoded"}
|
|
data = {
|
|
'refresh_token': self.microsoft_calendar_rtoken,
|
|
'client_id': client_id,
|
|
'client_secret': client_secret,
|
|
'grant_type': 'refresh_token',
|
|
}
|
|
|
|
try:
|
|
endpoint = self.env['microsoft.service']._get_token_endpoint()
|
|
dummy, response, dummy = self.env['microsoft.service']._do_request(endpoint, params=data, headers=headers, method='POST', preuri='')
|
|
ttl = response.get('expires_in')
|
|
self.write({
|
|
'microsoft_calendar_token': response.get('access_token'),
|
|
'microsoft_calendar_token_validity': fields.Datetime.now() + timedelta(seconds=ttl),
|
|
})
|
|
except requests.HTTPError as error:
|
|
if error.response.status_code in (400, 401): # invalid grant
|
|
# Delete refresh token and make sure it's commited
|
|
self.env.cr.rollback()
|
|
self.write({
|
|
'microsoft_calendar_rtoken': False,
|
|
'microsoft_calendar_token': False,
|
|
'microsoft_calendar_token_validity': False,
|
|
})
|
|
self.env.cr.commit()
|
|
error_key = error.response.json().get("error", "nc")
|
|
error_msg = _("Something went wrong during your token generation. Maybe your Authorization Code is invalid or already expired [%s]", error_key)
|
|
raise UserError(error_msg)
|
|
|
|
def _sync_microsoft_calendar(self, calendar_service: MicrosoftCalendarService):
|
|
self.ensure_one()
|
|
if self.microsoft_synchronization_stopped:
|
|
return False
|
|
full_sync = not bool(self.microsoft_calendar_sync_token)
|
|
with microsoft_calendar_token(self) as token:
|
|
try:
|
|
events, next_sync_token, default_reminders = calendar_service.get_events(self.microsoft_calendar_sync_token, token=token)
|
|
except InvalidSyncToken:
|
|
events, next_sync_token, default_reminders = calendar_service.get_events(token=token)
|
|
full_sync = True
|
|
self.microsoft_calendar_sync_token = next_sync_token
|
|
|
|
# Microsoft -> Odoo
|
|
recurrences = events.filter(lambda e: e.is_recurrent())
|
|
synced_events, synced_recurrences = self.env['calendar.event']._sync_microsoft2odoo(events, default_reminders=default_reminders) if events else (self.env['calendar.event'], self.env['calendar.recurrence'])
|
|
|
|
# Odoo -> Microsoft
|
|
recurrences = self.env['calendar.recurrence']._get_microsoft_records_to_sync(full_sync=full_sync)
|
|
recurrences -= synced_recurrences
|
|
recurrences._sync_odoo2microsoft(calendar_service)
|
|
synced_events |= recurrences.calendar_event_ids
|
|
|
|
events = self.env['calendar.event']._get_microsoft_records_to_sync(full_sync=full_sync)
|
|
(events - synced_events)._sync_odoo2microsoft(calendar_service)
|
|
|
|
return bool(events | synced_events) or bool(recurrences | synced_recurrences)
|
|
|
|
@api.model
|
|
def _sync_all_microsoft_calendar(self):
|
|
""" Cron job """
|
|
users = self.env['res.users'].search([('microsoft_calendar_rtoken', '!=', False), ('microsoft_synchronization_stopped', '=', False)])
|
|
microsoft = MicrosoftCalendarService(self.env['microsoft.service'])
|
|
for user in users:
|
|
_logger.info("Calendar Synchro - Starting synchronization for %s", user)
|
|
try:
|
|
user.with_user(user).sudo()._sync_microsoft_calendar(microsoft)
|
|
self.env.cr.commit()
|
|
except Exception as e:
|
|
_logger.exception("[%s] Calendar Synchro - Exception : %s !", user, exception_to_unicode(e))
|
|
self.env.cr.rollback()
|
|
|
|
def stop_microsoft_synchronization(self):
|
|
self.ensure_one()
|
|
self.microsoft_synchronization_stopped = True
|
|
|
|
def restart_microsoft_synchronization(self):
|
|
self.ensure_one()
|
|
self.microsoft_synchronization_stopped = False
|
|
self.env['calendar.recurrence']._restart_microsoft_sync()
|
|
self.env['calendar.event']._restart_microsoft_sync()
|