Romain Derie
4b39ad7167
If the website domain is wrongly configured (set to a URL that will actually be redirected through DNS/proxy/cloudflare etc), the website preview iframe will loop forever. The wrong configuration this commit is about are: - Having set the website domain to naked URL while you configured your naked URL to redirect to your `www` URL. - The other way around (`www` to naked URL). - Having set the website domain to `http` while you configured your `http` domain to redirect to your `https` domain. - The other way around (`https` to `http`) if it's even possible/done by someone While this could just be considered as a misconfiguration, it's a low effort to support it. Also, the bug it implies is quite critical as the user can't access his website app anymore (if he is smart enough and somehow figure it's because of the website domain, he will think about going to the General Settings to remove the domain). All in all, it's a low effort to fix a (rare) critical issue. Step to reproduce (`https`): - Go to runbot (in `https`, normal way) eg: https://21544921-16-0-all.runbot172.odoo.com/ - Edit the website domain and set it to the `http` version eg: http://21544921-16-0-all.runbot172.odoo.com/ - Try to access the website app, it will loop forever, indeed: 1. You are on the `https` URL in your browser tab 2. The website app will try to load the iframe with the website domain as URL, which is the `http` version. 3. The code in charge of loading the iframe URL (website_preview.js) will detect that `http` URL as originating from a different domain than the one of the current tab URL (parent window). 4. In this case, that code will reject that URL and instead load it in the parent window URL -> It will basically redirect your whole browser tab to that URL. This is done as if you are loading the URL of a different website, we want you to be completely redirect to this other website domain. 5. As `https` to `http` redirection (and naked -> www or www -> naked) is done at a lower level (through nginx, dns, cloudflare etc), the browser will not load the `http` requested URL but redirect and load the `https` one. 6. Now, you are basically back to step 1. and entering an infinite loop. The same issue can be reproduced with naked domain and `www` domain but not on runbot and difficult in local. You can also reproduce it in local, but it will just do the useless redirect once and won't loop as nothing is redirecting the naked to www in local: - Edit your `/etc/hosts` file and write ``` 127.0.0.1 rde.com 127.0.0.1 www.rde.com ``` - Edit your website domain to `http://www.rde.com` - Now go to `rde.com:8069` - It will wrongly redirect to `www` version ------------- On top of that, the domain misconfiguration would also lead to useless reload when using the website switcher (it would reload the whole page instead of just the iframe). Step to reproduce on local (on runbot it will be replicable but it will then enter the infinite loop described above): - (Still with the `/etc/hosts` tweak described above) - Edit the website_1 domain and set it to the `www` version eg: `http://www.rde.com:8069/` - Edit the website_2 domain and set it to the `naked` version eg: `http://rde.com:8069/` - Open the website app, land on one of the website (and its URL) - From there, select the other one, it will redirect the whole page to the other domain (naked vs www) instead of just reloading the iframe. ------------- opw-3079168 closes odoo/odoo#107394 X-original-commit: 0808659dd29db938bb6f8386ee2027eafecb2f0f Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Odoo Website Builder
Get an awesome and free website, easily customizable with the Odoo website builder.
Create enterprise grade website with our super easy builder. Use finely designed building blocks and edit everything inline.
Benefit from out-of-the-box business features; e-Commerce, events, blogs, jobs announces, customer references, call-to-actions, etc.
Edit Anything Inline
Create beautiful websites with no technical knowledge. Odoo's unique 'edit inline' approach makes website creation surprisingly easy. No more complex backend; just click anywhere to change any content.
"Want to change the price of a product? or put it in bold? Want to change a blog title?" Just click and change. What you see is what you get. Really.
Awesome. Astonishingly Beautiful.
Odoo's building blocks allow to design modern websites that are not possible with traditional WYSIWYG page editors.
Whether it's for products descriptions, blogs or static pages, you don't need to be a professional designer to create clean contents. Just drag and drop and customize predefined building blocks.
Enterprise-Ready, out-of-the-box
Activate ready-to-use enterprise features in just a click; e-commerce, call-to-actions, jobs announces, events, customer references, blogs, etc.
Traditional eCommerce and CMS have poorly designed backends as it's not their core focus. With the Odoo integration, you benefit from the best management software to follow-up on your orders, your jobs applicants, your leads, etc.
A Great Mobile Experience
Get a mobile friendly website thanks to our responsive design based on bootstrap. All your pages adapt automatically to the screen size. (mobile phones, tablets, desktop) You don't have to worry about mobile contents, it works by default.
SEO tools at your finger tips
The Promote tool suggests keywords according to Google most searched terms. Search Engine Optimization tools are ready to use, with no configuration required.
Google Analytics tracks your shopping cart events by default. Sitemap and structured content are created automatically for Google indexation.
Multi-Languages Made Easy
Get your website translated in multiple languages with no effort. Odoo proposes and propagates translations automatically across pages, following what you edit on the master page.
Designer-Friendly Templates
Templates are awesome and easy to design. You don't need to develop to create new pages, themes or building blocks. We use a clean HTML structure, a bootstrap CSS.
Customize every page on the fly with the integrated template editor. Distribute your work easily as an Odoo module.
Fluid Grid Layouting
Design perfect pages by drag and dropping building blocks. Move and scale them to fit the layout you are looking for.
Building blocks are based on a responsive, mobile friendly fluid grid system that appropriately scales up to 12 columns as the device or viewport size increases.
Professional Themes
Design a custom theme or reuse pre-defined themes to customize the look and feel of your website.
Test new color scheme easily; you can change your theme at any time in just a click.
Integrated With Odoo Apps
e-Commerce
Promote products, sell online, optimize visitors' shopping experience.
Blogs
Write news, attract new visitors, build customer loyalty.
Online Events
Schedule, organize, promote or sell events online; conferences, trainings, webinars, etc.