Yannick Tivisse
8f6ec58757
Purpose ======= Currently we are updating the coupon rewards on the fly when creating/modifying/deleting a sales order line. To avoid multiple searches on res_partners and product to know whether the customer/product is valid on the sale coupon program, we store the applicable customers and products on the program according to the domain defined on it. This brings 2 issues: - The customers/products stored on the program are not updated (Was the original spec) - The checks are numerous and maybe overkill for the given results Specification ============= - Don't recompute the reward lines on SO modifications. Add a button to compute the line by hand and make an automatic compute on the SO validation or on the page shop/payment. - When recomputing the reward lines, make a search on the res_partners and products instead. Now that the action is not triggered so often we can afford to make a search. - Don't use the fields rule_partners_domain and rule_products_domain. This should be removed in master. - The field is_public_included is useless now. And we decided to make the coupon available for all the partners if they fit the domain on the program.
60 lines
3.2 KiB
Python
60 lines
3.2 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from openerp.addons.sale_coupon.tests.common import TestSaleCouponCommon
|
|
|
|
|
|
class TestProgramWithoutCodeOperations(TestSaleCouponCommon):
|
|
# Test some basic operation (create, write, unlink) on an immediate coupon program on which we should
|
|
# apply or remove the reward automatically, as there's no program code.
|
|
|
|
def test_immediate_program_basic_operation(self):
|
|
|
|
# 2 products A are needed
|
|
self.immediate_promotion_program.write({'rule_min_quantity': 2.0})
|
|
order = self.empty_order
|
|
# Test case 1 (1 A): Assert that no reward is given, as the product B is missing
|
|
order.write({'order_line': [
|
|
(0, False, {
|
|
'product_id': self.product_A.id,
|
|
'name': '1 Product A',
|
|
'product_uom': self.uom_unit.id,
|
|
'product_uom_qty': 1.0,
|
|
})
|
|
]})
|
|
order.recompute_coupon_lines()
|
|
self.assertEqual(len(order.order_line.ids), 1, "The promo offer shouldn't have been applied as the product B isn't in the order")
|
|
|
|
# Test case 2 (1 A 1 B): Assert that no reward is given, as the product B is not present in the correct quantity
|
|
order.write({'order_line': [
|
|
(0, False, {
|
|
'product_id': self.product_B.id,
|
|
'name': '2 Product B',
|
|
'product_uom': self.uom_unit.id,
|
|
'product_uom_qty': 1.0,
|
|
})
|
|
]})
|
|
order.recompute_coupon_lines()
|
|
self.assertEqual(len(order.order_line.ids), 2, "The promo offer shouldn't have been applied as 2 product A aren't in the order")
|
|
|
|
# Test case 3 (2 A 1 B): Assert that the reward is given as the product B is now in the order
|
|
order.write({'order_line': [(1, order.order_line[0].id, {'product_uom_qty': 2.0})]})
|
|
order.recompute_coupon_lines()
|
|
self.assertEqual(len(order.order_line.ids), 3, "The promo offert should have been applied, the discount is not created")
|
|
|
|
# Test case 4 (1 A 1 B): Assert that the reward is removed as we don't buy 2 products B anymore
|
|
order.write({'order_line': [(1, order.order_line[0].id, {'product_uom_qty': 1.0})]})
|
|
order.recompute_coupon_lines()
|
|
self.assertEqual(len(order.order_line.ids), 2, "The promo reward should have been removed as the rules are not matched anymore")
|
|
self.assertEqual(order.order_line[0].product_id.id, self.product_A.id, "The wrong line has been removed")
|
|
self.assertEqual(order.order_line[1].product_id.id, self.product_B.id, "The wrong line has been removed")
|
|
|
|
# Test case 5 (1 B): Assert that the reward is removed when the order is modified and doesn't match the rules anymore
|
|
order.write({'order_line': [
|
|
(1, order.order_line[0].id, {'product_uom_qty': 2.0}),
|
|
(2, order.order_line[0].id, False)
|
|
]})
|
|
order.recompute_coupon_lines()
|
|
self.assertEqual(len(order.order_line.ids), 1, "The promo reward should have been removed as the rules are not matched anymore")
|
|
self.assertEqual(order.order_line.product_id.id, self.product_B.id, "The wrong line has been removed")
|