Files
odoo_source/addons/rating/controllers/main.py
T
damr 00892a3edb [FIX] 14.0 rating: submit rating feedback with 'get' method
In rating/controllers/main.py, the method action_submit_rating accepts
only post request. This creates a problem when you're trying to use the
web editor on the template as well as when you just paste the url in
your browser, for those are get request. The current behavior is a crash
with 'method not allowed'. This commit's purpose is to change the method
so it also accept get request. The use case of editing the feedback
rating page is arguable but it schould not crash.

The behavior after this commit is that the web editor is enable for the
page, and relaoding the page does not crash anymore.

task-3047893

closes odoo/odoo#105985

X-original-commit: 1b61faad8281d8b8d2fa1bf526f2ae2c4c8ba07b
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
2022-11-17 21:58:53 +01:00

79 lines
2.7 KiB
Python

# -*- coding: utf-8 -*-
# Part of Odoo. See LICENSE file for full copyright and licensing details.
import logging
import werkzeug
from odoo import http
from odoo.http import request
from odoo.tools.translate import _
from odoo.tools.misc import get_lang
_logger = logging.getLogger(__name__)
MAPPED_RATES = {
1: 1,
5: 3,
10: 5,
}
class Rating(http.Controller):
@http.route('/rate/<string:token>/<int:rate>', type='http', auth="public", website=True)
def action_open_rating(self, token, rate, **kwargs):
if rate not in (1, 3, 5):
raise ValueError(_("Incorrect rating: should be 1, 3 or 5 (received %d)"), rate)
rating, record_sudo = self._get_rating_and_record(token)
record_sudo.rating_apply(
rate,
rating=rating,
feedback=_('Customer rated %r.', record_sudo.display_name),
subtype_xmlid=None,
notify_delay_send=True,
)
lang = rating.partner_id.lang or get_lang(request.env).code
return request.env['ir.ui.view'].with_context(lang=lang)._render_template('rating.rating_external_page_submit', {
'rating': rating,
'token': token,
'rate_names': {
5: _("Satisfied"),
3: _("Okay"),
1: _("Dissatisfied"),
},
'rate': rate,
})
@http.route(['/rate/<string:token>/submit_feedback'], type="http", auth="public", methods=['post', 'get'], website=True)
def action_submit_rating(self, token, rate=0, **kwargs):
rating, record_sudo = self._get_rating_and_record(token)
if request.httprequest.method == "POST":
rate = int(rate)
if rate not in (1, 3, 5):
raise ValueError(_("Incorrect rating: should be 1, 3 or 5 (received %d)"), rate)
record_sudo.rating_apply(
rate,
rating=rating,
feedback=kwargs.get('feedback'),
subtype_xmlid=None, # force default subtype choice
)
lang = rating.partner_id.lang or get_lang(request.env).code
return request.env['ir.ui.view'].with_context(lang=lang)._render_template('rating.rating_external_page_view', {
'web_base_url': rating.get_base_url(),
'rating': rating,
})
def _get_rating_and_record(self, token):
rating_sudo = request.env['rating.rating'].sudo().search([('access_token', '=', token)])
if not rating_sudo:
raise werkzeug.exceptions.NotFound()
record_sudo = request.env[rating_sudo.res_model].sudo().browse(rating_sudo.res_id)
if not record_sudo.exists():
raise werkzeug.exceptions.NotFound()
return rating_sudo, record_sudo