Géry Debongnie
a7cd003173
Whenever an user updates a company or a currency, the webclient has to reload, to properly apply these changes. It is done automatically, immediately after the rpc has completed. However, before this commit, it would do that always, even if the rpc has failed (for example, if the user tried updating an invalid field), so the user would briefly see an error window, then the browser is immediately reloaded. With this commit, we only reload the webclient when the rpc succeeded. closes odoo/odoo#119730 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
58 lines
2.0 KiB
JavaScript
58 lines
2.0 KiB
JavaScript
/** @odoo-module **/
|
|
|
|
import { ormService } from "@web/core/orm_service";
|
|
import { registry } from "@web/core/registry";
|
|
import { currencyService } from "@web/webclient/currency_service";
|
|
import { makeTestEnv } from "../helpers/mock_env";
|
|
import { makeFakeRPCService } from "../helpers/mock_services";
|
|
|
|
const serviceRegistry = registry.category("services");
|
|
|
|
QUnit.module("currency service");
|
|
|
|
QUnit.test("reload currencies when updating a res.currency", async (assert) => {
|
|
serviceRegistry.add("currency", currencyService);
|
|
serviceRegistry.add("orm", ormService);
|
|
const fakeRpc = makeFakeRPCService((route) => {
|
|
assert.step(route);
|
|
});
|
|
serviceRegistry.add("rpc", fakeRpc);
|
|
const env = await makeTestEnv();
|
|
assert.verifySteps([]);
|
|
await env.services.orm.read("res.currency", [32]);
|
|
assert.verifySteps(["/web/dataset/call_kw/res.currency/read"]);
|
|
await env.services.orm.unlink("res.currency", [32]);
|
|
assert.verifySteps([
|
|
"/web/dataset/call_kw/res.currency/unlink",
|
|
"/web/session/get_session_info",
|
|
]);
|
|
await env.services.orm.unlink("notcurrency", [32]);
|
|
assert.verifySteps(["/web/dataset/call_kw/notcurrency/unlink"]);
|
|
});
|
|
|
|
QUnit.test(
|
|
"do not reload webclient when updating a res.currency, but there is an error",
|
|
async (assert) => {
|
|
const fakeRpc = makeFakeRPCService((route) => {
|
|
assert.step(route);
|
|
});
|
|
serviceRegistry.add("rpc", fakeRpc);
|
|
serviceRegistry.add("currency", currencyService);
|
|
|
|
const env = await makeTestEnv();
|
|
assert.verifySteps([]);
|
|
env.bus.trigger("RPC:RESPONSE", {
|
|
data: { params: { model: "res.currency", method: "write" } },
|
|
settings: {},
|
|
result: {},
|
|
});
|
|
assert.verifySteps(["/web/session/get_session_info"]);
|
|
env.bus.trigger("RPC:RESPONSE", {
|
|
data: { params: { model: "res.currency", method: "write" } },
|
|
settings: {},
|
|
error: {},
|
|
});
|
|
assert.verifySteps([]);
|
|
}
|
|
);
|