Alvaro FuentesandChristophe Simonis
c18b9f44be
When we use the `|` (or) version of this rule the ORM generates two
sub-queries when checking the company. This causes sub-optimal and in
some cases really bad planning for the queries and thus PG takes hours
to complete them.
Example (formatted):
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE ("mrp_bom"."company_id" in (1))
)
)
OR ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE "mrp_bom"."company_id" IS NULL
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
If we use the single term version the generated query has only one
sub-query:
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE (("mrp_bom"."company_id" in (1))
OR ("mrp_bom"."company_id" IS NULL))
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
In this version PG is able to produce a better query plan resulting in
better execution times.
Also, the `company_id` field is required on some models, so the "= False" comparison is useless.
closes odoo/odoo#159123
X-original-commit: 1b5c41f36801fb886ec591f29dba42787d698526
Related: odoo/enterprise#59378
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
Co-authored-by: Christophe Simonis <chs@odoo.com>
71 lines
3.5 KiB
XML
71 lines
3.5 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<odoo noupdate="1">
|
|
|
|
<record id="mail_test_multi_company_rule" model="ir.rule">
|
|
<field name="name">Mail Test Multi Company</field>
|
|
<field name="model_id" ref="test_mail.model_mail_test_multi_company"/>
|
|
<field eval="True" name="global"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="mail_test_multi_company_read_rule" model="ir.rule">
|
|
<field name="name">MC Readonly Rule</field>
|
|
<field name="model_id" ref="test_mail.model_mail_test_multi_company_read"/>
|
|
<field name="perm_read" eval="False"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
<field name="global" eval="True"/>
|
|
</record>
|
|
|
|
<record id="mail_test_multi_company_with_activity_rule" model="ir.rule">
|
|
<field name="name">Mail Test Multi Company With Activity</field>
|
|
<field name="model_id" ref="test_mail.model_mail_test_multi_company_with_activity"/>
|
|
<field eval="True" name="global"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<!-- TICKET-LIKE -->
|
|
<record id="mail_test_ticket_rule_portal" model="ir.rule">
|
|
<field name="name">Portal Mail Test Ticket</field>
|
|
<field name="model_id" ref="test_mail.model_mail_test_ticket"/>
|
|
<field name="domain_force">[('message_partner_ids', 'in', [user.partner_id.id])]</field>
|
|
<field name="groups" eval="[(4, ref('base.group_portal'))]"/>
|
|
</record>
|
|
|
|
<!-- MULTI COMPANY TICKET LIKE -->
|
|
<record id="mail_test_ticket_mc_rule" model="ir.rule">
|
|
<field name="name">Mail Test Ticket Multi Company</field>
|
|
<field name="model_id" ref="test_mail.model_mail_test_ticket_mc"/>
|
|
<field name="global" eval="True"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
<record id="mail_test_ticket_mc_rule_portal" model="ir.rule">
|
|
<field name="name">Portal Mail Test Ticket Multi Company</field>
|
|
<field name="model_id" ref="test_mail.model_mail_test_ticket_mc"/>
|
|
<field name="domain_force">[('message_partner_ids', 'in', [user.partner_id.id])]</field>
|
|
<field name="groups" eval="[(4, ref('base.group_portal'))]"/>
|
|
</record>
|
|
|
|
<!-- PROJECT-LIKE -->
|
|
<record id="mail_test_container_rule_portal" model="ir.rule">
|
|
<field name="name">Portal Mail Test Container</field>
|
|
<field name="model_id" ref="test_mail.model_mail_test_container"/>
|
|
<field name="domain_force">[('message_partner_ids', 'in', [user.partner_id.id])]</field>
|
|
<field name="groups" eval="[(4, ref('base.group_portal'))]"/>
|
|
</record>
|
|
|
|
<!-- MULTI COMPANY PROJECT LIKE -->
|
|
<record id="mail_test_container_mc_rule" model="ir.rule">
|
|
<field name="name">Mail Test Container Multi Company</field>
|
|
<field name="model_id" ref="test_mail.model_mail_test_container_mc"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
<field name="global" eval="True"/>
|
|
</record>
|
|
<record id="mail_test_container_mc_rule_portal" model="ir.rule">
|
|
<field name="name">Portal Mail Test Container Multi Company</field>
|
|
<field name="model_id" ref="test_mail.model_mail_test_container_mc"/>
|
|
<field name="domain_force">[('message_partner_ids', 'in', [user.partner_id.id])]</field>
|
|
<field name="groups" eval="[(4, ref('base.group_portal'))]"/>
|
|
</record>
|
|
|
|
</odoo>
|