Alvaro FuentesandChristophe Simonis
c18b9f44be
When we use the `|` (or) version of this rule the ORM generates two
sub-queries when checking the company. This causes sub-optimal and in
some cases really bad planning for the queries and thus PG takes hours
to complete them.
Example (formatted):
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE ("mrp_bom"."company_id" in (1))
)
)
OR ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE "mrp_bom"."company_id" IS NULL
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
If we use the single term version the generated query has only one
sub-query:
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE (("mrp_bom"."company_id" in (1))
OR ("mrp_bom"."company_id" IS NULL))
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
In this version PG is able to produce a better query plan resulting in
better execution times.
Also, the `company_id` field is required on some models, so the "= False" comparison is useless.
closes odoo/odoo#159123
X-original-commit: 1b5c41f36801fb886ec591f29dba42787d698526
Related: odoo/enterprise#59378
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
Co-authored-by: Christophe Simonis <chs@odoo.com>
70 lines
3.4 KiB
XML
70 lines
3.4 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<odoo>
|
|
<!-- This group is only allowed to deal with equipment registration and maintenance -->
|
|
<record id="group_equipment_manager" model="res.groups">
|
|
<field name="name">Equipment Manager</field>
|
|
<field name="category_id" ref="base.module_category_manufacturing_maintenance"/>
|
|
<field name="implied_ids" eval="[(4, ref('base.group_user'))]"/>
|
|
<field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>
|
|
<field name="comment">The user will be able to manage equipment.</field>
|
|
</record>
|
|
|
|
<data noupdate="1">
|
|
|
|
<!-- Rules -->
|
|
<record id="equipment_request_rule_user" model="ir.rule">
|
|
<field name="name">Users are allowed to access their own maintenance requests</field>
|
|
<field name="model_id" ref="model_maintenance_request"/>
|
|
<field name="domain_force">['|', '|', ('owner_user_id', '=', user.id), ('message_partner_ids', 'in', [user.partner_id.id]), ('user_id', '=', user.id)]</field>
|
|
<field name="groups" eval="[(4, ref('base.group_user'))]"/>
|
|
</record>
|
|
|
|
<record id="equipment_rule_user" model="ir.rule">
|
|
<field name="name">Users are allowed to access equipment they follow</field>
|
|
<field name="model_id" ref="model_maintenance_equipment"/>
|
|
<field name="domain_force">[('message_partner_ids', 'in', [user.partner_id.id])]</field>
|
|
<field name="groups" eval="[(4, ref('base.group_user'))]"/>
|
|
</record>
|
|
|
|
<record id="equipment_request_rule_admin_user" model="ir.rule">
|
|
<field name="name">Administrator of maintenance requests</field>
|
|
<field name="model_id" ref="model_maintenance_request"/>
|
|
<field name="domain_force">[(1, '=', 1)]</field>
|
|
<field name="groups" eval="[(4, ref('group_equipment_manager'))]"/>
|
|
</record>
|
|
|
|
<record id="equipment_rule_admin_user" model="ir.rule">
|
|
<field name="name">Equipment administrator</field>
|
|
<field name="model_id" ref="model_maintenance_equipment"/>
|
|
<field name="domain_force">[(1, '=', 1)]</field>
|
|
<field name="groups" eval="[(4, ref('group_equipment_manager'))]"/>
|
|
</record>
|
|
|
|
<record id="maintenance_request_comp_rule" model="ir.rule">
|
|
<field name="name">Maintenance Request Multi-company rule</field>
|
|
<field name="model_id" ref="model_maintenance_request"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="maintenance_equipment_comp_rule" model="ir.rule">
|
|
<field name="name">Maintenance Equipment Multi-company rule</field>
|
|
<field name="model_id" ref="model_maintenance_equipment"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="maintenance_team_comp_rule" model="ir.rule">
|
|
<field name="name">Maintenance Team Multi-company rule</field>
|
|
<field name="model_id" ref="model_maintenance_team"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="maintenance_equipment_category_comp_rule" model="ir.rule">
|
|
<field name="name">Maintenance Equipment Category Multi-company rule</field>
|
|
<field name="model_id" ref="model_maintenance_equipment_category"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
</data>
|
|
|
|
</odoo>
|