Rémy Voet (ryv)
5a573c6f18
Issue ----- Via the field prefetch mechanism, when we need a value of one field (not in cache of course), the ORM will prefetch all fields (which has the attribute to `prefetch=True`, the default value of this attribute is `True`) for all record ids in `_prefetch_ids`. Then, for each translate fields (where translate is not a callable) the ORM need to make a `LEFT JOIN` on the `ir_translation` to fetch the translated value. For big model, it leads to a simple `SELECT` with several `LEFT JOIN` on ir_translation but each LEFT JOIN have a cost in the planner time (a small cost in the execution time) of PostgreSQL. By example, for `product.template` (stock/sale/purchase installed), there are 6 LEFT JOIN to get all translated fields (5 of this fields are rarely used). Proposed solution ----------------- Deactivate the prefetch by default for all translate fields expect if this field is the `_rec_name` of the model (which is more likely to be used). In the example on the `product.template`: Without prefetching the translated fields, there is only one LEFT JOIN (the name, which is translated but is the `_rec_name` of the model). With the 6 translated fields to fetch, the query takes 5 ms to plan and 2 ms to execute VS with 1 translate field, it 1 ms to plan and 1.5 ms to execute. Side change note ---------------- - All translate of fields of `website.seo.metadata` should be prefetch to avoid lot of website errors (it is because, website put in cache data in sudo before reading it without sudo) - `description` (`mail.message.subtype`), `subject` (`mail.template`), `body_html` (`mail.template`) should be prefetch to avoid lot of extra query from mail module. - `vat_label` (`res.country`) should be prefetch to avoid a extra query for each website page. - Increase some queryCount (when it is legit, due to `subtitle` of `blog_post` or `description` of `event.type.ticket`, etc) task-2738029 closes odoo/odoo#82896 Signed-off-by: Raphael Collet <rco@odoo.com>
43 lines
2.0 KiB
Python
43 lines
2.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.addons.website.tests.test_performance import UtilPerf
|
|
import random
|
|
|
|
|
|
class TestBlogPerformance(UtilPerf):
|
|
def setUp(self):
|
|
super().setUp()
|
|
# if website_livechat is installed, disable it
|
|
if 'channel_id' in self.env['website']:
|
|
self.env['website'].search([]).channel_id = False
|
|
|
|
def test_10_perf_sql_blog_standard_data(self):
|
|
self.assertEqual(self._get_url_hot_query('/blog'), 27)
|
|
|
|
def test_20_perf_sql_blog_bigger_data_scaling(self):
|
|
BlogPost = self.env['blog.post']
|
|
BlogTag = self.env['blog.tag']
|
|
blogs = self.env['blog.blog'].search([])
|
|
blog_tags = BlogTag.create([{'name': 'Blog Tag Test %s' % i} for i in range(1, 20)])
|
|
BlogPost.create([{'name': 'Blog Post Test %s' % i, 'is_published': True, 'blog_id': blogs[i % 2].id} for i in range(1, 20)])
|
|
blog_posts = BlogPost.search([])
|
|
for blog_post in blog_posts:
|
|
blog_post.tag_ids += blog_tags
|
|
blog_tags = blog_tags[:-1]
|
|
self.assertEqual(self._get_url_hot_query('/blog'), 27)
|
|
self.assertEqual(self._get_url_hot_query(blog_post[0].website_url), 31)
|
|
|
|
def test_30_perf_sql_blog_bigger_data_scaling(self):
|
|
BlogPost = self.env['blog.post']
|
|
BlogTag = self.env['blog.tag']
|
|
blogs = self.env['blog.blog'].search([])
|
|
blog_tags = BlogTag.create([{'name': 'New Blog Tag Test %s' % i} for i in range(1, 50)])
|
|
BlogPost.create([{'name': 'New Blog Post Test %s' % i, 'is_published': True, 'blog_id': blogs[random.randint(0, 1)].id} for i in range(1, 100)])
|
|
blog_posts = BlogPost.search([])
|
|
for blog_post in blog_posts:
|
|
blog_post.write({'tag_ids': [[6, 0, random.choices(blog_tags.ids, k=random.randint(0, len(blog_tags)))]]})
|
|
|
|
self.assertLessEqual(self._get_url_hot_query('/blog'), 28)
|
|
self.assertLessEqual(self._get_url_hot_query(blog_post[0].website_url), 31)
|