Hubert Van de Walle
e5f35a6074
Steps to follow
- Select only one company in the company selector but not the default one
from the current user;
- Go the the CRM app;
- Create a lead;
-> A multi company error appears !
Solution
- The default team is now restricted to the companies in the context
- When computing a lead's company_id when the team has no company, keep only
the ones within the allowed_company_ids;
opw-2713757
closes odoo/odoo#83764
X-original-commit: 58b9b3e839c7725fdcd66376564ce6554a4b82ac
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
190 lines
8.3 KiB
Python
190 lines
8.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.addons.crm.tests.common import TestCrmCommon
|
|
from odoo.exceptions import AccessError
|
|
from odoo.tests import Form, tagged
|
|
from odoo.tests.common import users
|
|
|
|
|
|
@tagged('multi_company')
|
|
class TestCRMLeadMultiCompany(TestCrmCommon):
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super(TestCRMLeadMultiCompany, cls).setUpClass()
|
|
cls._activate_multi_company()
|
|
|
|
def test_initial_data(self):
|
|
""" Ensure global data for those tests to avoid unwanted side effects """
|
|
self.assertFalse(self.sales_team_1.company_id)
|
|
self.assertEqual(self.user_sales_manager_mc.company_id, self.company_2)
|
|
|
|
@users('user_sales_manager_mc')
|
|
def test_lead_mc_company_computation(self):
|
|
""" Test lead company computation depending on various parameters. Check
|
|
the company is set from the team_id or from the env if there is no team.
|
|
No responsible, no team, should not limit company. """
|
|
# Lead with falsy values are kept
|
|
lead_no_team = self.env['crm.lead'].create({
|
|
'name': 'L1',
|
|
'team_id': False,
|
|
'user_id': False,
|
|
})
|
|
self.assertFalse(lead_no_team.company_id)
|
|
self.assertFalse(lead_no_team.team_id)
|
|
self.assertFalse(lead_no_team.user_id)
|
|
|
|
# Lead with team with company sets company
|
|
lead_team_c2 = self.env['crm.lead'].create({
|
|
'name': 'L2',
|
|
'team_id': self.team_company2.id,
|
|
'user_id': False,
|
|
})
|
|
self.assertEqual(lead_team_c2.company_id, self.company_2)
|
|
self.assertFalse(lead_team_c2.user_id)
|
|
|
|
# Update team wo company: reset lead company also
|
|
lead_team_c2.team_id = self.sales_team_1
|
|
self.assertFalse(lead_team_c2.company_id)
|
|
|
|
# Lead with global team has no company
|
|
lead_team_no_company = self.env['crm.lead'].create({
|
|
'name': 'No company',
|
|
'team_id': self.sales_team_1.id,
|
|
'user_id': False,
|
|
})
|
|
self.assertFalse(lead_no_team.company_id)
|
|
|
|
# Update team w company updates company
|
|
lead_team_no_company.team_id = self.team_company2
|
|
self.assertEqual(lead_team_no_company.company_id, self.company_2)
|
|
self.assertEqual(lead_team_no_company.team_id, self.team_company2)
|
|
|
|
@users('user_sales_manager_mc')
|
|
def test_lead_mc_company_computation_env_team_norestrict(self):
|
|
""" Check that the computed company is the one coming from the team even
|
|
when it's not in self.env.companies. This may happen when running the
|
|
Lead Assignment task. """
|
|
LeadUnsyncCids = self.env['crm.lead'].with_context(allowed_company_ids=[self.company_main.id])
|
|
self.assertEqual(LeadUnsyncCids.env.company, self.company_main)
|
|
self.assertEqual(LeadUnsyncCids.env.companies, self.company_main)
|
|
self.assertEqual(LeadUnsyncCids.env.user.company_id, self.company_2)
|
|
|
|
# multicompany raises if trying to create manually
|
|
with self.assertRaises(AccessError):
|
|
lead = LeadUnsyncCids.create({
|
|
'name': 'My Lead MC',
|
|
'team_id': self.team_company2.id
|
|
})
|
|
|
|
# simulate auto-creation through sudo (assignment-like)
|
|
lead = LeadUnsyncCids.sudo().create({
|
|
'name': 'My Lead MC',
|
|
'team_id': self.team_company2.id,
|
|
})
|
|
self.assertEqual(lead.company_id, self.company_2)
|
|
self.assertEqual(lead.team_id, self.team_company2)
|
|
self.assertEqual(lead.user_id, self.user_sales_manager_mc)
|
|
|
|
@users('user_sales_manager_mc')
|
|
def test_lead_mc_company_computation_env_user_restrict(self):
|
|
""" Check that the computed company is allowed (aka in self.env.companies).
|
|
User is logged in company_main even his default default company is
|
|
company_2. """
|
|
LeadUnsyncCids = self.env['crm.lead'].with_context(allowed_company_ids=[self.company_main.id])
|
|
self.assertEqual(LeadUnsyncCids.env.company, self.company_main)
|
|
self.assertEqual(LeadUnsyncCids.env.companies, self.company_main)
|
|
self.assertEqual(LeadUnsyncCids.env.user.company_id, self.company_2)
|
|
|
|
# simulate auto-creation through sudo (assignment-like)
|
|
lead = LeadUnsyncCids.sudo().create({
|
|
'name': 'My Lead MC',
|
|
})
|
|
self.assertFalse(lead.company_id,
|
|
'Lead: due to MC rule, avoid setting a company when it would cause crashes')
|
|
self.assertEqual(lead.team_id, self.sales_team_1,
|
|
'Lead: due to MC rule, took first availability in other company')
|
|
self.assertEqual(lead.user_id, self.user_sales_manager_mc)
|
|
|
|
# manual creation
|
|
lead = LeadUnsyncCids.create({
|
|
'name': 'My Lead MC',
|
|
})
|
|
self.assertFalse(lead.company_id,
|
|
'Lead: due to MC rule, avoid setting a company when it would cause crashes')
|
|
self.assertEqual(lead.team_id, self.sales_team_1)
|
|
self.assertEqual(lead.user_id, self.user_sales_manager_mc)
|
|
|
|
@users('user_sales_manager_mc')
|
|
def test_lead_mc_company_form(self):
|
|
""" Test lead company computation using form view """
|
|
crm_lead_form = Form(self.env['crm.lead'])
|
|
crm_lead_form.name = "Test Lead"
|
|
|
|
# default values: current user, its team and therefore its company
|
|
self.assertEqual(crm_lead_form.company_id, self.company_2)
|
|
self.assertEqual(crm_lead_form.user_id, self.user_sales_manager_mc)
|
|
self.assertEqual(crm_lead_form.team_id, self.team_company2)
|
|
|
|
# remove user, team only
|
|
crm_lead_form.user_id = self.env['res.users']
|
|
self.assertEqual(crm_lead_form.company_id, self.company_2)
|
|
self.assertEqual(crm_lead_form.user_id, self.env['res.users'])
|
|
self.assertEqual(crm_lead_form.team_id, self.team_company2)
|
|
|
|
# remove team, user only
|
|
crm_lead_form.user_id = self.user_sales_manager_mc
|
|
crm_lead_form.team_id = self.env['crm.team']
|
|
self.assertEqual(crm_lead_form.company_id, self.company_2)
|
|
self.assertEqual(crm_lead_form.user_id, self.user_sales_manager_mc)
|
|
self.assertEqual(crm_lead_form.team_id, self.env['crm.team'])
|
|
|
|
# remove both: void company to ease assignment
|
|
crm_lead_form.user_id = self.env['res.users']
|
|
self.assertEqual(crm_lead_form.company_id, self.env['res.company'])
|
|
self.assertEqual(crm_lead_form.user_id, self.env['res.users'])
|
|
self.assertEqual(crm_lead_form.team_id, self.env['crm.team'])
|
|
|
|
# force company manually
|
|
crm_lead_form.company_id = self.company_2
|
|
lead = crm_lead_form.save()
|
|
|
|
# user_sales_manager cannot read it due to MC rules
|
|
with self.assertRaises(AccessError):
|
|
lead.with_user(self.user_sales_manager).read(['name'])
|
|
|
|
@users('user_sales_manager_mc')
|
|
def test_lead_mc_company_form_progressives_setup(self):
|
|
""" Specific bug reported at Task-2520276. Flow
|
|
0) The sales team have no company set
|
|
1) Create a lead without a user_id and a team_id
|
|
2) Assign a team to the lead
|
|
3) Assign a user_id
|
|
|
|
Goal: if no company is set on the sales team the lead at step 2 should
|
|
not have any company_id set. Previous behavior
|
|
1) set the company of the env.user
|
|
2) Keep the company of the lead
|
|
3) set the user company if the current company is not one of the allowed company of the user
|
|
|
|
Wanted behavior
|
|
1) leave the company empty
|
|
2) set the company of the team even if it's False (so erase the company if the team has no company set)
|
|
3) set the user company if the current company is not one of the allowed company of the user
|
|
"""
|
|
lead = self.env['crm.lead'].create({
|
|
'name': 'Test Progressive Setup',
|
|
'user_id': False,
|
|
'team_id': False,
|
|
})
|
|
crm_lead_form = Form(lead)
|
|
self.assertEqual(crm_lead_form.company_id, self.env['res.company'])
|
|
|
|
crm_lead_form.team_id = self.sales_team_1
|
|
self.assertEqual(crm_lead_form.company_id, self.env['res.company'])
|
|
|
|
crm_lead_form.user_id = self.env.user
|
|
# self.assertEqual(crm_lead_form.company_id, self.env['res.company']) # FIXME
|
|
self.assertEqual(crm_lead_form.company_id, self.company_2)
|