Damien Bouvy
f023d89dba
SIPS sometimes send empty notifications. I have been unable to find out why or to reproduce the issue; it seems to be linked to a delay on their end since these notifications usually arrive after a customer is redirected back to Odoo (at least on their test account). I'd rather log a warning for those cases (since nothing is wrong on Odoo's side, there's just no info to act upon) instead of a full traceback. closes odoo/odoo#49335 X-original-commit: 100ef1bdb7b90edbeccfa6cd10297acb824b8083 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
54 lines
1.8 KiB
Python
54 lines
1.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright 2015 Eezee-It
|
|
|
|
import json
|
|
import logging
|
|
import pprint
|
|
import werkzeug
|
|
|
|
from odoo import http
|
|
from odoo.http import request
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
class SipsController(http.Controller):
|
|
_notify_url = '/payment/sips/ipn/'
|
|
_return_url = '/payment/sips/dpn/'
|
|
|
|
def sips_validate_data(self, **post):
|
|
sips = request.env['payment.acquirer'].search([('provider', '=', 'sips')], limit=1)
|
|
security = sips.sudo()._sips_generate_shasign(post)
|
|
if security == post['Seal']:
|
|
_logger.debug('Sips: validated data')
|
|
return request.env['payment.transaction'].sudo().form_feedback(post, 'sips')
|
|
_logger.warning('Sips: data are corrupted')
|
|
return False
|
|
|
|
@http.route([
|
|
'/payment/sips/ipn/'],
|
|
type='http', auth='public', methods=['POST'], csrf=False)
|
|
def sips_ipn(self, **post):
|
|
""" Sips IPN. """
|
|
_logger.info('Beginning Sips IPN form_feedback with post data %s', pprint.pformat(post)) # debug
|
|
if not post:
|
|
# SIPS sometimes send empty notification, the reason why is
|
|
# unclear but they tend to pollute logs and do not provide any
|
|
# meaningful information; log as a warning instead of a traceback
|
|
_logger.warning('Sips: received empty notification; skip.')
|
|
else:
|
|
self.sips_validate_data(**post)
|
|
return ''
|
|
|
|
@http.route([
|
|
'/payment/sips/dpn'], type='http', auth="public", methods=['POST'], csrf=False)
|
|
def sips_dpn(self, **post):
|
|
""" Sips DPN """
|
|
try:
|
|
_logger.info('Beginning Sips DPN form_feedback with post data %s', pprint.pformat(post)) # debug
|
|
self.sips_validate_data(**post)
|
|
except:
|
|
pass
|
|
return werkzeug.utils.redirect('/payment/process')
|