When using message_post, the body format must be explicitly specified. If html is expected, a Markup object should be used. If text is given, the content will be escaped. Before this PR: message_post was unaware if the content of a message was HTML or text. This lead to multiple situation where the content was incorrectly considered as HTML and led to display errors. In self.message_post(body="Hello %s!" % self.name) if the name contained HTML, it would be evaluated. In self.message_post(body="Contact Raoul <raoul@caramail.be>") the email would not be displayed as considered as unknown HTML and discarded by the sanitizer Now each call must explict the type of content. Use the escape() helper to properly combine Markup and translations. It would also be acceptable to use Markup() to wrap a static translation but escape is better as one can not guarantee the content of a translation. closes odoo/odoo#111850 Related: odoo/documentation#3612 Related: odoo/enterprise#36728 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
123 lines
5.2 KiB
Python
123 lines
5.2 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from markupsafe import Markup
|
|
|
|
from odoo import api, fields, models, _
|
|
from odoo.exceptions import ValidationError
|
|
|
|
|
|
class HrPlanWizard(models.TransientModel):
|
|
_name = 'hr.plan.wizard'
|
|
_description = 'Plan Wizard'
|
|
|
|
def _default_plan_id(self):
|
|
# We know that all employees belong to the same company
|
|
employee = self.env['hr.employee'].browse(self.env.context.get('active_ids')[0] if self.env.context.get('active_ids') else [])
|
|
return self.env['hr.plan'].search([
|
|
('company_id', '=', employee.company_id.id),
|
|
'|',
|
|
('department_id', '=', employee.department_id.id),
|
|
('department_id', '=', False)
|
|
], limit=1)
|
|
|
|
plan_id = fields.Many2one('hr.plan', default=lambda self: self._default_plan_id(),
|
|
domain="[('company_id', '=', company_id), '|', ('department_id', '=', department_id), ('department_id', '=', False)]")
|
|
department_id = fields.Many2one(related='employee_ids.department_id')
|
|
employee_ids = fields.Many2many(
|
|
'hr.employee', 'hr_employee_hr_plan_wizard_rel', 'employee_id', 'plan_wizard_id', string='Employee', required=True,
|
|
default=lambda self: self.env.context.get('active_ids', []),
|
|
)
|
|
company_id = fields.Many2one('res.company', 'Company', compute='_compute_company_id', required=True)
|
|
warning = fields.Html(compute='_compute_warning')
|
|
|
|
@api.constrains('employee_ids')
|
|
def _check_employee_companies(self):
|
|
for wizard in self:
|
|
if len(wizard.employee_ids.mapped('company_id')) > 1:
|
|
raise ValidationError(_('The employees should belong to the same company.'))
|
|
|
|
@api.depends('employee_ids')
|
|
def _compute_company_id(self):
|
|
for wizard in self:
|
|
wizard.company_id = wizard.employee_ids[0].company_id
|
|
|
|
def _get_warnings(self):
|
|
self.ensure_one()
|
|
warnings = set()
|
|
for employee in self.employee_ids:
|
|
for activity_type in self.plan_id.plan_activity_type_ids:
|
|
warning = activity_type.get_responsible_id(employee)['warning']
|
|
if warning:
|
|
warnings.add(warning)
|
|
return warnings
|
|
|
|
@api.depends('employee_ids', 'plan_id')
|
|
def _compute_warning(self):
|
|
for wizard in self:
|
|
warnings = wizard._get_warnings()
|
|
|
|
if warnings:
|
|
warning_display = _('The plan %s cannot be launched: <br><ul>', wizard.plan_id.name)
|
|
for warning in warnings:
|
|
warning_display += '<li>%s</li>' % warning
|
|
warning_display += '</ul>'
|
|
else:
|
|
warning_display = False
|
|
wizard.warning = warning_display
|
|
|
|
def _get_activities_to_schedule(self):
|
|
return self.plan_id.plan_activity_type_ids
|
|
|
|
def action_launch(self):
|
|
self.ensure_one()
|
|
for employee in self.employee_ids:
|
|
body = _('The plan %s has been started', self.plan_id.name)
|
|
activities = set()
|
|
for activity_type in self._get_activities_to_schedule():
|
|
responsible = activity_type.get_responsible_id(employee)['responsible']
|
|
record = employee
|
|
if not self.env['hr.employee'].with_user(responsible).check_access_rights('read', raise_exception=False):
|
|
record = self.env['hr.plan.employee.activity'].sudo().search([('employee_id', '=', employee.id)], limit=1)
|
|
if not record:
|
|
record = self.env['hr.plan.employee.activity'].sudo().create({
|
|
'employee_id': employee.id,
|
|
})
|
|
|
|
date_deadline = self.env['mail.activity']._calculate_date_deadline(activity_type.activity_type_id)
|
|
record.activity_schedule(
|
|
activity_type_id=activity_type.activity_type_id.id,
|
|
summary=activity_type.summary,
|
|
note=activity_type.note,
|
|
user_id=responsible.id,
|
|
date_deadline=date_deadline
|
|
)
|
|
activity = _('%(activity)s, assigned to %(name)s, due on the %(deadline)s', activity=activity_type.summary, name=responsible.name, deadline=date_deadline)
|
|
activities.add(activity)
|
|
|
|
if activities:
|
|
body += Markup('<ul>')
|
|
for activity in activities:
|
|
body += Markup('<li>%s</li>') % activity
|
|
body += Markup('</ul>')
|
|
employee.message_post(body=body)
|
|
|
|
if len(self.employee_ids) == 1:
|
|
return {
|
|
'type': 'ir.actions.act_window',
|
|
'res_model': 'hr.employee',
|
|
'res_id': self.employee_ids.id,
|
|
'name': self.employee_ids.display_name,
|
|
'view_mode': 'form',
|
|
'views': [(False, "form")],
|
|
}
|
|
|
|
return {
|
|
'type': 'ir.actions.act_window',
|
|
'res_model': 'hr.employee',
|
|
'name': _('Launch Plans'),
|
|
'view_mode': 'tree,form',
|
|
'target': 'current',
|
|
'domain': [('id', 'in', self.employee_ids.ids)],
|
|
}
|