Denis Ledoux
2dccc0d031
The cache key of _get_bindings was not super efficient.
The result of _get_bindings is cached,
but its performance was altered by the cache
key which requires to fetch the user groups for each call to
_get_bindings.
Besides, as there is a lot of possible group
combination, this resulted in a lot of possible cache keys,
and therefore a lot of cached values.
This revision aims to make _get_bindings more efficient
by:
- do not use the groups in the cache keys (less cached values)
- filter out actions not available to the user groups after
retrieving them from the cache
- use has_group to do the above, which is itself cached as well,
and therefore do not need to fetch the user groups
at each call to get_bindings.
In addition, move get_bindings from `get_view`
to `get_views`. If there was 3 views asked by `get_views`
(let's say kanban, list, form)
`get_bindings` was being called 3 times, through `get_view`
with each time the same arguments and therefore the same result :-).
Moving it to `get_views` allows to call it only once for all view types
requested, and for the web client it doesn't change much,
as it always request the toolbar/get_bindings through `get_views` only.
In addition, add the lang to the cache of _get_bindings.
it was actually a bug not to put it: if you had 2 users
with the same group set, using 2 different languages,
the user accessing first the get_bindings would cache
the action names within his language, and then the second
user would see the action name within the language of the first user
:-).
Before
```py
In [1]: %time for i in range(1000): self.env['ir.actions.actions'].get_bindings('res.partner'); self.env.invalidate_all();
CPU times: user 790 ms, sys: 104 ms, total: 893 ms
Wall time: 1.7 s
```
After
```py
In [1]: %time for i in range(1000): self.env['ir.actions.actions'].get_bindings('res.partner'); self.env.invalidate_all();
CPU times: user 23.5 ms, sys: 9.12 ms, total: 32.7 ms
Wall time: 36.9 ms
```
Part-of: odoo/odoo#99417
62 lines
2.1 KiB
Python
62 lines
2.1 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import api, fields, models
|
|
|
|
|
|
class Board(models.AbstractModel):
|
|
_name = 'board.board'
|
|
_description = "Board"
|
|
_auto = False
|
|
|
|
# This is necessary for when the web client opens a dashboard. Technically
|
|
# speaking, the dashboard is a form view, and opening it makes the client
|
|
# initialize a dummy record by invoking onchange(). And the latter requires
|
|
# an 'id' field to work properly...
|
|
id = fields.Id()
|
|
|
|
@api.model_create_multi
|
|
def create(self, vals_list):
|
|
return self
|
|
|
|
@api.model
|
|
def get_view(self, view_id=None, view_type='form', **options):
|
|
"""
|
|
Overrides orm field_view_get.
|
|
@return: Dictionary of Fields, arch and toolbar.
|
|
"""
|
|
|
|
res = super().get_view(view_id, view_type, **options)
|
|
|
|
custom_view = self.env['ir.ui.view.custom'].search([('user_id', '=', self.env.uid), ('ref_id', '=', view_id)], limit=1)
|
|
if custom_view:
|
|
res.update({'custom_view_id': custom_view.id,
|
|
'arch': custom_view.arch})
|
|
res['arch'] = self._arch_preprocessing(res['arch'])
|
|
return res
|
|
|
|
@api.model
|
|
def get_views(self, views, options=None):
|
|
res = super().get_views(views, options)
|
|
for view in res['views'].values():
|
|
view['toolbar'] = {'print': [], 'action': [], 'relate': []}
|
|
return res
|
|
|
|
@api.model
|
|
def _arch_preprocessing(self, arch):
|
|
from lxml import etree
|
|
|
|
def remove_unauthorized_children(node):
|
|
for child in node.iterchildren():
|
|
if child.tag == 'action' and child.get('invisible'):
|
|
node.remove(child)
|
|
else:
|
|
remove_unauthorized_children(child)
|
|
return node
|
|
|
|
archnode = etree.fromstring(arch)
|
|
# add the js_class 'board' on the fly to force the webclient to
|
|
# instantiate a BoardView instead of FormView
|
|
archnode.set('js_class', 'board')
|
|
return etree.tostring(remove_unauthorized_children(archnode), pretty_print=True, encoding='unicode')
|