Adrien Widart (awt)
f41c3b1d9e
Suppose a user who has CRM module and wants to import some leads thanks to this CSV file: ```csv name,recurring_plan Coca-Cola,Plan01 SAP,Plan02 ``` And, because the recurring plans are not yet created on his database, he enables the option "Create new values" for that field. An error will occur and here is the only info the user will have: > current transaction is aborted, commands ignored until end of > transaction block When importing, we convert the data encoded by the user ([1]). To do so, we convert the provided values, field by field ([2]). Since `recurring_plan` is a `many2one` field, we go (through `_str_to_many2one`) in `db_id_for`. In this method, we `name_search` the record and then, if it does not exist and if the feature is enabled, we `name_create` it ([3]). Back to the above use case. We start with the first line and there is not any recurring plan called "Plan01" so we try to create it. But here is the issue: we only have a name to create the record although there is another required field: `number_of_months`. Therefore, it leads to a `NotNullViolation` error. This error is caught (see [3]) and, later in the same method, we will raise a `ValueError`. This error will be caught by one of the except in [2]: we will save the error and will then continue with the convertion of next values. However, because of the `NotNullViolation`, the current SQL transaction is broken. As a result, while trying to convert the second line of the file, we will `name_search` "Plan02" and it will simply lead to a `InFailedSqlTransaction` [1] https://github.com/odoo/odoo/blob/f3d7fdce608f692ecb08498ee158edf9dfbced5e/odoo/models.py#L1170-L1182 [2] https://github.com/odoo/odoo/blob/b80d4294a000e748677a3a0c1849140bf46ddbe8/odoo/addons/base/models/ir_fields.py#L117-L118 [3] https://github.com/odoo/odoo/blob/b80d4294a000e748677a3a0c1849140bf46ddbe8/odoo/addons/base/models/ir_fields.py#L472-L475 sentry-3969379125 closes odoo/odoo#132897 X-original-commit: 28373b9d261a48154b233fbbd895880680b0aed0 Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
3.3 KiB
3.3 KiB
| 1 | id | name | model_id:id | group_id:id | perm_read | perm_write | perm_create | perm_unlink |
|---|---|---|---|---|---|---|---|---|
| 2 | access_export_boolean | access_export_boolean | model_export_boolean | base.group_user | 1 | 1 | 1 | 1 |
| 3 | access_export_integer | access_export_integer | model_export_integer | base.group_user | 1 | 1 | 1 | 1 |
| 4 | access_export_float | access_export_float | model_export_float | base.group_user | 1 | 1 | 1 | 1 |
| 5 | access_export_decimal | access_export_decimal | model_export_decimal | base.group_user | 1 | 1 | 1 | 1 |
| 6 | access_export_string_bounded | access_export_string_bounded | model_export_string_bounded | base.group_user | 1 | 1 | 1 | 1 |
| 7 | access_export_string_required | access_export_string_required | model_export_string_required | base.group_user | 1 | 1 | 1 | 1 |
| 8 | access_export_string | access_export_string | model_export_string | base.group_user | 1 | 1 | 1 | 1 |
| 9 | access_export_date | access_export_date | model_export_date | base.group_user | 1 | 1 | 1 | 1 |
| 10 | access_export_datetime | access_export_datetime | model_export_datetime | base.group_user | 1 | 1 | 1 | 1 |
| 11 | access_export_text | access_export_text | model_export_text | base.group_user | 1 | 1 | 1 | 1 |
| 12 | access_export_selection | access_export_selection | model_export_selection | base.group_user | 1 | 1 | 1 | 1 |
| 13 | access_export_selection_function | access_export_selection_function | model_export_selection_function | base.group_user | 1 | 1 | 1 | 1 |
| 14 | access_export_many2one | access_export_many2one | model_export_many2one | base.group_user | 1 | 1 | 1 | 1 |
| 15 | access_export_one2many | access_export_one2many | model_export_one2many | base.group_user | 1 | 1 | 1 | 1 |
| 16 | access_export_many2many | access_export_many2many | model_export_many2many | base.group_user | 1 | 1 | 1 | 1 |
| 17 | access_export_function | access_export_function | model_export_function | base.group_user | 1 | 1 | 1 | 1 |
| 18 | access_export_one2many_child | access_export_one2many_child | model_export_one2many_child | base.group_user | 1 | 1 | 1 | 1 |
| 19 | access_export_one2many_multiple | access_export_one2many_multiple | model_export_one2many_multiple | base.group_user | 1 | 1 | 1 | 1 |
| 20 | access_export_one2many_multiple_child | access_export_one2many_multiple_child | model_export_one2many_multiple_child | base.group_user | 1 | 1 | 1 | 1 |
| 21 | access_export_one2many_child_1 | access_export_one2many_child_1 | model_export_one2many_child_1 | base.group_user | 1 | 1 | 1 | 1 |
| 22 | access_export_one2many_child_2 | access_export_one2many_child_2 | model_export_one2many_child_2 | base.group_user | 1 | 1 | 1 | 1 |
| 23 | access_export_many2many_other | access_export_many2many_other | model_export_many2many_other | base.group_user | 1 | 1 | 1 | 1 |
| 24 | access_export_selection_withdefault | access_export_selection_withdefault | model_export_selection_withdefault | base.group_user | 1 | 1 | 1 | 1 |
| 25 | access_export_one2many_recursive | access_export_one2many_recursive | model_export_one2many_recursive | base.group_user | 1 | 1 | 1 | 1 |
| 26 | access_export_unique | access_export_unique | model_export_unique | base.group_user | 1 | 1 | 1 | 1 |
| 27 | access_export_inherits_parent | access_export_inherits_parent | model_export_inherits_parent | base.group_user | 1 | 1 | 1 | 1 |
| 28 | access_export_inherits_child | access_export_inherits_child | model_export_inherits_child | base.group_user | 1 | 1 | 1 | 1 |
| 29 | access_export_m2o_str | access_export_m2o_str | model_export_m2o_str | base.group_user | 1 | 1 | 1 | 1 |
| 30 | access_export_m2o_str_child | access_export_m2o_str_child | model_export_m2o_str_child | base.group_user | 1 | 1 | 1 | 1 |
| 31 | access_export_with_required_field | access_export_with_required_field | model_export_with_required_field | base.group_user | 1 | 1 | 1 | 1 |
| 32 | access_export_many2one_required_subfield | access_export_many2one_required_subfield | model_export_many2one_required_subfield | base.group_user | 1 | 1 | 1 | 1 |