nie
23233a7051
Steps: - Install accounting - On the dashboard, try to upload an "encrypted" PDF like this one https://launchpadlibrarian.net/24827090/DS-0157.pdf Bug: Traceback: PyPDF2.utils.PdfReadError: file has not been decrypted Explanation: In 13.0, these errors were caught in a catch all `except` as shown here: https://github.com/odoo/odoo/blob/4e089041252c25cc197a30f9e285d82f7162d809/addons/account_facturx/models/account_move.py#L303-L328 From this SO comment: https://stackoverflow.com/questions/52047944/pdfbox-extracting-blanks-from-pdf-encrypted-with-no-password#comment91054285_52047944 > A PDF can be encrypted with two passwords: a user password and an owner password. When a PDF is encrypted with a user password, you can't open the document in a PDF viewer without entering that password. When a PDF is encrypted with an owner password only, everyone can open a PDF without that password, but some restrictions may be in place. From time to time, we get a PDF encrypted with an owner password. The content is still readable, but PyPDF2 fails because it thinks the PDF is encrypted. With this fix, we try to unwrap the PDF by providing an empty user password. This way, PyPDF2 thinks the content is now decrypted. However, PyPDF2 only supports decrypting versions 1 and 2 of the encryption implementation. If the version is different, we skip reading the attachments and carry on to allow the user to upload the document. opw:2375993 closes odoo/odoo#64320 X-original-commit: 851fe64f7789bb398383c22e3ebbaebb051791f6 Signed-off-by: backspac <backspac@users.noreply.github.com> Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
95 lines
3.7 KiB
Python
95 lines
3.7 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.tests.common import TransactionCase
|
|
from odoo.tools import pdf
|
|
from odoo.modules.module import get_module_resource
|
|
import io
|
|
|
|
|
|
class TestPdf(TransactionCase):
|
|
""" Tests on pdf. """
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
file_path = get_module_resource('base', 'tests', 'minimal.pdf')
|
|
self.file = open(file_path, 'rb').read()
|
|
self.minimal_reader_buffer = io.BytesIO(self.file)
|
|
self.minimal_pdf_reader = pdf.OdooPdfFileReader(self.minimal_reader_buffer)
|
|
|
|
def test_odoo_pdf_file_reader(self):
|
|
attachments = list(self.minimal_pdf_reader.getAttachments())
|
|
self.assertEqual(len(attachments), 0)
|
|
|
|
pdf_writer = pdf.PdfFileWriter()
|
|
pdf_writer.cloneReaderDocumentRoot(self.minimal_pdf_reader)
|
|
pdf_writer.addAttachment('test_attachment.txt', b'My awesome attachment')
|
|
|
|
attachments = list(self.minimal_pdf_reader.getAttachments())
|
|
self.assertEqual(len(attachments), 1)
|
|
|
|
def test_odoo_pdf_file_writer(self):
|
|
attachments = list(self.minimal_pdf_reader.getAttachments())
|
|
self.assertEqual(len(attachments), 0)
|
|
|
|
pdf_writer = pdf.OdooPdfFileWriter()
|
|
pdf_writer.cloneReaderDocumentRoot(self.minimal_pdf_reader)
|
|
|
|
pdf_writer.addAttachment('test_attachment.txt', b'My awesome attachment')
|
|
attachments = list(self.minimal_pdf_reader.getAttachments())
|
|
self.assertEqual(len(attachments), 1)
|
|
|
|
pdf_writer.addAttachment('another_attachment.txt', b'My awesome OTHER attachment')
|
|
attachments = list(self.minimal_pdf_reader.getAttachments())
|
|
self.assertEqual(len(attachments), 2)
|
|
|
|
def test_odoo_pdf_file_reader_with_owner_encryption(self):
|
|
pdf_writer = pdf.OdooPdfFileWriter()
|
|
pdf_writer.cloneReaderDocumentRoot(self.minimal_pdf_reader)
|
|
|
|
pdf_writer.addAttachment('test_attachment.txt', b'My awesome attachment')
|
|
pdf_writer.addAttachment('another_attachment.txt', b'My awesome OTHER attachment')
|
|
|
|
pdf_writer.encrypt("", "foo")
|
|
|
|
with io.BytesIO() as writer_buffer:
|
|
pdf_writer.write(writer_buffer)
|
|
encrypted_content = writer_buffer.getvalue()
|
|
|
|
with io.BytesIO(encrypted_content) as reader_buffer:
|
|
pdf_reader = pdf.OdooPdfFileReader(reader_buffer)
|
|
attachments = list(pdf_reader.getAttachments())
|
|
|
|
self.assertEqual(len(attachments), 2)
|
|
|
|
def test_merge_pdf(self):
|
|
self.assertEqual(self.minimal_pdf_reader.getNumPages(), 1)
|
|
page = self.minimal_pdf_reader.getPage(0)
|
|
|
|
merged_pdf = pdf.merge_pdf([self.file, self.file])
|
|
merged_reader_buffer = io.BytesIO(merged_pdf)
|
|
merged_pdf_reader = pdf.OdooPdfFileReader(merged_reader_buffer)
|
|
self.assertEqual(merged_pdf_reader.getNumPages(), 2)
|
|
merged_reader_buffer.close()
|
|
|
|
def test_branded_file_writer(self):
|
|
# It's not easy to create a PDF with PyPDF2, so instead we copy minimal.pdf with our custom pdf writer
|
|
pdf_writer = pdf.PdfFileWriter() # BrandedFileWriter
|
|
pdf_writer.cloneReaderDocumentRoot(self.minimal_pdf_reader)
|
|
writer_buffer = io.BytesIO()
|
|
pdf_writer.write(writer_buffer)
|
|
branded_content = writer_buffer.getvalue()
|
|
writer_buffer.close()
|
|
|
|
# Read the metadata of the newly created pdf.
|
|
reader_buffer = io.BytesIO(branded_content)
|
|
pdf_reader = pdf.PdfFileReader(reader_buffer)
|
|
pdf_info = pdf_reader.getDocumentInfo()
|
|
self.assertEqual(pdf_info['/Producer'], 'Odoo')
|
|
self.assertEqual(pdf_info['/Creator'], 'Odoo')
|
|
reader_buffer.close()
|
|
|
|
def tearDown(self):
|
|
super().tearDown()
|
|
self.minimal_reader_buffer.close()
|