Martin TrigauxandRaphael Collet
8f88570ca1
Context: After a module update, the records present in ir_model_data table but not in self.pool.loaded_xmlids are considered as no longer needed and should be removed. An exception is done with noupdate=true entries. Bug 1: Entries with noupdate=NULL are not considered in the evaluation and are ignored while it may be worth deleting. Bug 2: Some records with their external id being automatically created are not present in self.pool.loaded_xmlids and may get removed after updating a module. By a lucky coincidence, bug 1 make it so that records targeted by bug 2 are ignored and not deleted (the "automagically" created ir.model.data often lack a noupdate value). Fix Bug 1: Use a COALESCE to find both records with noupdate=NULL and noupdate=false Fix Bug 2: Depends on the source of the generated external id: - ir.model: The entries created through _reflect_model were not loaded in self.loaded_xmlids Use the proper ORM method _update_xmlids that correctly populates self.pool.loaded_xmlids - ir.model.category: The categories were generated when the db was initalised, doing SQL was not avoidable. Create the categories in noupdate to avoid it being considered for removal. - ir.property: Are always created in noupdate in data files but in stock_account it was manually created without being in noupdate closes odoo/odoo#32881 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com> Co-authored-by: Raphael Collet <rco@odoo.com>
95 lines
4.0 KiB
Python
95 lines
4.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from . import models
|
|
from . import wizard
|
|
|
|
from odoo import api, SUPERUSER_ID, _, tools
|
|
|
|
def _configure_journals(cr, registry):
|
|
"""Setting journal and property field (if needed)"""
|
|
|
|
env = api.Environment(cr, SUPERUSER_ID, {})
|
|
|
|
# if we already have a coa installed, create journal and set property field
|
|
company_ids = env['res.company'].search([('chart_template_id', '!=', False)])
|
|
|
|
for company_id in company_ids:
|
|
# Check if property exists for stock account journal exists
|
|
properties = env['ir.property'].search([
|
|
('name', '=', 'property_stock_journal'),
|
|
('company_id', '=', company_id.id)])
|
|
|
|
# If not, check if you can find a journal that is already there with the same name, otherwise create one
|
|
if not properties:
|
|
journal_id = env['account.journal'].search([
|
|
('name', '=', _('Inventory Valuation')),
|
|
('company_id', '=', company_id.id),
|
|
('type', '=', 'general')], limit=1).id
|
|
if not journal_id:
|
|
journal_id = env['account.journal'].create({
|
|
'name': _('Inventory Valuation'),
|
|
'type': 'general',
|
|
'code': 'STJ',
|
|
'company_id': company_id.id,
|
|
'show_on_dashboard': False
|
|
}).id
|
|
vals = {
|
|
'name': 'property_stock_journal',
|
|
'fields_id': env['ir.model.fields'].search([
|
|
('name', '=', 'property_stock_journal'),
|
|
('model', '=', 'product.category'),
|
|
('relation', '=', 'account.journal')], limit=1).id,
|
|
'company_id': company_id.id,
|
|
'value': 'account.journal,' + str(journal_id)
|
|
}
|
|
env['ir.property'].create(vals)
|
|
|
|
# Property Stock Accounts
|
|
todo_list = [
|
|
'property_stock_account_input_categ_id',
|
|
'property_stock_account_output_categ_id',
|
|
'property_stock_valuation_account_id',
|
|
]
|
|
|
|
for record in todo_list:
|
|
account = getattr(company_id, record)
|
|
value = account and 'account.account,' + str(account.id) or False
|
|
if value:
|
|
field_id = env['ir.model.fields'].search([
|
|
('name', '=', record),
|
|
('model', '=', 'product.category'),
|
|
('relation', '=', 'account.account')
|
|
], limit=1).id
|
|
vals = {
|
|
'name': record,
|
|
'company_id': company_id.id,
|
|
'fields_id': field_id,
|
|
'value': value,
|
|
}
|
|
properties = env['ir.property'].search([
|
|
('name', '=', record),
|
|
('company_id', '=', company_id.id),
|
|
])
|
|
if properties:
|
|
properties.write(vals)
|
|
else:
|
|
# create the property
|
|
env['ir.property'].create(vals)
|
|
|
|
stock_account = env.ref('account.demo_stock_account', False)
|
|
if stock_account:
|
|
account_id = env['account.account'].search([('tag_ids', '=', stock_account.id)], limit=1).id
|
|
fields_id = env['ir.model.fields'].search([('model', '=', 'product.category'), ('name', '=', 'property_stock_valuation_account_id')], limit=1).id
|
|
if not account_id:
|
|
account_id = env['account.account'].search([('user_type_id', '=', env.ref('account.data_account_type_current_assets').id)], limit=1).id
|
|
if account_id:
|
|
xml_id = 'stock_account.property_stock_valuation_account_id'
|
|
vals = {
|
|
'name': 'property_stock_valuation_account_id',
|
|
'fields_id': fields_id,
|
|
'value': 'account.account,'+str(account_id),
|
|
'company_id': env.ref('base.main_company').id,
|
|
}
|
|
env['ir.property']._load_records([dict(xml_id=xml_id, values=vals, noupdate=True)])
|