There are bytecode operations we don't support because we've never
needed them, and there are bytecode operations we don't support
because they're vectors of security issues.
Currently no difference is being made between the two, so when looking
to add a new opcodes it's hard to know whether it's been considered
and rejected or whether it just hasn't been considered (or found
useful) yet.
Add an explicit blacklist, which is explicitly subtracted to all
opcodes lists, to allow motivating the bans of certain
opcodes. Opcodes listed in no lists are the "graylists" of opcodes we
either haven't yet considered or have not had a use for.
Also cleanup the existing lists of opcodes to remove long-gone (or
even never-existing) opcodes, and add a few missing opcodes:
* DUP_TOPX was removed from Python 3, replaced by DUP_TOP_TWO
* STORE_MAP was removed in Python 3.5
* BINARY_DIVIDE and INPLACE_DIVIDE were removed from Python 3 (they
were used to invoke P2's integer division)
* the SLICE+<X> were removed from Python 3, which only uses
BUILD_SLICE
* CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW were removed in Python
3.6 and functionally replaced by CALL_FUNCTION_EX (bpo-27213)
* JUMP_IF_FALSE and JUMP_IF_TRUE were removed back in 2.7, replaced by
POP_JUMP_* and JUMP_*_OR_POP (bpo-4715)
* various finally-related bytecode instructions were added to Python
3.8 to improve and speed up the handling of return, break and
continue (bpo-17611).
* INPLACE_REMAINDER, INPLACE_LEFTSHIFT and INPLACE_RIGHTSHIFT were
mentioned in PEP 202 but never actually implemented: INPLACE_
instructions were intended to mirror the BINARY_ instructions, these
mnemonics didn't match the BINARY_ ones, so the actual mnemonics are
INPLACE_MODULO, INPLACE_LSHIFT and INPLACE_RSHIFT
* while at it, BINARY_ and INPLACE_ mnemonics: as noted above they're
mirrors of one another with different prefixes (except for SUBSCR
which doesn't have an INPLACE version), we only supported a fraction
of the INPLACE codes for unknown reason.
Initially looked at simply aligning the BINARY and INPLACE mnemonics
e.g.
'BINARY_POWER', 'BINARY_MULTIPLY', 'BINARY_FLOOR_DIVIDE',
'INPLACE_POWER', 'INPLACE_MULTIPLY', 'INPLACE_FLOOR_DIVIDE',
...
so it would be easier to notice discrepancies, but it seems simpler
and clearer to just move the suffixes to a single list and generate
the BINARY_ and INPLACE_ mnemonics from that
* moved STORE_SUBSCR from EXPR to SAFE, I don't see how `foo[...] = 3`
could be in an expression
* remove pseudo-graylist `_POSSIBLE_OPCODES_P3`, was intended as a
list of new P3 opcodes we might want to add, but the purpose was
hard to understand and a proper blacklist makes way more sense
closes odoo/odoo#41085
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
353 lines
12 KiB
Python
353 lines
12 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
"""
|
|
safe_eval module - methods intended to provide more restricted alternatives to
|
|
evaluate simple and/or untrusted code.
|
|
|
|
Methods in this module are typically used as alternatives to eval() to parse
|
|
OpenERP domain strings, conditions and expressions, mostly based on locals
|
|
condition/math builtins.
|
|
"""
|
|
|
|
# Module partially ripped from/inspired by several different sources:
|
|
# - http://code.activestate.com/recipes/286134/
|
|
# - safe_eval in lp:~xrg/openobject-server/optimize-5.0
|
|
# - safe_eval in tryton http://hg.tryton.org/hgwebdir.cgi/trytond/rev/bbb5f73319ad
|
|
import dis
|
|
from opcode import HAVE_ARGUMENT, opmap, opname
|
|
|
|
import functools
|
|
from psycopg2 import OperationalError
|
|
from types import CodeType
|
|
import logging
|
|
import werkzeug
|
|
|
|
from .misc import ustr
|
|
|
|
import odoo
|
|
|
|
unsafe_eval = eval
|
|
|
|
__all__ = ['test_expr', 'safe_eval', 'const_eval']
|
|
|
|
# The time module is usually already provided in the safe_eval environment
|
|
# but some code, e.g. datetime.datetime.now() (Windows/Python 2.5.2, bug
|
|
# lp:703841), does import time.
|
|
_ALLOWED_MODULES = ['_strptime', 'math', 'time']
|
|
|
|
_UNSAFE_ATTRIBUTES = ['f_builtins', 'f_globals', 'f_locals', 'gi_frame',
|
|
'co_code', 'func_globals']
|
|
|
|
def to_opcodes(opnames, _opmap=opmap):
|
|
for x in opnames:
|
|
if x in _opmap:
|
|
yield _opmap[x]
|
|
# opcodes which absolutely positively must not be usable in safe_eval,
|
|
# explicitly subtracted from all sets of valid opcodes just in case
|
|
_BLACKLIST = set(to_opcodes([
|
|
# can't provide access to accessing arbitrary modules
|
|
'IMPORT_STAR', 'IMPORT_NAME', 'IMPORT_FROM',
|
|
# could allow replacing or updating core attributes on models & al, setitem
|
|
# can be used to set field values
|
|
'STORE_ATTR', 'DELETE_ATTR',
|
|
# no reason to allow this
|
|
'STORE_GLOBAL', 'DELETE_GLOBAL',
|
|
]))
|
|
# opcodes necessary to build literal values
|
|
_CONST_OPCODES = set(to_opcodes([
|
|
# stack manipulations
|
|
'POP_TOP', 'ROT_TWO', 'ROT_THREE', 'ROT_FOUR', 'DUP_TOP', 'DUP_TOP_TWO',
|
|
'LOAD_CONST',
|
|
'RETURN_VALUE', # return the result of the literal/expr evaluation
|
|
# literal collections
|
|
'BUILD_LIST', 'BUILD_MAP', 'BUILD_TUPLE', 'BUILD_SET',
|
|
# 3.6: literal map with constant keys https://bugs.python.org/issue27140
|
|
'BUILD_CONST_KEY_MAP',
|
|
])) - _BLACKLIST
|
|
|
|
# operations which are both binary and inplace, same order as in doc'
|
|
_operations = [
|
|
'POWER', 'MULTIPLY', # 'MATRIX_MULTIPLY', # matrix operator (3.5+)
|
|
'FLOOR_DIVIDE', 'TRUE_DIVIDE', 'MODULO', 'ADD',
|
|
'SUBTRACT', 'LSHIFT', 'RSHIFT', 'AND', 'XOR', 'OR',
|
|
]
|
|
# operations on literal values
|
|
_EXPR_OPCODES = _CONST_OPCODES.union(to_opcodes([
|
|
'UNARY_POSITIVE', 'UNARY_NEGATIVE', 'UNARY_NOT', 'UNARY_INVERT',
|
|
*('BINARY_' + op for op in _operations), 'BINARY_SUBSCR',
|
|
*('INPLACE_' + op for op in _operations),
|
|
'BUILD_SLICE',
|
|
# comprehensions
|
|
'LIST_APPEND', 'MAP_ADD', 'SET_ADD',
|
|
'COMPARE_OP',
|
|
])) - _BLACKLIST
|
|
|
|
_SAFE_OPCODES = _EXPR_OPCODES.union(to_opcodes([
|
|
'POP_BLOCK', 'POP_EXCEPT',
|
|
|
|
# note: removed in 3.8
|
|
'SETUP_LOOP', 'SETUP_EXCEPT', 'BREAK_LOOP', 'CONTINUE_LOOP',
|
|
|
|
'EXTENDED_ARG', # P3.6 for long jump offsets.
|
|
'MAKE_FUNCTION', 'CALL_FUNCTION', 'CALL_FUNCTION_KW', 'CALL_FUNCTION_EX',
|
|
# Added in P3.7 https://bugs.python.org/issue26110
|
|
'CALL_METHOD', 'LOAD_METHOD',
|
|
|
|
'GET_ITER', 'FOR_ITER', 'YIELD_VALUE',
|
|
'JUMP_FORWARD', 'JUMP_ABSOLUTE',
|
|
'JUMP_IF_FALSE_OR_POP', 'JUMP_IF_TRUE_OR_POP', 'POP_JUMP_IF_FALSE', 'POP_JUMP_IF_TRUE',
|
|
'SETUP_FINALLY', 'END_FINALLY',
|
|
# Added in 3.8 https://bugs.python.org/issue17611
|
|
'BEGIN_FINALLY', 'CALL_FINALLY', 'POP_FINALLY',
|
|
|
|
'RAISE_VARARGS', 'LOAD_NAME', 'STORE_NAME', 'DELETE_NAME', 'LOAD_ATTR',
|
|
'LOAD_FAST', 'STORE_FAST', 'DELETE_FAST', 'UNPACK_SEQUENCE',
|
|
'STORE_SUBSCR',
|
|
'LOAD_GLOBAL',
|
|
])) - _BLACKLIST
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
def assert_no_dunder_name(code_obj, expr):
|
|
""" assert_no_dunder_name(code_obj, expr) -> None
|
|
|
|
Asserts that the code object does not refer to any "dunder name"
|
|
(__$name__), so that safe_eval prevents access to any internal-ish Python
|
|
attribute or method (both are loaded via LOAD_ATTR which uses a name, not a
|
|
const or a var).
|
|
|
|
Checks that no such name exists in the provided code object (co_names).
|
|
|
|
:param code_obj: code object to name-validate
|
|
:type code_obj: CodeType
|
|
:param str expr: expression corresponding to the code object, for debugging
|
|
purposes
|
|
:raises NameError: in case a forbidden name (containing two underscores)
|
|
is found in ``code_obj``
|
|
|
|
.. note:: actually forbids every name containing 2 underscores
|
|
"""
|
|
for name in code_obj.co_names:
|
|
if "__" in name or name in _UNSAFE_ATTRIBUTES:
|
|
raise NameError('Access to forbidden name %r (%r)' % (name, expr))
|
|
|
|
def assert_valid_codeobj(allowed_codes, code_obj, expr):
|
|
""" Asserts that the provided code object validates against the bytecode
|
|
and name constraints.
|
|
|
|
Recursively validates the code objects stored in its co_consts in case
|
|
lambdas are being created/used (lambdas generate their own separated code
|
|
objects and don't live in the root one)
|
|
|
|
:param allowed_codes: list of permissible bytecode instructions
|
|
:type allowed_codes: set(int)
|
|
:param code_obj: code object to name-validate
|
|
:type code_obj: CodeType
|
|
:param str expr: expression corresponding to the code object, for debugging
|
|
purposes
|
|
:raises ValueError: in case of forbidden bytecode in ``code_obj``
|
|
:raises NameError: in case a forbidden name (containing two underscores)
|
|
is found in ``code_obj``
|
|
"""
|
|
assert_no_dunder_name(code_obj, expr)
|
|
|
|
# set operations are almost twice as fast as a manual iteration + condition
|
|
# when loading /web according to line_profiler
|
|
code_codes = {i.opcode for i in dis.get_instructions(code_obj)}
|
|
if not allowed_codes >= code_codes:
|
|
raise ValueError("forbidden opcode(s) in %r: %s" % (expr, ', '.join(opname[x] for x in (code_codes - allowed_codes))))
|
|
|
|
for const in code_obj.co_consts:
|
|
if isinstance(const, CodeType):
|
|
assert_valid_codeobj(allowed_codes, const, 'lambda')
|
|
|
|
def test_expr(expr, allowed_codes, mode="eval"):
|
|
"""test_expr(expression, allowed_codes[, mode]) -> code_object
|
|
|
|
Test that the expression contains only the allowed opcodes.
|
|
If the expression is valid and contains only allowed codes,
|
|
return the compiled code object.
|
|
Otherwise raise a ValueError, a Syntax Error or TypeError accordingly.
|
|
"""
|
|
try:
|
|
if mode == 'eval':
|
|
# eval() does not like leading/trailing whitespace
|
|
expr = expr.strip()
|
|
code_obj = compile(expr, "", mode)
|
|
except (SyntaxError, TypeError, ValueError):
|
|
raise
|
|
except Exception as e:
|
|
raise ValueError('"%s" while compiling\n%r' % (ustr(e), expr))
|
|
assert_valid_codeobj(allowed_codes, code_obj, expr)
|
|
return code_obj
|
|
|
|
|
|
def const_eval(expr):
|
|
"""const_eval(expression) -> value
|
|
|
|
Safe Python constant evaluation
|
|
|
|
Evaluates a string that contains an expression describing
|
|
a Python constant. Strings that are not valid Python expressions
|
|
or that contain other code besides the constant raise ValueError.
|
|
|
|
>>> const_eval("10")
|
|
10
|
|
>>> const_eval("[1,2, (3,4), {'foo':'bar'}]")
|
|
[1, 2, (3, 4), {'foo': 'bar'}]
|
|
>>> const_eval("1+2")
|
|
Traceback (most recent call last):
|
|
...
|
|
ValueError: opcode BINARY_ADD not allowed
|
|
"""
|
|
c = test_expr(expr, _CONST_OPCODES)
|
|
return unsafe_eval(c)
|
|
|
|
def expr_eval(expr):
|
|
"""expr_eval(expression) -> value
|
|
|
|
Restricted Python expression evaluation
|
|
|
|
Evaluates a string that contains an expression that only
|
|
uses Python constants. This can be used to e.g. evaluate
|
|
a numerical expression from an untrusted source.
|
|
|
|
>>> expr_eval("1+2")
|
|
3
|
|
>>> expr_eval("[1,2]*2")
|
|
[1, 2, 1, 2]
|
|
>>> expr_eval("__import__('sys').modules")
|
|
Traceback (most recent call last):
|
|
...
|
|
ValueError: opcode LOAD_NAME not allowed
|
|
"""
|
|
c = test_expr(expr, _EXPR_OPCODES)
|
|
return unsafe_eval(c)
|
|
|
|
def _import(name, globals=None, locals=None, fromlist=None, level=-1):
|
|
if globals is None:
|
|
globals = {}
|
|
if locals is None:
|
|
locals = {}
|
|
if fromlist is None:
|
|
fromlist = []
|
|
if name in _ALLOWED_MODULES:
|
|
return __import__(name, globals, locals, level)
|
|
raise ImportError(name)
|
|
_BUILTINS = {
|
|
'__import__': _import,
|
|
'True': True,
|
|
'False': False,
|
|
'None': None,
|
|
'bytes': bytes,
|
|
'str': str,
|
|
'unicode': str,
|
|
'bool': bool,
|
|
'int': int,
|
|
'float': float,
|
|
'enumerate': enumerate,
|
|
'dict': dict,
|
|
'list': list,
|
|
'tuple': tuple,
|
|
'map': map,
|
|
'abs': abs,
|
|
'min': min,
|
|
'max': max,
|
|
'sum': sum,
|
|
'reduce': functools.reduce,
|
|
'filter': filter,
|
|
'round': round,
|
|
'len': len,
|
|
'repr': repr,
|
|
'set': set,
|
|
'all': all,
|
|
'any': any,
|
|
'ord': ord,
|
|
'chr': chr,
|
|
'divmod': divmod,
|
|
'isinstance': isinstance,
|
|
'range': range,
|
|
'xrange': range,
|
|
'zip': zip,
|
|
'Exception': Exception,
|
|
}
|
|
def safe_eval(expr, globals_dict=None, locals_dict=None, mode="eval", nocopy=False, locals_builtins=False):
|
|
"""safe_eval(expression[, globals[, locals[, mode[, nocopy]]]]) -> result
|
|
|
|
System-restricted Python expression evaluation
|
|
|
|
Evaluates a string that contains an expression that mostly
|
|
uses Python constants, arithmetic expressions and the
|
|
objects directly provided in context.
|
|
|
|
This can be used to e.g. evaluate
|
|
an OpenERP domain expression from an untrusted source.
|
|
|
|
:throws TypeError: If the expression provided is a code object
|
|
:throws SyntaxError: If the expression provided is not valid Python
|
|
:throws NameError: If the expression provided accesses forbidden names
|
|
:throws ValueError: If the expression provided uses forbidden bytecode
|
|
"""
|
|
if type(expr) is CodeType:
|
|
raise TypeError("safe_eval does not allow direct evaluation of code objects.")
|
|
|
|
# prevent altering the globals/locals from within the sandbox
|
|
# by taking a copy.
|
|
if not nocopy:
|
|
# isinstance() does not work below, we want *exactly* the dict class
|
|
if (globals_dict is not None and type(globals_dict) is not dict) \
|
|
or (locals_dict is not None and type(locals_dict) is not dict):
|
|
_logger.warning(
|
|
"Looks like you are trying to pass a dynamic environment, "
|
|
"you should probably pass nocopy=True to safe_eval().")
|
|
if globals_dict is not None:
|
|
globals_dict = dict(globals_dict)
|
|
if locals_dict is not None:
|
|
locals_dict = dict(locals_dict)
|
|
|
|
if globals_dict is None:
|
|
globals_dict = {}
|
|
|
|
globals_dict['__builtins__'] = _BUILTINS
|
|
if locals_builtins:
|
|
if locals_dict is None:
|
|
locals_dict = {}
|
|
locals_dict.update(_BUILTINS)
|
|
c = test_expr(expr, _SAFE_OPCODES, mode=mode)
|
|
try:
|
|
return unsafe_eval(c, globals_dict, locals_dict)
|
|
except odoo.exceptions.UserError:
|
|
raise
|
|
except odoo.exceptions.RedirectWarning:
|
|
raise
|
|
except werkzeug.exceptions.HTTPException:
|
|
raise
|
|
except odoo.http.AuthenticationError:
|
|
raise
|
|
except OperationalError:
|
|
# Do not hide PostgreSQL low-level exceptions, to let the auto-replay
|
|
# of serialized transactions work its magic
|
|
raise
|
|
except ZeroDivisionError:
|
|
raise
|
|
except Exception as e:
|
|
raise ValueError('%s: "%s" while evaluating\n%r' % (ustr(type(e)), ustr(e), expr))
|
|
def test_python_expr(expr, mode="eval"):
|
|
try:
|
|
test_expr(expr, _SAFE_OPCODES, mode=mode)
|
|
except (SyntaxError, TypeError, ValueError) as err:
|
|
if len(err.args) >= 2 and len(err.args[1]) >= 4:
|
|
error = {
|
|
'message': err.args[0],
|
|
'filename': err.args[1][0],
|
|
'lineno': err.args[1][1],
|
|
'offset': err.args[1][2],
|
|
'error_line': err.args[1][3],
|
|
}
|
|
msg = "%s : %s at line %d\n%s" % (type(err).__name__, error['message'], error['lineno'], error['error_line'])
|
|
else:
|
|
msg = ustr(err)
|
|
return msg
|
|
return False
|