Alvaro FuentesandChristophe Simonis
c18b9f44be
When we use the `|` (or) version of this rule the ORM generates two
sub-queries when checking the company. This causes sub-optimal and in
some cases really bad planning for the queries and thus PG takes hours
to complete them.
Example (formatted):
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE ("mrp_bom"."company_id" in (1))
)
)
OR ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE "mrp_bom"."company_id" IS NULL
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
If we use the single term version the generated query has only one
sub-query:
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE (("mrp_bom"."company_id" in (1))
OR ("mrp_bom"."company_id" IS NULL))
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
In this version PG is able to produce a better query plan resulting in
better execution times.
Also, the `company_id` field is required on some models, so the "= False" comparison is useless.
closes odoo/odoo#159123
X-original-commit: 1b5c41f36801fb886ec591f29dba42787d698526
Related: odoo/enterprise#59378
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
Co-authored-by: Christophe Simonis <chs@odoo.com>
99 lines
5.1 KiB
XML
99 lines
5.1 KiB
XML
<?xml version="1.0" ?>
|
|
<odoo>
|
|
<record model="ir.module.category" id="module_lunch_category">
|
|
<field name="name">Lunch</field>
|
|
<field name="description">Helps you handle your lunch needs, if you are a manager you will be able to create new products, cashmoves and to confirm or cancel orders.</field>
|
|
<field name="sequence">16</field>
|
|
</record>
|
|
<record id="group_lunch_user" model="res.groups">
|
|
<field name="name">User : Order your meal</field>
|
|
<field name="category_id" ref="base.module_category_human_resources_lunch"/>
|
|
</record>
|
|
<record id="group_lunch_manager" model="res.groups">
|
|
<field name="name">Administrator</field>
|
|
<field name="implied_ids" eval="[(4, ref('group_lunch_user'))]"/>
|
|
<field name="category_id" ref="base.module_category_human_resources_lunch"/>
|
|
<field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>
|
|
</record>
|
|
|
|
<data noupdate="1">
|
|
|
|
<record id="lunch_mind_your_own_food_money" model="ir.rule">
|
|
<field name="name">lunch.cashmove: do not see other people's cashmove</field>
|
|
<field name="model_id" ref="model_lunch_cashmove"/>
|
|
<field name="groups" eval="[(4, ref('group_lunch_user'))]"/>
|
|
<field name="domain_force">[('user_id', '=', user.id)]</field>
|
|
</record>
|
|
<record id="lunch_mind_other_food_money" model="ir.rule">
|
|
<field name="name">lunch.cashmove: do see other people's cashmove</field>
|
|
<field name="model_id" ref="model_lunch_cashmove"/>
|
|
<field name="groups" eval="[(4, ref('group_lunch_manager'))]"/>
|
|
<field name="domain_force">[(1, '=', 1)]</field>
|
|
</record>
|
|
<record id="lunch_order_rule_delete" model="ir.rule">
|
|
<field name="name">lunch.order: Only new and cancelled order lines deleted.</field>
|
|
<field name="model_id" ref="lunch.model_lunch_order"/>
|
|
<field name="domain_force">[('state', 'in', ('new', 'cancelled'))]</field>
|
|
<field name="perm_read" eval="0"/>
|
|
<field name="perm_write" eval="0"/>
|
|
<field name="perm_create" eval="0"/>
|
|
<field name="perm_unlink" eval="1" />
|
|
<field name="groups" eval="[(4,ref('lunch.group_lunch_user'))]"/>
|
|
</record>
|
|
|
|
<record id="lunch_order_rule_write" model="ir.rule">
|
|
<field name="name">lunch.order: Don't change confirmed order</field>
|
|
<field name="model_id" ref="lunch.model_lunch_order"/>
|
|
<field name="domain_force">[('state', '!=', 'confirmed'), ('user_id', '=', user.id)]</field>
|
|
<field name="perm_read" eval="0"/>
|
|
<field name="perm_create" eval="0"/>
|
|
<field name="perm_unlink" eval="0"/>
|
|
<field name="groups" eval="[(4, ref('base.group_user'))]"/>
|
|
</record>
|
|
|
|
<record id="lunch_order_rule_write_manager" model="ir.rule">
|
|
<field name="name">manager can do whatever</field>
|
|
<field name="model_id" ref="lunch.model_lunch_order"/>
|
|
<field name="domain_force">[(1, '=', 1)]</field>
|
|
<field name="perm_read" eval="0"/>
|
|
<field name="perm_create" eval="0"/>
|
|
<field name="perm_unlink" eval="0"/>
|
|
<field name="groups" eval="[(4, ref('lunch.group_lunch_manager'))]"/>
|
|
</record>
|
|
|
|
<record id="base.default_user" model="res.users">
|
|
<field name="groups_id" eval="[(4,ref('lunch.group_lunch_manager'))]"/>
|
|
</record>
|
|
|
|
<record id="ir_rule_lunch_supplier_multi_company" model="ir.rule">
|
|
<field name="name">Lunch supplier: Multi Company</field>
|
|
<field name="model_id" ref="model_lunch_supplier"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="ir_rule_lunch_order_multi_company" model="ir.rule">
|
|
<field name="name">Lunch order: Multi Company</field>
|
|
<field name="model_id" ref="model_lunch_order"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="ir_rule_lunch_product_multi_company" model="ir.rule">
|
|
<field name="name">Lunch product: Multi Company</field>
|
|
<field name="model_id" ref="model_lunch_product"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="ir_rule_lunch_product_category_multi_company" model="ir.rule">
|
|
<field name="name">Lunch product category: Multi Company</field>
|
|
<field name="model_id" ref="model_lunch_product_category"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="ir_rule_lunch_location_multi_company" model="ir.rule">
|
|
<field name="name">Lunch location: Multi Company</field>
|
|
<field name="model_id" ref="model_lunch_location"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
</data>
|
|
</odoo>
|