Rémy Voet (ryv)
c1e8a32e7d
As of https://github.com/odoo/odoo/pull/114024, `display_name` is implicit in every form view (see the use of addFieldDependencies in the Form controller). Therefore, when you create a new record for this model, it calls the first `onchange`, which will compute display_name for a new record (id without origin). Some `_compute_display_name` don't handle new records correctly and raise a traceback. These models are sometimes directly accessible: - Accounting > Account Group > New => Traceback - Contact > Contact Tags > New => Traceback Other models are inaccessible by default (no view to access or create a new record), but if someone creates a view for them with studio (or modifies an existing one to allow creation): - `crm.iap.lead.role` - `crm.iap.lead.seniority` - `chatbot.script.answer` - `payment.token` Change the code of `_compute_display_name` on these models to be more defensive and avoid (potential) tracebacks. Similarly, change the `convert_to_display_name` of `fields.Datetime` to take into account `None` value. closes odoo/odoo#139592 Related: odoo/enterprise#49721 Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
59 lines
2.6 KiB
Python
59 lines
2.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import api, models, fields
|
|
from odoo.osv import expression
|
|
|
|
import textwrap
|
|
|
|
|
|
class ChatbotScriptAnswer(models.Model):
|
|
_name = 'chatbot.script.answer'
|
|
_description = 'Chatbot Script Answer'
|
|
_order = 'script_step_id, sequence, id'
|
|
|
|
name = fields.Char(string='Answer', required=True, translate=True)
|
|
sequence = fields.Integer(string='Sequence', default=1)
|
|
redirect_link = fields.Char('Redirect Link',
|
|
help="The visitor will be redirected to this link upon clicking the option "
|
|
"(note that the script will end if the link is external to the livechat website).")
|
|
script_step_id = fields.Many2one(
|
|
'chatbot.script.step', string='Script Step', required=True, ondelete='cascade')
|
|
chatbot_script_id = fields.Many2one(related='script_step_id.chatbot_script_id')
|
|
|
|
@api.depends('script_step_id')
|
|
@api.depends_context('chatbot_script_answer_display_short_name')
|
|
def _compute_display_name(self):
|
|
if self._context.get('chatbot_script_answer_display_short_name'):
|
|
return super()._compute_display_name()
|
|
|
|
for answer in self:
|
|
if answer.script_step_id:
|
|
answer_message = answer.script_step_id.message.replace('\n', ' ')
|
|
shortened_message = textwrap.shorten(answer_message, width=26, placeholder=" [...]")
|
|
answer.display_name = f"{shortened_message}: {answer.name}"
|
|
else:
|
|
answer.display_name = answer.name
|
|
|
|
@api.model
|
|
def _name_search(self, name, domain=None, operator='ilike', limit=None, order=None):
|
|
"""
|
|
Search the records whose name or step message are matching the ``name`` pattern.
|
|
The chatbot_script_id is also passed to the context through the custom widget
|
|
('chatbot_triggering_answers_widget') This allows to only see the question_answer
|
|
from the same chatbot you're configuring.
|
|
"""
|
|
domain = domain or []
|
|
|
|
if name and operator == 'ilike':
|
|
# search on both name OR step's message (combined with passed args)
|
|
name_domain = [('name', operator, name)]
|
|
step_domain = [('script_step_id.message', operator, name)]
|
|
domain = expression.AND([domain, expression.OR([name_domain, step_domain])])
|
|
|
|
force_domain_chatbot_script_id = self.env.context.get('force_domain_chatbot_script_id')
|
|
if force_domain_chatbot_script_id:
|
|
domain = expression.AND([domain, [('chatbot_script_id', '=', force_domain_chatbot_script_id)]])
|
|
|
|
return self._search(domain, limit=limit, order=order)
|