Aline Preillon
2950ffaa86
Currently partners have a boolean field to choose whether to receive notifications only in their Odoo inbox or to receive them in their inbox and by email. This leads to several issues : * if a customer is configured to not receive emails he will not receive any notification on sales orders, leads, ... This is not clearly indicated to the salesman and it is not easy to know how to change that behavior * if an user chooses to receive emails and does not use its inbox a lot of notifications stay in Odoo. The user has to manually set them as done to make them disappear which is redundant. This commit changes that behavior. From now on customers will always receive all notifications by email. Indeed Odoo is not a customer oriented mailbox. Moreover sales orders or discussions on leads send to customers should always be sent by email as it is the standard communication mechanism. Users will be able to choose to receive notifications in Odoo or by email. The choice is no longer inbox or inbox + email, but inbox or email. Choosing one option or the other one depends on the way the user wants to work. Technically the field is moved on the users model and selection keys are renamed. Notification process is modified * notified_partner_ids contains as before specified recipients as well as followers matching the subtype * customers and users working with emails are notified. During that process customers notifications are marked as done to be able to track the email state without having needaction. Users notifications are currently deleted as we do not track their email state. The removal of partner field implies changes in various addons that define partner data with this field set in the values.
340 lines
18 KiB
Python
340 lines
18 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.addons.mail.tests.common import TestMail
|
|
from odoo.addons.mail.tests.test_mail_gateway import MAIL_TEMPLATE_PLAINTEXT
|
|
from odoo.tools import mute_logger
|
|
|
|
|
|
class TestMailFeatures(TestMail):
|
|
# TDE TODO: tests on the redirection controller
|
|
|
|
def test_alias_setup(self):
|
|
alias = self.env['mail.alias'].with_context(alias_model_name='mail.test').create({'alias_name': 'b4r+_#_R3wl$$'})
|
|
self.assertEqual(alias.alias_name, 'b4r+_-_r3wl-', 'Disallowed chars should be replaced by hyphens')
|
|
|
|
def test_10_cache_invalidation(self):
|
|
""" Test that creating a mail-thread record does not invalidate the whole cache. """
|
|
# make a new record in cache
|
|
record = self.env['res.partner'].new({'name': 'Brave New Partner'})
|
|
self.assertTrue(record.name)
|
|
|
|
# creating a mail-thread record should not invalidate the whole cache
|
|
self.env['res.partner'].create({'name': 'Actual Partner'})
|
|
self.assertTrue(record.name)
|
|
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_needaction(self):
|
|
# needaction use Inbox notification
|
|
(self.user_employee | self.user_admin).write({'notification_type': 'inbox'})
|
|
|
|
na_emp1_base = self.test_pigs.sudo(self.user_employee).message_needaction_counter
|
|
na_emp2_base = self.test_pigs.sudo().message_needaction_counter
|
|
|
|
self.test_pigs.message_post(body='Test', message_type='comment', subtype='mail.mt_comment', partner_ids=[self.user_employee.partner_id.id])
|
|
|
|
na_emp1_new = self.test_pigs.sudo(self.user_employee).message_needaction_counter
|
|
na_emp2_new = self.test_pigs.sudo().message_needaction_counter
|
|
self.assertEqual(na_emp1_new, na_emp1_base + 1)
|
|
self.assertEqual(na_emp2_new, na_emp2_base)
|
|
|
|
|
|
class TestMessagePost(TestMail):
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_post_no_subscribe_author(self):
|
|
original = self.test_pigs.message_follower_ids
|
|
self.test_pigs.sudo(self.user_employee).with_context({'mail_create_nosubscribe': True}).message_post(
|
|
body='Test Body', message_type='comment', subtype='mt_comment')
|
|
self.assertEqual(self.test_pigs.message_follower_ids.mapped('partner_id'), original.mapped('partner_id'))
|
|
self.assertEqual(self.test_pigs.message_follower_ids.mapped('channel_id'), original.mapped('channel_id'))
|
|
|
|
# TODO : the author of a message post on mail.test should not be added as follower
|
|
|
|
# @mute_logger('odoo.addons.mail.models.mail_mail')
|
|
# def test_post_subscribe_author(self):
|
|
# original = self.test_pigs.message_follower_ids
|
|
# self.test_pigs.sudo(self.user_employee).message_post(
|
|
# body='Test Body', message_type='comment', subtype='mt_comment')
|
|
# self.assertEqual(self.test_pigs.message_follower_ids.mapped('partner_id'), original.mapped('partner_id') | self.user_employee.partner_id)
|
|
# self.assertEqual(self.test_pigs.message_follower_ids.mapped('channel_id'), original.mapped('channel_id'))
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_post_no_subscribe_recipients(self):
|
|
original = self.test_pigs.message_follower_ids
|
|
self.test_pigs.sudo(self.user_employee).with_context({'mail_create_nosubscribe': True}).message_post(
|
|
body='Test Body', message_type='comment', subtype='mt_comment', partner_ids=[(4, self.partner_1.id), (4, self.partner_2.id)])
|
|
self.assertEqual(self.test_pigs.message_follower_ids.mapped('partner_id'), original.mapped('partner_id'))
|
|
self.assertEqual(self.test_pigs.message_follower_ids.mapped('channel_id'), original.mapped('channel_id'))
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_post_subscribe_recipients(self):
|
|
original = self.test_pigs.message_follower_ids
|
|
self.test_pigs.sudo(self.user_employee).with_context({'mail_create_nosubscribe': True, 'mail_post_autofollow': True}).message_post(
|
|
body='Test Body', message_type='comment', subtype='mt_comment', partner_ids=[(4, self.partner_1.id), (4, self.partner_2.id)])
|
|
self.assertEqual(self.test_pigs.message_follower_ids.mapped('partner_id'), original.mapped('partner_id') | self.partner_1 | self.partner_2)
|
|
self.assertEqual(self.test_pigs.message_follower_ids.mapped('channel_id'), original.mapped('channel_id'))
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_post_subscribe_recipients_partial(self):
|
|
original = self.test_pigs.message_follower_ids
|
|
self.test_pigs.sudo(self.user_employee).with_context({'mail_create_nosubscribe': True, 'mail_post_autofollow': True, 'mail_post_autofollow_partner_ids': [self.partner_2.id]}).message_post(
|
|
body='Test Body', message_type='comment', subtype='mt_comment', partner_ids=[(4, self.partner_1.id), (4, self.partner_2.id)])
|
|
self.assertEqual(self.test_pigs.message_follower_ids.mapped('partner_id'), original.mapped('partner_id') | self.partner_2)
|
|
self.assertEqual(self.test_pigs.message_follower_ids.mapped('channel_id'), original.mapped('channel_id'))
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_post_notifications(self):
|
|
_body, _body_alt = '<p>Test Body</p>', 'Test Body'
|
|
_subject = 'Test Subject'
|
|
_attachments = [
|
|
('List1', 'My first attachment'),
|
|
('List2', 'My second attachment')
|
|
]
|
|
_attach_1 = self.env['ir.attachment'].sudo(self.user_employee).create({
|
|
'name': 'Attach1', 'datas_fname': 'Attach1',
|
|
'datas': 'bWlncmF0aW9uIHRlc3Q=',
|
|
'res_model': 'mail.compose.message', 'res_id': 0})
|
|
_attach_2 = self.env['ir.attachment'].sudo(self.user_employee).create({
|
|
'name': 'Attach2', 'datas_fname': 'Attach2',
|
|
'datas': 'bWlncmF0aW9uIHRlc3Q=',
|
|
'res_model': 'mail.compose.message', 'res_id': 0})
|
|
|
|
self.user_admin.write({'notification_type': 'email'})
|
|
|
|
# subscribe second employee to the group to test notifications
|
|
self.test_pigs.message_subscribe_users(user_ids=[self.env.user.id])
|
|
|
|
# use aliases
|
|
_domain = 'schlouby.fr'
|
|
_catchall = 'test_catchall'
|
|
self.env['ir.config_parameter'].set_param('mail.catchall.domain', _domain)
|
|
self.env['ir.config_parameter'].set_param('mail.catchall.alias', _catchall)
|
|
|
|
msg = self.test_pigs.sudo(self.user_employee).message_post(
|
|
body=_body, subject=_subject, partner_ids=[self.partner_1.id, self.partner_2.id],
|
|
attachment_ids=[_attach_1.id, _attach_2.id], attachments=_attachments,
|
|
message_type='comment', subtype='mt_comment')
|
|
|
|
# message content
|
|
self.assertEqual(msg.subject, _subject)
|
|
self.assertEqual(msg.body, _body)
|
|
self.assertEqual(msg.partner_ids, self.partner_1 | self.partner_2)
|
|
self.assertEqual(msg.needaction_partner_ids, self.env.user.partner_id | self.partner_1 | self.partner_2)
|
|
self.assertEqual(msg.channel_ids, self.env['mail.channel'])
|
|
|
|
# attachments
|
|
self.assertEqual(set(msg.attachment_ids.mapped('res_model')), set(['mail.test']),
|
|
'message_post: all atttachments should be linked to the mail.test model')
|
|
self.assertEqual(set(msg.attachment_ids.mapped('res_id')), set([self.test_pigs.id]),
|
|
'message_post: all atttachments should be linked to the pigs group')
|
|
self.assertEqual(set([x.decode('base64') for x in msg.attachment_ids.mapped('datas')]),
|
|
set(['migration test', _attachments[0][1], _attachments[1][1]]))
|
|
self.assertTrue(set([_attach_1.id, _attach_2.id]).issubset(msg.attachment_ids.ids),
|
|
'message_post: mail.message attachments duplicated')
|
|
# notifications
|
|
self.assertFalse(self.env['mail.mail'].search([('mail_message_id', '=', msg.message_id)]),
|
|
'message_post: mail.mail notifications should have been auto-deleted')
|
|
|
|
# notification emails: followers + recipients - author (user_employee)
|
|
self.assertEqual(set(m['email_from'] for m in self._mails),
|
|
set(['%s <%s>' % (self.user_employee.name, self.user_employee.email)]),
|
|
'message_post: notification email wrong email_from: should use sender email')
|
|
self.assertEqual(set(m['email_to'][0] for m in self._mails),
|
|
set(['%s <%s>' % (self.partner_1.name, self.partner_1.email),
|
|
'%s <%s>' % (self.partner_2.name, self.partner_2.email),
|
|
'%s <%s>' % (self.env.user.name, self.env.user.email)]))
|
|
self.assertFalse(any(len(m['email_to']) != 1 for m in self._mails),
|
|
'message_post: notification email should be sent to one partner at a time')
|
|
self.assertEqual(set(m['reply_to'] for m in self._mails),
|
|
set(['%s %s <%s@%s>' % (self.env.user.company_id.name, self.test_pigs.name, self.test_pigs.alias_name, _domain)]),
|
|
'message_post: notification email should use group aliases and data for reply to')
|
|
self.assertTrue(all(_subject in m['subject'] for m in self._mails))
|
|
self.assertTrue(all(_body in m['body'] for m in self._mails))
|
|
self.assertTrue(all(_body_alt in m['body'] for m in self._mails))
|
|
self.assertFalse(any(m['references'] for m in self._mails))
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_post_answer(self):
|
|
_body = '<p>Test Body</p>'
|
|
_subject = 'Test Subject'
|
|
|
|
# use aliases
|
|
_domain = 'schlouby.fr'
|
|
_catchall = 'test_catchall'
|
|
self.env['ir.config_parameter'].set_param('mail.catchall.domain', _domain)
|
|
self.env['ir.config_parameter'].set_param('mail.catchall.alias', _catchall)
|
|
|
|
parent_msg = self.test_pigs.sudo(self.user_employee).message_post(
|
|
body=_body, subject=_subject,
|
|
message_type='comment', subtype='mt_comment')
|
|
|
|
self.assertEqual(parent_msg.partner_ids, self.env['res.partner'])
|
|
|
|
msg = self.test_pigs.sudo(self.user_employee).message_post(
|
|
body=_body, subject=_subject, partner_ids=[self.partner_1.id],
|
|
message_type='comment', subtype='mt_comment', parent_id=parent_msg.id)
|
|
|
|
self.assertEqual(msg.parent_id.id, parent_msg.id)
|
|
self.assertEqual(msg.partner_ids, self.partner_1)
|
|
# self.assertEqual(parent_msg.partner_ids, self.partner_1) # TDE FIXME: to check
|
|
self.assertTrue(all('openerp-%d-mail.test' % self.test_pigs.id in m['references'] for m in self._mails))
|
|
new_msg = self.test_pigs.sudo(self.user_employee).message_post(
|
|
body=_body, subject=_subject,
|
|
message_type='comment', subtype='mt_comment', parent_id=msg.id)
|
|
|
|
self.assertEqual(new_msg.parent_id.id, parent_msg.id, 'message_post: flatten error')
|
|
self.assertFalse(new_msg.partner_ids)
|
|
|
|
def test_post_portal(self):
|
|
self.test_pigs.message_subscribe((self.partner_1 | self.user_employee.partner_id).ids)
|
|
new_msg = self.test_pigs.sudo(self.user_portal).message_post(
|
|
body='<p>Test</p>', subject='Subject',
|
|
message_type='comment', subtype='mt_comment')
|
|
self.assertEqual(new_msg.sudo().needaction_partner_ids, (self.partner_1 | self.user_employee.partner_id))
|
|
|
|
self.assertEqual(
|
|
set(m['email_to'][0] for m in self._mails),
|
|
set(['%s <%s>' % (self.partner_1.name, self.partner_1.email),
|
|
'%s <%s>' % (self.user_employee.name, self.user_employee.email)]))
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_post_internal(self):
|
|
self.test_pigs.message_subscribe_users([self.user_admin.id])
|
|
msg = self.test_pigs.sudo(self.user_employee).message_post(
|
|
body='My Body', subject='My Subject',
|
|
message_type='comment', subtype='mt_note')
|
|
self.assertEqual(msg.partner_ids, self.env['res.partner'])
|
|
self.assertEqual(msg.needaction_partner_ids, self.env['res.partner'])
|
|
self.assertEqual(self.test_pigs.message_ids, msg)
|
|
|
|
self.format_and_process(
|
|
MAIL_TEMPLATE_PLAINTEXT,
|
|
email_from=self.user_admin.email,
|
|
msg_id='<1198923581.41972151344608186800.JavaMail.diff1@agrolait.com>',
|
|
to='not_my_businesss@example.com',
|
|
extra='In-Reply-To:\r\n\t%s\n' % msg.message_id)
|
|
reply = self.test_pigs.message_ids - msg
|
|
self.assertTrue(reply)
|
|
self.assertEqual(reply.subtype_id, self.env.ref('mail.mt_note'))
|
|
self.assertEqual(reply.needaction_partner_ids, self.user_employee.partner_id)
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_message_compose(self):
|
|
composer = self.env['mail.compose.message'].with_context({
|
|
'default_composition_mode': 'comment',
|
|
'default_model': 'mail.test',
|
|
'default_res_id': self.test_pigs.id,
|
|
}).sudo(self.user_employee).create({
|
|
'body': '<p>Test Body</p>',
|
|
'partner_ids': [(4, self.partner_1.id), (4, self.partner_2.id)]
|
|
})
|
|
self.assertEqual(composer.composition_mode, 'comment')
|
|
self.assertEqual(composer.model, 'mail.test')
|
|
self.assertEqual(composer.subject, 'Re: %s' % self.test_pigs.name)
|
|
self.assertEqual(composer.record_name, self.test_pigs.name)
|
|
|
|
composer.send_mail()
|
|
message = self.test_pigs.message_ids[0]
|
|
|
|
composer = self.env['mail.compose.message'].with_context({
|
|
'default_composition_mode': 'comment',
|
|
'default_res_id': self.test_pigs.id,
|
|
'default_parent_id': message.id
|
|
}).sudo(self.user_employee).create({})
|
|
|
|
self.assertEqual(composer.model, 'mail.test')
|
|
self.assertEqual(composer.res_id, self.test_pigs.id)
|
|
self.assertEqual(composer.parent_id, message)
|
|
self.assertEqual(composer.subject, 'Re: %s' % self.test_pigs.name)
|
|
|
|
# TODO: test attachments ?
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_message_compose_mass_mail(self):
|
|
composer = self.env['mail.compose.message'].with_context({
|
|
'default_composition_mode': 'mass_mail',
|
|
'default_model': 'mail.test',
|
|
'default_res_id': False,
|
|
'active_ids': [self.test_pigs.id, self.test_public.id]
|
|
}).sudo(self.user_employee).create({
|
|
'subject': 'Testing ${object.name}',
|
|
'body': '<p>${object.description}</p>',
|
|
'partner_ids': [(4, self.partner_1.id), (4, self.partner_2.id)]
|
|
})
|
|
composer.with_context({
|
|
'default_res_id': -1,
|
|
'active_ids': [self.test_pigs.id, self.test_public.id]
|
|
}).send_mail()
|
|
|
|
# check mail_mail
|
|
mails = self.env['mail.mail'].search([('subject', 'ilike', 'Testing')])
|
|
for mail in mails:
|
|
self.assertEqual(mail.recipient_ids, self.partner_1 | self.partner_2,
|
|
'compose wizard: mail_mail mass mailing: mail.mail in mass mail incorrect recipients')
|
|
|
|
# check message on test_pigs
|
|
message1 = self.test_pigs.message_ids[0]
|
|
self.assertEqual(message1.subject, 'Testing %s' % self.test_pigs.name)
|
|
self.assertEqual(message1.body, '<p>%s</p>' % self.test_pigs.description)
|
|
|
|
# check message on test_public
|
|
message1 = self.test_public.message_ids[0]
|
|
self.assertEqual(message1.subject, 'Testing %s' % self.test_public.name)
|
|
self.assertEqual(message1.body, '<p>%s</p>' % self.test_public.description)
|
|
|
|
# # Test: Pigs and Bird did receive their message
|
|
# # check logged messages
|
|
# message1 = test_pigs.message_ids[0]
|
|
# message2 = group_bird.message_ids[0]
|
|
# # Test: Pigs and Bird did receive their message
|
|
# messages = self.MailMessage.search([], limit=2)
|
|
# mail = self.MailMail.search([('mail_message_id', '=', message2.id)], limit=1)
|
|
# self.assertTrue(mail, 'message_send: mail.mail message should have in processing mail queue')
|
|
# #check mass mail state...
|
|
# mails = self.MailMail.search([('state', '=', 'exception')])
|
|
# self.assertNotIn(mail.id, mails.ids, 'compose wizard: Mail sending Failed!!')
|
|
# self.assertIn(message1.id, messages.ids, 'compose wizard: Pigs did not receive its mass mailing message')
|
|
# self.assertIn(message2.id, messages.ids, 'compose wizard: Bird did not receive its mass mailing message')
|
|
|
|
# check followers ?
|
|
# Test: mail.test followers: author not added as follower in mass mail mode
|
|
# self.assertEqual(set(test_pigs.message_follower_ids.ids), set([self.partner_admin_id, p_b.id, p_c.id, p_d.id]),
|
|
# 'compose wizard: mail_post_autofollow and mail_create_nosubscribe context keys not correctly taken into account')
|
|
# self.assertEqual(set(group_bird.message_follower_ids.ids), set([self.partner_admin_id]),
|
|
# 'compose wizard: mail_post_autofollow and mail_create_nosubscribe context keys not correctly taken into account')
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_message_compose_mass_mail_active_domain(self):
|
|
self.env['mail.compose.message'].with_context({
|
|
'default_composition_mode': 'mass_mail',
|
|
'default_model': 'mail.test',
|
|
'default_use_active_domain': True,
|
|
'active_ids': [self.test_pigs.id],
|
|
'active_domain': [('name', 'in', ['%s' % self.test_pigs.name, '%s' % self.test_public.name])],
|
|
}).sudo(self.user_employee).create({
|
|
'subject': 'From Composer Test',
|
|
'body': '${object.description}',
|
|
}).send_mail()
|
|
|
|
self.assertEqual(self.test_pigs.message_ids[0].subject, 'From Composer Test')
|
|
self.assertEqual(self.test_public.message_ids[0].subject, 'From Composer Test')
|
|
|
|
|
|
@mute_logger('odoo.addons.mail.models.mail_mail')
|
|
def test_message_compose_mass_mail_no_active_domain(self):
|
|
self.env['mail.compose.message'].with_context({
|
|
'default_composition_mode': 'mass_mail',
|
|
'default_model': 'mail.test',
|
|
'default_use_active_domain': False,
|
|
'active_ids': [self.test_pigs.id],
|
|
'active_domain': [('name', 'in', ['%s' % self.test_pigs.name, '%s' % self.test_public.name])],
|
|
}).sudo(self.user_employee).create({
|
|
'subject': 'From Composer Test',
|
|
'body': '${object.description}',
|
|
}).send_mail()
|
|
|
|
self.assertEqual(self.test_pigs.message_ids[0].subject, 'From Composer Test')
|
|
self.assertFalse(self.test_public.message_ids.ids)
|