Tiffany Chang (tic)
f533e40f0e
Previously the "call to tender" flow involved creating a
`purchase.requisition` record, creating each RFQ via that record, and
then manually going through each RFQ to compare the prices/dates/etc.
By linking the "call to tender" POs within the POs, we remove an
unnecessary `purchase.requestion` record and makes it easier to track
which RFQs are related to each other as an Alternative RFQ.
On top of this, we add some comparision features to make it easier to
determine the best RFQ, specificially the ability to compare PO lines in
the same view with some visual aids (best price/date colored green +
buttons to check these lines to make them easier to view). We also add
an extra feature to set the qty of selected/non-chosen PO lines to 0 to
aid in the RFQ selection process (only applies to non-confirmed/done/
cancelled POs).
Some other features included with this:
- option to cancel alternative POs when confirming one, which purposely
does not cancel ones that have already been confirmed/completed.
- new wizard for creating alternative POs so user can select whether or
not they want to copy the products/qtys from the original PO.
Important Notes:
- JS Customizations:
- custom many2many widget added so user:
- can click between alternative POs in same window + keep breadcrumb.
This is because all alt POs are interconnected and long breadcrumb
chain is possible (+ we want to avoid windows within windows.) It
is expected that user will be aware that unsaved changes will
auto-save when alt PO is clicked on.
- cannot unlink a PO from itself (this is automagically done during
the write) since this will remove all of its linked POs and might
confuse users.
- custom view js for Comparing Order Lines to help highlight best
options, including ensuring that the best options are still
highlighted after clicking on Choose/Clear buttons (since the best
option can change afterwards, we recalc + update via RPC)
- General implementation warnings:
- Anytime any button/alternative PO is clicked on within a PO, the
form will auto-save. This is due to how the current action service
handles changing views.
- POs created via "Create Alternative" button purposely:
- require a vendor to ensure correct lead times/prices
- show all vendor/product warnings in wizard because we cannot
reproduce the pop-up warning that would occur in the PO when
they are selected. We also purposely block the PO creation when a
blocking warning is set since we cannot remove the values
(especially in the case of a blocking vendor message) from a
newly created PO.
- Technical purchase.order.group model created to help with difficult
management of complicated behaviors:
- unlink from self if a PO is no longer linked to any other POs
- linkages must be symmetric (i.e. linkage PO1 => PO2 must
reflect PO2 => PO1 in their form views)
- don't lose existing linkages (i.e. PO1 => PO2 and PO2 => PO3
should auto-link PO1 => PO3)
These last two behaviors are difficult to do without grouping due to
possibility of remove and adding linkages at the same time. To avoid
complex code to ensure these complexities hold when when creating a
new PO, linkaging to alternatives is not allowed when PO is not yet
saved as a record.
Task: 2695116
Upgrade PR: odoo/upgrade#3586
closes odoo/odoo#87656
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
218 lines
12 KiB
Python
218 lines
12 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.addons.purchase_requisition.tests.common import TestPurchaseRequisitionCommon
|
|
from odoo import Command
|
|
from odoo.tests import Form
|
|
|
|
from datetime import timedelta
|
|
|
|
|
|
class TestPurchaseRequisition(TestPurchaseRequisitionCommon):
|
|
|
|
def test_00_purchase_requisition_users(self):
|
|
self.assertTrue(self.user_purchase_requisition_manager, 'Manager Should be created')
|
|
self.assertTrue(self.user_purchase_requisition_user, 'User Should be created')
|
|
|
|
def test_01_cancel_purchase_requisition(self):
|
|
self.bo_requisition.with_user(self.user_purchase_requisition_user).action_cancel()
|
|
# Check requisition after cancelled.
|
|
self.assertEqual(self.bo_requisition.state, 'cancel', 'Requisition should be in cancelled state.')
|
|
# I reset requisition as "New".
|
|
self.bo_requisition.with_user(self.user_purchase_requisition_user).action_draft()
|
|
# I duplicate requisition.
|
|
self.bo_requisition.with_user(self.user_purchase_requisition_user).copy()
|
|
|
|
def test_02_purchase_requisition(self):
|
|
price_product09 = 34
|
|
price_product13 = 62
|
|
quantity = 26
|
|
|
|
# Create a pruchase requisition with type blanket order and two product
|
|
line1 = (0, 0, {'product_id': self.product_09.id, 'product_qty': quantity, 'product_uom_id': self.product_uom_id.id, 'price_unit': price_product09})
|
|
line2 = (0, 0, {'product_id': self.product_13.id, 'product_qty': quantity, 'product_uom_id': self.product_uom_id.id, 'price_unit': price_product13})
|
|
|
|
requisition_type = self.env['purchase.requisition.type'].create({
|
|
'name': 'Blanket test',
|
|
'quantity_copy': 'none'
|
|
})
|
|
requisition_blanket = self.env['purchase.requisition'].create({
|
|
'line_ids': [line1, line2],
|
|
'type_id': requisition_type.id,
|
|
'vendor_id': self.res_partner_1.id,
|
|
})
|
|
|
|
# confirm the requisition
|
|
requisition_blanket.action_in_progress()
|
|
|
|
# Check for both product that the new supplier info(purchase.requisition.vendor_id) is added to the purchase tab
|
|
# and check the quantity
|
|
seller_partner1 = self.res_partner_1
|
|
supplierinfo09 = self.env['product.supplierinfo'].search([
|
|
('partner_id', '=', seller_partner1.id),
|
|
('product_id', '=', self.product_09.id),
|
|
('purchase_requisition_id', '=', requisition_blanket.id),
|
|
])
|
|
self.assertEqual(supplierinfo09.partner_id, seller_partner1, 'The supplierinfo is not correct')
|
|
self.assertEqual(supplierinfo09.price, price_product09, 'The supplierinfo is not correct')
|
|
|
|
supplierinfo13 = self.env['product.supplierinfo'].search([
|
|
('partner_id', '=', seller_partner1.id),
|
|
('product_id', '=', self.product_13.id),
|
|
('purchase_requisition_id', '=', requisition_blanket.id),
|
|
])
|
|
self.assertEqual(supplierinfo13.partner_id, seller_partner1, 'The supplierinfo is not correct')
|
|
self.assertEqual(supplierinfo13.price, price_product13, 'The supplierinfo is not correct')
|
|
|
|
# Put the requisition in done Status
|
|
requisition_blanket.action_in_progress()
|
|
requisition_blanket.action_done()
|
|
|
|
self.assertFalse(self.env['product.supplierinfo'].search([('id', '=', supplierinfo09.id)]), 'The supplier info should be removed')
|
|
self.assertFalse(self.env['product.supplierinfo'].search([('id', '=', supplierinfo13.id)]), 'The supplier info should be removed')
|
|
|
|
def test_06_purchase_requisition(self):
|
|
""" Create a blanket order for a product and a vendor already linked via
|
|
a supplier info"""
|
|
product = self.env['product.product'].create({
|
|
'name': 'test6',
|
|
})
|
|
product2 = self.env['product.product'].create({
|
|
'name': 'test6',
|
|
})
|
|
vendor = self.env['res.partner'].create({
|
|
'name': 'vendor6',
|
|
})
|
|
supplier_info = self.env['product.supplierinfo'].create({
|
|
'product_id': product.id,
|
|
'partner_id': vendor.id,
|
|
})
|
|
|
|
# create an empty blanket order
|
|
requisition_type = self.env['purchase.requisition.type'].create({
|
|
'name': 'Blanket test',
|
|
'quantity_copy': 'none'
|
|
})
|
|
line1 = (0, 0, {
|
|
'product_id': product2.id,
|
|
'product_uom_id': product2.uom_po_id.id,
|
|
'price_unit': 41,
|
|
'product_qty': 10,
|
|
})
|
|
requisition_blanket = self.env['purchase.requisition'].create({
|
|
'line_ids': [line1],
|
|
'type_id': requisition_type.id,
|
|
'vendor_id': vendor.id,
|
|
})
|
|
requisition_blanket.action_in_progress()
|
|
self.env['purchase.requisition.line'].create({
|
|
'product_id': product.id,
|
|
'product_qty': 14.0,
|
|
'requisition_id': requisition_blanket.id,
|
|
'price_unit': 10,
|
|
})
|
|
new_si = self.env['product.supplierinfo'].search([
|
|
('product_id', '=', product.id),
|
|
('partner_id', '=', vendor.id)
|
|
]) - supplier_info
|
|
self.assertEqual(new_si.purchase_requisition_id, requisition_blanket, 'the blanket order is not linked to the supplier info')
|
|
|
|
def test_07_alternative_purchases_wizards(self):
|
|
"""Directly link POs to each other as 'Alternatives': check that wizards and
|
|
their flows correctly work."""
|
|
orig_po = self.env['purchase.order'].create({
|
|
'partner_id': self.res_partner_1.id,
|
|
})
|
|
unit_price = 50
|
|
po_form = Form(orig_po)
|
|
with po_form.order_line.new() as line:
|
|
line.product_id = self.product_09
|
|
line.product_qty = 5.0
|
|
line.price_unit = unit_price
|
|
po_form.save()
|
|
|
|
# first flow: check that creating an alt PO correctly auto-links both POs to each other
|
|
action = orig_po.action_create_alternative()
|
|
alt_po_wiz = Form(self.env['purchase.requisition.create.alternative'].with_context(**action['context']))
|
|
alt_po_wiz.partner_id = self.res_partner_1
|
|
alt_po_wiz.copy_products = True
|
|
alt_po_wiz = alt_po_wiz.save()
|
|
alt_po_wiz.action_create_alternative()
|
|
self.assertEqual(len(orig_po.alternative_po_ids), 2, "Original PO should be auto-linked to itself and newly created PO")
|
|
|
|
# check alt po was created with correct values
|
|
alt_po_1 = orig_po.alternative_po_ids.filtered(lambda po: po.id != orig_po.id)
|
|
self.assertEqual(orig_po.order_line.product_id, alt_po_1.order_line.product_id, "Alternative PO should have copied the product to purchase from original PO")
|
|
self.assertEqual(orig_po.order_line.product_qty, alt_po_1.order_line.product_qty, "Alternative PO should have copied the qty to purchase from original PO")
|
|
self.assertEqual(len(alt_po_1.alternative_po_ids), 2, "Newly created PO should be auto-linked to itself and original PO")
|
|
|
|
# check compare POLs correctly calcs best date/price PO lines: orig_po.date_planned = best & alt_po.price = best
|
|
alt_po_1.order_line.date_planned += timedelta(days=1)
|
|
alt_po_1.order_line.price_unit = unit_price - 10
|
|
action = orig_po.action_compare_alternative_lines()
|
|
params = action['context']['params']
|
|
best_price_pol = self.env['purchase.order.line'].browse(params['best_price_ids'])
|
|
best_date_pol = self.env['purchase.order.line'].browse(params['best_date_ids'])
|
|
self.assertEqual(best_price_pol.order_id.id, alt_po_1.id, "Best price PO line was not correctly calculated")
|
|
self.assertEqual(best_date_pol.order_id.id, orig_po.id, "Best date PO line was not correctly calculated")
|
|
|
|
# second flow: create extra alt PO, check that all 3 POs are correctly auto-linked
|
|
action = orig_po.action_create_alternative()
|
|
alt_po_wiz = Form(self.env['purchase.requisition.create.alternative'].with_context(**action['context']))
|
|
alt_po_wiz.partner_id = self.res_partner_1
|
|
alt_po_wiz.copy_products = True
|
|
alt_po_wiz = alt_po_wiz.save()
|
|
alt_po_wiz.action_create_alternative()
|
|
self.assertEqual(len(orig_po.alternative_po_ids), 3, "Original PO should be auto-linked to newly created alternative PO")
|
|
self.assertEqual(len(alt_po_1.alternative_po_ids), 3, "Alternative PO should be auto-linked to newly created alternative PO")
|
|
alt_po_2 = orig_po.alternative_po_ids.filtered(lambda po: po.id not in [alt_po_1.id, orig_po.id])
|
|
self.assertEqual(len(alt_po_2.alternative_po_ids), 3, "All alternative POs should be auto-linked to each other")
|
|
|
|
# third flow: confirm one of the POs when alt POs are a mix of confirmed + RFQs
|
|
alt_po_2.write({'state': 'purchase'})
|
|
action = orig_po.button_confirm()
|
|
warning_wiz = Form(self.env['purchase.requisition.alternative.warning'].with_context(**action['context']))
|
|
warning_wiz = warning_wiz.save()
|
|
self.assertEqual(warning_wiz.alternative_po_count, 1, "POs not in a RFQ status should not be listed as possible to cancel")
|
|
warning_wiz.action_cancel_alternatives()
|
|
self.assertEqual(alt_po_1.state, 'cancel', "Alternative PO should have been cancelled")
|
|
self.assertEqual(orig_po.state, 'purchase', "Original PO should have been confirmed")
|
|
|
|
def test_08_purchases_multi_linkages(self):
|
|
"""Directly link POs to each other as 'Alternatives': check linking/unlinking
|
|
POs that are already linked correctly work."""
|
|
pos = []
|
|
for _ in range(5):
|
|
pos += self.env['purchase.order'].create({
|
|
'partner_id': self.res_partner_1.id,
|
|
}).ids
|
|
pos = self.env['purchase.order'].browse(pos)
|
|
po_1, po_2, po_3, po_4, po_5 = pos
|
|
|
|
po_1.alternative_po_ids |= po_2
|
|
po_3.alternative_po_ids |= po_4
|
|
groups = self.env['purchase.order.group'].search([('order_ids', 'in', pos.ids)])
|
|
self.assertEqual(len(po_1.alternative_po_ids), 2, "PO1 and PO2 should only be linked to each other")
|
|
self.assertEqual(len(po_3.alternative_po_ids), 2, "PO3 and PO4 should only be linked to each other")
|
|
self.assertEqual(len(groups), 2, "There should only be 2 groups: (PO1,PO2) and (PO3,PO4)")
|
|
|
|
# link non-linked PO to already linked PO
|
|
po_5.alternative_po_ids |= po_4
|
|
groups = self.env['purchase.order.group'].search([('order_ids', 'in', pos.ids)])
|
|
self.assertEqual(len(po_3.alternative_po_ids), 3, "PO3 should now be linked to PO4 and PO5")
|
|
self.assertEqual(len(po_4.alternative_po_ids), 3, "PO4 should now be linked to PO3 and PO5")
|
|
self.assertEqual(len(po_5.alternative_po_ids), 3, "PO5 should now be linked to PO3 and PO4")
|
|
self.assertEqual(len(groups), 2, "There should only be 2 groups: (PO1,PO2) and (PO3,PO4,PO5)")
|
|
|
|
# link already linked PO to already linked PO
|
|
po_5.alternative_po_ids |= po_1
|
|
groups = self.env['purchase.order.group'].search([('order_ids', 'in', pos.ids)])
|
|
self.assertEqual(len(po_1.alternative_po_ids), 5, "All 5 POs should be linked to each other now")
|
|
self.assertEqual(len(groups), 1, "There should only be 1 group containing all 5 POs (other group should have auto-deleted")
|
|
|
|
# remove all links, make sure group auto-deletes
|
|
(pos - po_5).alternative_po_ids = [Command.clear()]
|
|
groups = self.env['purchase.order.group'].search([('order_ids', 'in', pos.ids)])
|
|
self.assertEqual(len(po_5.alternative_po_ids), 0, "Last PO should auto unlink from itself since group should have auto-deleted")
|
|
self.assertEqual(len(groups), 0, "The group should have auto-deleted")
|