Antoine Vandevenne (anv)
f4ca7290ac
Before this commit, most acquirers needed to run several successive searches for the transaction whose reference was received by a controller in notification data. This is because the security checks run on the notification data require access to the acquirer through the transaction record which was immediately discarded. Starting with this commit, all `*_feedback_data` method are no longer decorated with `api.model` and can use the transaction record they're called on if provided. They are also renamed to `*_notification_data`. task-2737144 closes odoo/odoo#83850 Related: odoo/enterprise#23938 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
128 lines
5.0 KiB
Python
128 lines
5.0 KiB
Python
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
import logging
|
|
|
|
from werkzeug import urls
|
|
|
|
from odoo import _, api, models
|
|
from odoo.exceptions import ValidationError
|
|
from odoo.tools.float_utils import float_compare
|
|
|
|
from odoo.addons.payment_alipay.controllers.main import AlipayController
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
class PaymentTransaction(models.Model):
|
|
_inherit = 'payment.transaction'
|
|
|
|
def _get_specific_rendering_values(self, processing_values):
|
|
""" Override of payment to return Alipay-specific rendering values.
|
|
|
|
Note: self.ensure_one() from `_get_processing_values`
|
|
|
|
:param dict processing_values: The generic and specific processing values of the transaction
|
|
:return: The dict of acquirer-specific processing values
|
|
:rtype: dict
|
|
"""
|
|
res = super()._get_specific_rendering_values(processing_values)
|
|
if self.provider != 'alipay':
|
|
return res
|
|
|
|
base_url = self.acquirer_id.get_base_url()
|
|
if self.fees:
|
|
# Similarly to what is done in `payment::payment.transaction.create`, we need to round
|
|
# the sum of the amount and of the fees to avoid inconsistent string representations.
|
|
# E.g., str(1111.11 + 7.09) == '1118.1999999999998'
|
|
total_fee = self.currency_id.round(self.amount + self.fees)
|
|
else:
|
|
total_fee = self.amount
|
|
rendering_values = {
|
|
'_input_charset': 'utf-8',
|
|
'notify_url': urls.url_join(base_url, AlipayController._webhook_url),
|
|
'out_trade_no': self.reference,
|
|
'partner': self.acquirer_id.alipay_merchant_partner_id,
|
|
'return_url': urls.url_join(base_url, AlipayController._return_url),
|
|
'subject': self.reference,
|
|
'total_fee': total_fee,
|
|
}
|
|
if self.acquirer_id.alipay_payment_method == 'standard_checkout':
|
|
# https://global.alipay.com/docs/ac/global/create_forex_trade
|
|
rendering_values.update({
|
|
'service': 'create_forex_trade',
|
|
'product_code': 'NEW_OVERSEAS_SELLER',
|
|
'currency': self.currency_id.name,
|
|
})
|
|
else:
|
|
rendering_values.update({
|
|
'service': 'create_direct_pay_by_user',
|
|
'payment_type': 1,
|
|
'seller_email': self.acquirer_id.alipay_seller_email,
|
|
})
|
|
|
|
sign = self.acquirer_id._alipay_compute_signature(rendering_values)
|
|
rendering_values.update({
|
|
'sign_type': 'MD5',
|
|
'sign': sign,
|
|
'api_url': self.acquirer_id._alipay_get_api_url(),
|
|
})
|
|
return rendering_values
|
|
|
|
def _get_tx_from_notification_data(self, provider, notification_data):
|
|
""" Override of payment to find the transaction based on Alipay data.
|
|
|
|
:param str provider: The provider of the acquirer that handled the transaction
|
|
:param dict notification_data: The notification data sent by the provider
|
|
:return: The transaction if found
|
|
:rtype: recordset of `payment.transaction`
|
|
:raise: ValidationError if inconsistent data were received
|
|
:raise: ValidationError if the data match no transaction
|
|
"""
|
|
tx = super()._get_tx_from_notification_data(provider, notification_data)
|
|
if provider != 'alipay' or len(tx) == 1:
|
|
return tx
|
|
|
|
reference = notification_data.get('reference') or notification_data.get('out_trade_no')
|
|
txn_id = notification_data.get('trade_no')
|
|
if not reference or not txn_id:
|
|
raise ValidationError(
|
|
"Alipay: " + _(
|
|
"Received data with missing reference %(r)s or txn_id %(t)s.",
|
|
r=reference, t=txn_id
|
|
)
|
|
)
|
|
|
|
tx = self.search([('reference', '=', reference), ('provider', '=', 'alipay')])
|
|
if not tx:
|
|
raise ValidationError(
|
|
"Alipay: " + _("No transaction found matching reference %s.", reference)
|
|
)
|
|
|
|
return tx
|
|
|
|
def _process_notification_data(self, notification_data):
|
|
""" Override of payment to process the transaction based on Alipay data.
|
|
|
|
Note: self.ensure_one()
|
|
|
|
:param dict notification_data: The notification data sent by the provider
|
|
:return: None
|
|
:raise: ValidationError if inconsistent data were received
|
|
"""
|
|
super()._process_notification_data(notification_data)
|
|
if self.provider != 'alipay':
|
|
return
|
|
|
|
self.acquirer_reference = notification_data.get('trade_no')
|
|
status = notification_data.get('trade_status')
|
|
if status in ['TRADE_FINISHED', 'TRADE_SUCCESS']:
|
|
self._set_done()
|
|
elif status == 'TRADE_CLOSED':
|
|
self._set_canceled()
|
|
else:
|
|
_logger.info(
|
|
"received data with invalid payment status (%s) for transaction with reference %s",
|
|
status, self.reference,
|
|
)
|
|
self._set_error("Alipay: " + _("received invalid transaction status: %s", status))
|