Victor Feyens
fba6ea5a47
For bugfix purposes, app administration groups have been given to (implied by) the "Settings" group because without those rights, opening/saving the settings crashed. 1) Do not load hidden view content This commit uses the conditional inheritance of views (depending on user groups) to avoid loading unnecessary view & record content client-side. This improves performance for admins without the specific application admin rights, but also fixes the main bugfix problem, caused by the webclient querying name_get for the records in relational fields content. Example: sale_management adds a res.config.settings field to specify the default sale.order.template for the current company. If a 'Settings' user without 'sale.group_sale_manager' opens the settings, he won't see this setting, but if a default template is specified for the current company, the webclient will still request the name_get of this template to the server, because the field was present in the view, only hidden with a groups attribute. With this commit change in sale, the field won't be in the view unless you have the Sale manager group, avoiding the error/traceback/bug. 2) Remove implied application administration groups Do not force the specific application groups on all 'Settings' user, they globally do not need those rights, and if they need it, they can add it to their account themselves. 3) Add a test to make sure settings user are able to manage settings. 4) Enforce 'settings' -> 'access rights' -> 'internal user' groups As the previous test highlighted some 'false positives' because it considered a settings user unable to read `crm.team` and `stock.warehouse` records, we also took the opportunity to enforce the fact that 'Settings' & 'Access rights' users must be internal users. It makes no sense for a portal/public user to have access to the settings, and didn't work anyway. Part-of: odoo/odoo#91909
83 lines
5.7 KiB
XML
83 lines
5.7 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<odoo>
|
|
<record id="res_config_settings_view_form" model="ir.ui.view">
|
|
<field name="name">res.config.settings.view.form.inherit.mass.mailing</field>
|
|
<field name="model">res.config.settings</field>
|
|
<field name="priority" eval="60"/>
|
|
<field name="inherit_id" ref="base.res_config_settings_view_form"/>
|
|
<field name="groups_id" eval="[(4, ref('mass_mailing.group_mass_mailing_user'), 0)]"/>
|
|
<field name="arch" type="xml">
|
|
<xpath expr="//div[hasclass('settings')]" position="inside">
|
|
<div class="app_settings_block" data-string="Email Marketing" string="Email Marketing" data-key="mass_mailing" groups="mass_mailing.group_mass_mailing_user">
|
|
<h2>Email Marketing</h2>
|
|
<div class="row mt16 o_settings_container" name="managa_mail_campaigns_setting_container">
|
|
<div class="col-lg-6 o_setting_box col-12" title="This tool is advised if your marketing campaign is composed of several emails.">
|
|
<div class="o_setting_left_pane" title="This is useful if your marketing campaigns are composed of several emails.">
|
|
<field name="group_mass_mailing_campaign"/>
|
|
</div>
|
|
<div class="o_setting_right_pane">
|
|
<label for="group_mass_mailing_campaign"/>
|
|
<div class="text-muted">
|
|
Manage mass mailing campaigns
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="col-lg-6 o_setting_box col-12" name="dedicated_server_setting_container">
|
|
<div class="o_setting_left_pane" title="Use a specific mail server in priority. Otherwise Odoo relies on the first outgoing mail server available (based on their sequencing) as it does for normal mails.">
|
|
<field name="mass_mailing_outgoing_mail_server"/>
|
|
</div>
|
|
<div class="o_setting_right_pane">
|
|
<label for="mass_mailing_outgoing_mail_server"/>
|
|
<div class="text-muted">
|
|
Use a dedicated server for mailings
|
|
</div>
|
|
<div class="content-group" attrs="{'invisible': [('mass_mailing_outgoing_mail_server', '=', False)]}">
|
|
<div class="mt16">
|
|
<field name="mass_mailing_mail_server_id" options="{'no_create': True, 'no_open': True}"/>
|
|
</div>
|
|
<div class="mt8">
|
|
<button type="action" name="base.action_ir_mail_server_list" string="Configure Email Server" icon="fa-arrow-right" class="oe_link"/>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="col-md-6 o_setting_box col-xs-12" name="allow_blacklist_setting_container">
|
|
<div class="o_setting_left_pane" title="Allow the recipient to manage themselves their state in the blacklist via the unsubscription page.
|
|
If the option is active, the 'Blacklist Me' button is hidden on the unsubscription page.
|
|
The 'come Back' button will always be visible in any case to allow leads and partners to re-subscribe.">
|
|
<field name="show_blacklist_buttons"/>
|
|
</div>
|
|
<div class="o_setting_right_pane">
|
|
<label for="show_blacklist_buttons"/>
|
|
<div class="text-muted">
|
|
Allow recipients to blacklist themselves
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="col-md-6 o_setting_box col-xs-12" name="mass_mailing_reports_setting_container">
|
|
<div class="o_setting_left_pane" title="Send a report to the mailing responsible one day after the mailing has been sent.">
|
|
<field name="mass_mailing_reports"/>
|
|
</div>
|
|
<div class="o_setting_right_pane">
|
|
<label for="mass_mailing_reports"/>
|
|
<div class="text-muted">
|
|
Check how well your mailing is doing a day after it has been sent
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</xpath>
|
|
</field>
|
|
</record>
|
|
|
|
<record id="action_mass_mailing_configuration" model="ir.actions.act_window">
|
|
<field name="name">Settings</field>
|
|
<field name="type">ir.actions.act_window</field>
|
|
<field name="res_model">res.config.settings</field>
|
|
<field name="view_mode">form</field>
|
|
<field name="target">inline</field>
|
|
<field name="context">{'module' : 'mass_mailing', 'bin_size': False}</field>
|
|
</record>
|
|
</odoo>
|