Brice bib Bartoletti
b06ee24be8
This commit aims to allow assigning tags to the taxes created by the OSS feature by providing the xml_id of their report.line in the eu_tag_map.py file. Before this commit: In l10n_be, the taxes created by OSS (l10n_eu_services) didn't set the tag +47 on invoice_repartition_lines nor +49 on refund_repartition_lines. This make the VAT report for Belgium wrong. After this commit: Taxes created by OSS for a company using the belgian CoA will get their tags set properly and thus will the taxes impact the belgian tax report correctly. task: 2770182 ticket: 2768622 Community-PR: https://github.com/odoo/odoo/pull/85607 Design choices: This fix is currently solving the issue for l10n_be but we have no doubt that it will be raised for other EU countries too. In order to provide the tags, we decided to be consistent with what as been done regarding the tax mapping. Thus we decided to create and maintain a simple mapping file and to test it. several other methods were explored: - create a global variable and update it from all localization modules. This method would work but is ugly and error prone. - create a templating method and override it from localization modules. The problem is where to set the root of the template method? The naïve solution would be to create a bridge module between l10n_eu_services and l10n_be but that would lead to an explosion in the number of bridge modules which we don't want. In order to keep things simple and generic, we could put the template method directly into the account module. But it is kind of ugly because account shouldn't know anything about the oss feature and it would encourage such a leaky design to happen again in the future. closes odoo/odoo#86314 X-original-commit: 7dcc2ae4665d2d7b577ed10160691775b86a848f Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: Brice Bartoletti <bib@odoo.com>
78 lines
3.7 KiB
Python
78 lines
3.7 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
from odoo.addons.l10n_eu_oss.models.eu_tag_map import EU_TAG_MAP
|
|
from odoo.addons.account.tests.common import AccountTestInvoicingCommon
|
|
from odoo.tests import tagged
|
|
|
|
|
|
@tagged('post_install', 'post_install_l10n', '-at_install')
|
|
class TestOSSBelgium(AccountTestInvoicingCommon):
|
|
|
|
@classmethod
|
|
def setUpClass(cls, chart_template_ref='l10n_be.l10nbe_chart_template'):
|
|
try:
|
|
super().setUpClass(chart_template_ref=chart_template_ref)
|
|
except ValueError as e:
|
|
if e.args[0] == "External ID not found in the system: l10n_be.l10nbe_chart_template":
|
|
cls.skipTest(cls, reason="Belgian CoA is required for this testSuite but l10n_be isn't installed")
|
|
else:
|
|
raise e
|
|
cls.company_data['company'].country_id = cls.env.ref('base.be')
|
|
cls.company_data['company']._map_eu_taxes()
|
|
|
|
def test_country_tag_from_belgium(self):
|
|
# get an eu country which isn't the current one:
|
|
another_eu_country_code = (self.env.ref('base.europe').country_ids - self.company_data['company'].country_id)[0].code
|
|
tax_oss = self.env['account.tax'].search([('name', 'ilike', f'%{another_eu_country_code}%')], limit=1)
|
|
|
|
for doc_type, report_line_xml_id in (
|
|
("invoice", "l10n_be.tax_report_line_47"),
|
|
("refund", "l10n_be.tax_report_line_49"),
|
|
):
|
|
with self.subTest(doc_type=doc_type, report_line_xml_id=report_line_xml_id):
|
|
oss_tag_id = tax_oss[f"{doc_type}_repartition_line_ids"]\
|
|
.filtered(lambda x: x.repartition_type == 'base')\
|
|
.tag_ids
|
|
|
|
expected_tag_id = self.env.ref(report_line_xml_id)\
|
|
.tag_ids\
|
|
.filtered(lambda t: not t.tax_negate)
|
|
|
|
self.assertIn(expected_tag_id, oss_tag_id, f"{doc_type} tag from Belgian CoA not correctly linked")
|
|
|
|
|
|
@tagged('post_install', 'post_install_l10n', '-at_install')
|
|
class TestOSSUSA(AccountTestInvoicingCommon):
|
|
|
|
@classmethod
|
|
def setUpClass(cls, chart_template_ref=None):
|
|
super().setUpClass(chart_template_ref=chart_template_ref)
|
|
cls.company_data['company'].country_id = cls.env.ref('base.us')
|
|
cls.company_data['company']._map_eu_taxes()
|
|
|
|
def test_no_oss_tax(self):
|
|
# get an eu country which isn't the current one:
|
|
another_eu_country_code = (self.env.ref('base.europe').country_ids - self.company_data['company'].country_id)[0].code
|
|
tax_oss = self.env['account.tax'].search([('name', 'ilike', f'%{another_eu_country_code}%')], limit=1)
|
|
|
|
self.assertFalse(len(tax_oss), "OSS tax shouldn't be instanced on a US company")
|
|
|
|
|
|
|
|
@tagged('post_install', 'post_install_l10n', '-at_install')
|
|
class TestOSSMap(AccountTestInvoicingCommon):
|
|
|
|
def test_oss_eu_tag_map(self):
|
|
""" Checks that the xml_id referenced in the map are correct.
|
|
In case of failure display the couple (chart_template_xml_id, tax_report_line_xml_id).
|
|
The test doesn't fail for unreferenced char_template or unreferenced tax_report_line.
|
|
"""
|
|
chart_templates = self.env['account.chart.template'].search([])
|
|
for chart_template in chart_templates:
|
|
[chart_template_xml_id] = chart_template.get_external_id().values()
|
|
oss_tags = EU_TAG_MAP.get(chart_template_xml_id, {})
|
|
for tax_report_line_xml_id in filter(lambda d: d, oss_tags.values()):
|
|
with self.subTest(chart_template_xml_id=chart_template_xml_id, tax_report_line_xml_id=tax_report_line_xml_id):
|
|
tag = self.env.ref(tax_report_line_xml_id, raise_if_not_found=False)
|
|
self.assertIsNotNone(tag, f"The following xml_id is incorrect in EU_TAG_MAP.py:{tax_report_line_xml_id}")
|