Philippe Wauthy
ca5ee8e2ae
PURPOSE
When we made the b2b on Time Off, we designed the allocation settings to be like this :
1. Allow Allocation : NO (stop here)
2. If YES
Can the Employee requests Allocation himself ?
2.1. NO (stop here, cause the HR will create the allocation and it will be automatically accepted)
2.2. If YES
Who will approve the Allocation made by the Employee ?
2.2.1. Nobody, it's directly approved
2.2.2. The time off officer must approve
2.2.3. It's SET by the time off officer.
In the day to day live, the case 2.2.3. never happen. It's the same settings as 2.1. "the employee will not make an allocaiton request, it will be the HR officer"
In fact, nobody understand what is behind that settings and the technical code behind it seems obsolete.
SPECIFICATION
1. Remove the "set by time off officer"
2. If Employee Requests is set on "Not Allowed", don't display Approval : https://tinyurl.com/yxwwql83 if an allocation is created, it will be done by the HR officer and automatically approved.
task-2705150
closes odoo/odoo#81914
Related: odoo/upgrade#3247
Related: odoo/enterprise#23105
Signed-off-by: Kevin Baptiste <kba@odoo.com>
217 lines
8.8 KiB
Python
217 lines
8.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import tests
|
|
from odoo.addons.hr_holidays.tests.common import TestHrHolidaysCommon
|
|
from odoo.exceptions import AccessError, UserError
|
|
import time
|
|
|
|
|
|
@tests.tagged('access_rights', 'post_install', '-at_install')
|
|
class TestAllocationRights(TestHrHolidaysCommon):
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super().setUpClass()
|
|
cls.rd_dept.manager_id = False
|
|
cls.hr_dept.manager_id = False
|
|
cls.employee_emp.parent_id = False
|
|
cls.employee_emp.leave_manager_id = False
|
|
|
|
cls.lt_no_allocation = cls.env['hr.leave.type'].create({
|
|
'name': 'Validation = HR',
|
|
'allocation_validation_type': 'officer',
|
|
'requires_allocation': 'no',
|
|
'employee_requests': 'yes',
|
|
})
|
|
|
|
cls.lt_validation_manager = cls.env['hr.leave.type'].create({
|
|
'name': 'Validation = manager',
|
|
'allocation_validation_type': 'officer',
|
|
'requires_allocation': 'yes',
|
|
'employee_requests': 'yes',
|
|
})
|
|
|
|
cls.lt_allocation_no_validation = cls.env['hr.leave.type'].create({
|
|
'name': 'Validation = user',
|
|
'allocation_validation_type': 'no',
|
|
'requires_allocation': 'yes',
|
|
'employee_requests': 'yes',
|
|
})
|
|
|
|
def request_allocation(self, user, values={}):
|
|
values = dict(values, **{
|
|
'name': 'Allocation',
|
|
'number_of_days': 1,
|
|
'date_from': time.strftime('%Y-01-01'),
|
|
'date_to': time.strftime('%Y-12-31'),
|
|
})
|
|
return self.env['hr.leave.allocation'].with_user(user).create(values)
|
|
|
|
|
|
class TestAccessRightsSimpleUser(TestAllocationRights):
|
|
|
|
def test_simple_user_request_allocation(self):
|
|
""" A simple user can request an allocation but not approve it """
|
|
values = {
|
|
'employee_id': self.employee_emp.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_employee.id, values)
|
|
with self.assertRaises(UserError):
|
|
allocation.action_validate()
|
|
|
|
def test_simple_user_request_allocation_no_validation(self):
|
|
""" A simple user can request and automatically validate an allocation with no validation """
|
|
values = {
|
|
'employee_id': self.employee_emp.id,
|
|
'holiday_status_id': self.lt_allocation_no_validation.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_employee.id, values)
|
|
self.assertEqual(allocation.state, 'validate', "It should be validated")
|
|
|
|
def test_simple_user_request_allocation_no_validation_other(self):
|
|
""" A simple user cannot request an other user's allocation with no validation """
|
|
values = {
|
|
'employee_id': self.employee_hruser.id,
|
|
'holiday_status_id': self.lt_allocation_no_validation.id,
|
|
}
|
|
with self.assertRaises(AccessError):
|
|
self.request_allocation(self.user_employee.id, values)
|
|
|
|
def test_simple_user_reset_to_draft(self):
|
|
""" A simple user can reset to draft only his own allocation """
|
|
values = {
|
|
'employee_id': self.employee_emp.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_employee.id, values)
|
|
self.assertEqual(allocation.state, 'draft')
|
|
allocation.action_confirm()
|
|
self.assertEqual(allocation.state, 'confirm', "It should be confirmed")
|
|
allocation.action_draft()
|
|
self.assertEqual(allocation.state, 'draft', "It should have been reset to draft")
|
|
|
|
|
|
class TestAccessRightsEmployeeManager(TestAllocationRights):
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super().setUpClass()
|
|
cls.managed_employee = cls.env['hr.employee'].create({
|
|
'name': 'Jolly Jumper',
|
|
'leave_manager_id': cls.user_employee.id,
|
|
})
|
|
|
|
def test_manager_request_allocation_other(self):
|
|
""" A manager cannot request and approve an allocation for employees he doesn't manage """
|
|
values = {
|
|
'employee_id': self.employee_hruser.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
with self.assertRaises(AccessError):
|
|
self.request_allocation(self.user_employee.id, values) # user is not the employee's manager
|
|
|
|
def test_manager_approve_request_allocation(self):
|
|
""" A manager can request and approve an allocation for managed employees """
|
|
values = {
|
|
'employee_id': self.managed_employee.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_employee.id, values)
|
|
allocation.action_confirm()
|
|
allocation.action_validate()
|
|
self.assertEqual(allocation.state, 'validate', "The allocation should be validated")
|
|
|
|
def test_manager_refuse_request_allocation(self):
|
|
""" A manager can request and refuse an allocation for managed employees """
|
|
values = {
|
|
'employee_id': self.managed_employee.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_employee.id, values)
|
|
allocation.action_confirm()
|
|
allocation.action_refuse()
|
|
self.assertEqual(allocation.state, 'refuse', "The allocation should be validated")
|
|
|
|
def test_manager_batch_allocation(self):
|
|
""" A manager cannot create batch allocation """
|
|
values = {
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
'holiday_type': 'company',
|
|
'mode_company_id': self.user_employee.company_id.id,
|
|
}
|
|
with self.assertRaises(AccessError):
|
|
self.request_allocation(self.user_employee.id, values)
|
|
|
|
def test_manager_approve_own(self):
|
|
""" A manager cannot approve his own allocation """
|
|
values = {
|
|
'employee_id': self.user_employee.employee_id.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_employee.id, values)
|
|
with self.assertRaises(UserError):
|
|
allocation.action_validate()
|
|
|
|
class TestAccessRightsHolidayUser(TestAllocationRights):
|
|
|
|
def test_holiday_user_request_allocation(self):
|
|
""" A holiday user can request and approve an allocation for any employee """
|
|
values = {
|
|
'employee_id': self.employee_emp.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_hruser.id, values)
|
|
allocation.action_confirm()
|
|
allocation.action_validate()
|
|
self.assertEqual(allocation.state, 'validate', "It should have been validated")
|
|
|
|
def test_holiday_user_batch_allocation(self):
|
|
""" A holiday user cannot create a batch allocation """
|
|
values = {
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
'holiday_type': 'company',
|
|
'mode_company_id': self.user_employee.company_id.id,
|
|
}
|
|
with self.assertRaises(AccessError):
|
|
self.request_allocation(self.user_hruser.id, values)
|
|
|
|
def test_holiday_user_cannot_approve_own(self):
|
|
""" A holiday user cannot approve his own allocation """
|
|
values = {
|
|
'employee_id': self.employee_hruser.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_hruser.id, values)
|
|
allocation.action_confirm()
|
|
with self.assertRaises(UserError):
|
|
allocation.action_validate()
|
|
|
|
|
|
class TestAccessRightsHolidayManager(TestAllocationRights):
|
|
|
|
def test_holiday_manager_can_approve_own(self):
|
|
""" A holiday manager can approve his own allocation """
|
|
values = {
|
|
'employee_id': self.employee_hrmanager.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_hrmanager.id, values)
|
|
allocation.action_confirm()
|
|
allocation.action_validate()
|
|
self.assertEqual(allocation.state, 'validate', "It should have been validated")
|
|
|
|
def test_holiday_manager_refuse_validated(self):
|
|
""" A holiday manager can refuse a validated allocation """
|
|
values = {
|
|
'employee_id': self.employee_emp.id,
|
|
'holiday_status_id': self.lt_validation_manager.id,
|
|
}
|
|
allocation = self.request_allocation(self.user_hrmanager.id, values)
|
|
allocation.action_confirm()
|
|
allocation.action_validate()
|
|
self.assertEqual(allocation.state, 'validate', "It should have been validated")
|
|
allocation.action_refuse()
|
|
self.assertEqual(allocation.state, 'refuse', "It should have been refused")
|