Goffin Simon
0fd773a486
Unify and refactor exception handling in framework and addons. The generic `except_osv` is now deprecated, and replaced by more specialized exception subtypes: - `UserError` (renamed from Warning, as it conflicts with the built-in `Warning`) raised when a non-technical error occurs during a business operation. It could be a missing information in the data provided by the user, or a misconfiguration. - `AccessError`: raised when any operation is denied because the user conducting it does not have the required access rights. - `AccessDenied`: raised when an operation that requires authenticated access is attempted via an unauthenticated request. - `MissingError`: raised when an operation is attempted on a record that does not exist. - `ValidationError`: raised when an operation violates a SQL or Python constraint. - All other exceptions are internal errors due to a system problem or bug, and raised untouched to the client-side, which should display a traceback. All exceptions take a single message argument. The `test_exceptions` module has been updated to showcase both new and old (deprecated) exceptions. A great many old `except_osv` had a useless title with "Error!" or "Warning", those have been removed, as this is handled by the client-side widget that displays the messages. This commit introduces a more consistent policy for logging errors and warnings: - All messages that do not require administrator attention should be logged at INFO level or lower. This includes all errors that are notified to the user in a friendly manner, even for access right problems or validation errors during business operations. - All messages that indicate a likely misconfiguration or malicious use by the users should be logged at WARNING level, as they typically require administrator attention. - All other unhandled internal errors cannot typically be handled by the user and should be logged at ERROR or higher level, as they require immediate administrator attention.
181 lines
7.5 KiB
Python
181 lines
7.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
from openerp.addons.website_forum.tests.common import KARMA, TestForumCommon
|
|
from openerp.addons.website_forum.models.forum import KarmaError
|
|
from openerp.exceptions import UserError, AccessError
|
|
from openerp.tools import mute_logger
|
|
|
|
|
|
class TestForum(TestForumCommon):
|
|
|
|
@mute_logger('openerp.addons.base.ir.ir_model', 'openerp.models')
|
|
def test_ask(self):
|
|
Post = self.env['forum.post']
|
|
|
|
# Public user asks a question: not allowed
|
|
with self.assertRaises(AccessError):
|
|
Post.sudo(self.user_public).create({
|
|
'name': " Question ?",
|
|
'forum_id': self.forum.id,
|
|
})
|
|
|
|
# Portal user asks a question with tags: not allowed, unsufficient karma
|
|
with self.assertRaises(KarmaError):
|
|
Post.sudo(self.user_portal).create({
|
|
'name': " Q_0",
|
|
'forum_id': self.forum.id,
|
|
'tag_ids': [(0, 0, {'name': 'Tag0', 'forum_id': self.forum.id})]
|
|
})
|
|
|
|
# Portal user asks a question with tags: ok if enough karma
|
|
self.user_portal.karma = KARMA['ask']
|
|
Post.sudo(self.user_portal).create({
|
|
'name': " Q0",
|
|
'forum_id': self.forum.id,
|
|
'tag_ids': [(0, 0, {'name': 'Tag0', 'forum_id': self.forum.id})]
|
|
})
|
|
self.assertEqual(self.user_portal.karma, KARMA['ask'] + KARMA['gen_que_new'], 'website_forum: wrong karma generation when asking question')
|
|
|
|
@mute_logger('openerp.addons.base.ir.ir_model', 'openerp.models')
|
|
def test_answer(self):
|
|
Post = self.env['forum.post']
|
|
|
|
# Answers its own question: not allowed, unsufficient karma
|
|
with self.assertRaises(KarmaError):
|
|
Post.sudo(self.user_employee).create({
|
|
'name': " A0",
|
|
'forum_id': self.forum.id,
|
|
'parent_id': self.post.id,
|
|
})
|
|
|
|
# Answers on question: ok if enough karma
|
|
self.user_employee.karma = KARMA['ans']
|
|
Post.sudo(self.user_employee).create({
|
|
'name': " A0",
|
|
'forum_id': self.forum.id,
|
|
'parent_id': self.post.id,
|
|
})
|
|
self.assertEqual(self.user_employee.karma, KARMA['ans'], 'website_forum: wrong karma generation when answering question')
|
|
|
|
@mute_logger('openerp.addons.base.ir.ir_model', 'openerp.models')
|
|
def test_vote_crash(self):
|
|
Post = self.env['forum.post']
|
|
self.user_employee.karma = KARMA['ans']
|
|
emp_answer = Post.sudo(self.user_employee).create({
|
|
'name': 'TestAnswer',
|
|
'forum_id': self.forum.id,
|
|
'parent_id': self.post.id})
|
|
|
|
# upvote its own post
|
|
with self.assertRaises(UserError):
|
|
emp_answer.vote(upvote=True)
|
|
|
|
# not enough karma
|
|
with self.assertRaises(KarmaError):
|
|
self.post.sudo(self.user_portal).vote(upvote=True)
|
|
|
|
def test_vote(self):
|
|
self.post.create_uid.karma = KARMA['ask']
|
|
self.user_portal.karma = KARMA['upv']
|
|
self.post.sudo(self.user_portal).vote(upvote=True)
|
|
self.assertEqual(self.post.create_uid.karma, KARMA['ask'] + KARMA['gen_que_upv'], 'website_forum: wrong karma generation of upvoted question author')
|
|
|
|
@mute_logger('openerp.addons.base.ir.ir_model', 'openerp.models')
|
|
def test_downvote_crash(self):
|
|
Post = self.env['forum.post']
|
|
self.user_employee.karma = KARMA['ans']
|
|
emp_answer = Post.sudo(self.user_employee).create({
|
|
'name': 'TestAnswer',
|
|
'forum_id': self.forum.id,
|
|
'parent_id': self.post.id})
|
|
|
|
# downvote its own post
|
|
with self.assertRaises(UserError):
|
|
emp_answer.vote(upvote=False)
|
|
|
|
# not enough karma
|
|
with self.assertRaises(KarmaError):
|
|
self.post.sudo(self.user_portal).vote(upvote=False)
|
|
|
|
def test_downvote(self):
|
|
self.post.create_uid.karma = 50
|
|
self.user_portal.karma = KARMA['dwv']
|
|
self.post.sudo(self.user_portal).vote(upvote=False)
|
|
self.assertEqual(self.post.create_uid.karma, 50 + KARMA['gen_que_dwv'], 'website_forum: wrong karma generation of downvoted question author')
|
|
|
|
def test_comment_crash(self):
|
|
with self.assertRaises(KarmaError):
|
|
self.post.sudo(self.user_portal).message_post(body='Should crash', type='comment')
|
|
|
|
def test_comment(self):
|
|
self.post.sudo(self.user_employee).message_post(body='Test0', type='notification')
|
|
self.user_employee.karma = KARMA['com_all']
|
|
self.post.sudo(self.user_employee).message_post(body='Test1', type='comment')
|
|
self.assertEqual(len(self.post.message_ids), 4, 'website_forum: wrong behavior of message_post')
|
|
|
|
def test_convert_answer_to_comment_crash(self):
|
|
Post = self.env['forum.post']
|
|
|
|
# converting a question does nothing
|
|
msg_ids = self.post.sudo(self.user_portal).convert_answer_to_comment()
|
|
self.assertEqual(msg_ids[0], False, 'website_forum: question to comment conversion failed')
|
|
self.assertEqual(Post.search([('name', '=', 'TestQuestion')])[0].forum_id.name, 'TestForum', 'website_forum: question to comment conversion failed')
|
|
|
|
with self.assertRaises(KarmaError):
|
|
self.answer.sudo(self.user_portal).convert_answer_to_comment()
|
|
|
|
def test_convert_answer_to_comment(self):
|
|
self.user_portal.karma = KARMA['com_conv_all']
|
|
post_author = self.answer.create_uid.partner_id
|
|
msg_ids = self.answer.sudo(self.user_portal).convert_answer_to_comment()
|
|
self.assertEqual(len(msg_ids), 1, 'website_forum: wrong answer to comment conversion')
|
|
msg = self.env['mail.message'].browse(msg_ids[0])
|
|
self.assertEqual(msg.author_id, post_author, 'website_forum: wrong answer to comment conversion')
|
|
self.assertIn('I am an anteater', msg.body, 'website_forum: wrong answer to comment conversion')
|
|
|
|
def test_edit_post_crash(self):
|
|
with self.assertRaises(KarmaError):
|
|
self.post.sudo(self.user_portal).write({'name': 'I am not your father.'})
|
|
|
|
def test_edit_post(self):
|
|
self.post.create_uid.karma = KARMA['edit_own']
|
|
self.post.write({'name': 'Actually I am your dog.'})
|
|
self.user_portal.karma = KARMA['edit_all']
|
|
self.post.sudo(self.user_portal).write({'name': 'Actually I am your cat.'})
|
|
|
|
def test_close_post_crash(self):
|
|
with self.assertRaises(KarmaError):
|
|
self.post.sudo(self.user_portal).close(None)
|
|
|
|
def test_close_post_own(self):
|
|
self.post.create_uid.karma = KARMA['close_own']
|
|
self.post.close(None)
|
|
|
|
def test_close_post_all(self):
|
|
self.user_portal.karma = KARMA['close_all']
|
|
self.post.sudo(self.user_portal).close(None)
|
|
|
|
def test_deactivate_post_crash(self):
|
|
with self.assertRaises(KarmaError):
|
|
self.post.sudo(self.user_portal).write({'active': False})
|
|
|
|
def test_deactivate_post_own(self):
|
|
self.post.create_uid.karma = KARMA['unlink_own']
|
|
self.post.write({'active': False})
|
|
|
|
def test_deactivate_post_all(self):
|
|
self.user_portal.karma = KARMA['unlink_all']
|
|
self.post.sudo(self.user_portal).write({'active': False})
|
|
|
|
def test_unlink_post_crash(self):
|
|
with self.assertRaises(KarmaError):
|
|
self.post.sudo(self.user_portal).unlink()
|
|
|
|
def test_unlink_post_own(self):
|
|
self.post.create_uid.karma = KARMA['unlink_own']
|
|
self.post.unlink()
|
|
|
|
def test_unlink_post_all(self):
|
|
self.user_portal.karma = KARMA['unlink_all']
|
|
self.post.sudo(self.user_portal).unlink()
|