Goffin Simon
0fd773a486
Unify and refactor exception handling in framework and addons. The generic `except_osv` is now deprecated, and replaced by more specialized exception subtypes: - `UserError` (renamed from Warning, as it conflicts with the built-in `Warning`) raised when a non-technical error occurs during a business operation. It could be a missing information in the data provided by the user, or a misconfiguration. - `AccessError`: raised when any operation is denied because the user conducting it does not have the required access rights. - `AccessDenied`: raised when an operation that requires authenticated access is attempted via an unauthenticated request. - `MissingError`: raised when an operation is attempted on a record that does not exist. - `ValidationError`: raised when an operation violates a SQL or Python constraint. - All other exceptions are internal errors due to a system problem or bug, and raised untouched to the client-side, which should display a traceback. All exceptions take a single message argument. The `test_exceptions` module has been updated to showcase both new and old (deprecated) exceptions. A great many old `except_osv` had a useless title with "Error!" or "Warning", those have been removed, as this is handled by the client-side widget that displays the messages. This commit introduces a more consistent policy for logging errors and warnings: - All messages that do not require administrator attention should be logged at INFO level or lower. This includes all errors that are notified to the user in a friendly manner, even for access right problems or validation errors during business operations. - All messages that indicate a likely misconfiguration or malicious use by the users should be logged at WARNING level, as they typically require administrator attention. - All other unhandled internal errors cannot typically be handled by the user and should be logged at ERROR or higher level, as they require immediate administrator attention.
87 lines
3.7 KiB
Python
87 lines
3.7 KiB
Python
# -*- coding: utf-'8' "-*-"
|
|
|
|
from openerp.addons.payment.models.payment_acquirer import ValidationError
|
|
from openerp.osv import osv
|
|
from openerp.tools.float_utils import float_compare
|
|
from openerp.tools.translate import _
|
|
|
|
import logging
|
|
import pprint
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
class TransferPaymentAcquirer(osv.Model):
|
|
_inherit = 'payment.acquirer'
|
|
|
|
def _get_providers(self, cr, uid, context=None):
|
|
providers = super(TransferPaymentAcquirer, self)._get_providers(cr, uid, context=context)
|
|
providers.append(['transfer', 'Wire Transfer'])
|
|
return providers
|
|
|
|
def transfer_get_form_action_url(self, cr, uid, id, context=None):
|
|
return '/payment/transfer/feedback'
|
|
|
|
def _format_transfer_data(self, cr, uid, context=None):
|
|
bank_ids = [bank.id for bank in self.pool['res.users'].browse(cr, uid, uid, context=context).company_id.bank_ids]
|
|
# filter only bank accounts marked as visible
|
|
bank_ids = self.pool['res.partner.bank'].search(cr, uid, [('id', 'in', bank_ids), ('footer', '=', True)], context=context)
|
|
accounts = self.pool['res.partner.bank'].name_get(cr, uid, bank_ids, context=context)
|
|
bank_title = _('Bank Accounts') if len(accounts) > 1 else _('Bank Account')
|
|
bank_accounts = ''.join(['<ul>'] + ['<li>%s</li>' % name for id, name in accounts] + ['</ul>'])
|
|
post_msg = '''<div>
|
|
<h3>Please use the following transfer details</h3>
|
|
<h4>%(bank_title)s</h4>
|
|
%(bank_accounts)s
|
|
<h4>Communication</h4>
|
|
<p>Please use the order name as communication reference.</p>
|
|
</div>''' % {
|
|
'bank_title': bank_title,
|
|
'bank_accounts': bank_accounts,
|
|
}
|
|
return post_msg
|
|
|
|
def create(self, cr, uid, values, context=None):
|
|
""" Hook in create to create a default post_msg. This is done in create
|
|
to have access to the name and other creation values. If no post_msg
|
|
or a void post_msg is given at creation, generate a default one. """
|
|
if values.get('provider') == 'transfer' and not values.get('post_msg'):
|
|
values['post_msg'] = self._format_transfer_data(cr, uid, context=context)
|
|
return super(TransferPaymentAcquirer, self).create(cr, uid, values, context=context)
|
|
|
|
|
|
class TransferPaymentTransaction(osv.Model):
|
|
_inherit = 'payment.transaction'
|
|
|
|
def _transfer_form_get_tx_from_data(self, cr, uid, data, context=None):
|
|
reference, amount, currency_name = data.get('reference'), data.get('amount'), data.get('currency_name')
|
|
tx_ids = self.search(
|
|
cr, uid, [
|
|
('reference', '=', reference),
|
|
], context=context)
|
|
|
|
if not tx_ids or len(tx_ids) > 1:
|
|
error_msg = _('received data for reference %s') % (pprint.pformat(reference))
|
|
if not tx_ids:
|
|
error_msg += _('; no order found')
|
|
else:
|
|
error_msg += _('; multiple order found')
|
|
_logger.info(error_msg)
|
|
raise ValidationError(error_msg)
|
|
|
|
return self.browse(cr, uid, tx_ids[0], context=context)
|
|
|
|
def _transfer_form_get_invalid_parameters(self, cr, uid, tx, data, context=None):
|
|
invalid_parameters = []
|
|
|
|
if float_compare(float(data.get('amount', '0.0')), tx.amount, 2) != 0:
|
|
invalid_parameters.append(('amount', data.get('amount'), '%.2f' % tx.amount))
|
|
if data.get('currency') != tx.currency_id.name:
|
|
invalid_parameters.append(('currency', data.get('currency'), tx.currency_id.name))
|
|
|
|
return invalid_parameters
|
|
|
|
def _transfer_form_validate(self, cr, uid, tx, data, context=None):
|
|
_logger.info('Validated transfer payment for tx %s: set as pending' % (tx.reference))
|
|
return tx.write({'state': 'pending'})
|