Goffin Simon
0fd773a486
Unify and refactor exception handling in framework and addons. The generic `except_osv` is now deprecated, and replaced by more specialized exception subtypes: - `UserError` (renamed from Warning, as it conflicts with the built-in `Warning`) raised when a non-technical error occurs during a business operation. It could be a missing information in the data provided by the user, or a misconfiguration. - `AccessError`: raised when any operation is denied because the user conducting it does not have the required access rights. - `AccessDenied`: raised when an operation that requires authenticated access is attempted via an unauthenticated request. - `MissingError`: raised when an operation is attempted on a record that does not exist. - `ValidationError`: raised when an operation violates a SQL or Python constraint. - All other exceptions are internal errors due to a system problem or bug, and raised untouched to the client-side, which should display a traceback. All exceptions take a single message argument. The `test_exceptions` module has been updated to showcase both new and old (deprecated) exceptions. A great many old `except_osv` had a useless title with "Error!" or "Warning", those have been removed, as this is handled by the client-side widget that displays the messages. This commit introduces a more consistent policy for logging errors and warnings: - All messages that do not require administrator attention should be logged at INFO level or lower. This includes all errors that are notified to the user in a friendly manner, even for access right problems or validation errors during business operations. - All messages that indicate a likely misconfiguration or malicious use by the users should be logged at WARNING level, as they typically require administrator attention. - All other unhandled internal errors cannot typically be handled by the user and should be logged at ERROR or higher level, as they require immediate administrator attention.
83 lines
3.2 KiB
Python
83 lines
3.2 KiB
Python
from openerp.osv import fields, osv
|
|
import openerp.addons.decimal_precision as dp
|
|
from openerp.tools.translate import _
|
|
from openerp.exceptions import UserError
|
|
|
|
class CashBox(osv.osv_memory):
|
|
_register = False
|
|
_columns = {
|
|
'name' : fields.char('Reason', required=True),
|
|
# Attention, we don't set a domain, because there is a journal_type key
|
|
# in the context of the action
|
|
'amount' : fields.float('Amount',
|
|
digits_compute = dp.get_precision('Account'),
|
|
required=True),
|
|
}
|
|
|
|
def run(self, cr, uid, ids, context=None):
|
|
if not context:
|
|
context = dict()
|
|
|
|
active_model = context.get('active_model', False) or False
|
|
active_ids = context.get('active_ids', []) or []
|
|
|
|
records = self.pool[active_model].browse(cr, uid, active_ids, context=context)
|
|
|
|
return self._run(cr, uid, ids, records, context=context)
|
|
|
|
def _run(self, cr, uid, ids, records, context=None):
|
|
for box in self.browse(cr, uid, ids, context=context):
|
|
for record in records:
|
|
if not record.journal_id:
|
|
raise UserError(_("Please check that the field 'Journal' is set on the Bank Statement"))
|
|
|
|
if not record.journal_id.internal_account_id:
|
|
raise UserError(_("Please check that the field 'Internal Transfers Account' is set on the payment method '%s'.") % (record.journal_id.name,))
|
|
|
|
self._create_bank_statement_line(cr, uid, box, record, context=context)
|
|
|
|
return {}
|
|
|
|
def _create_bank_statement_line(self, cr, uid, box, record, context=None):
|
|
values = self._compute_values_for_statement_line(cr, uid, box, record, context=context)
|
|
return self.pool.get('account.bank.statement.line').create(cr, uid, values, context=context)
|
|
|
|
|
|
class CashBoxIn(CashBox):
|
|
_name = 'cash.box.in'
|
|
|
|
_columns = CashBox._columns.copy()
|
|
_columns.update({
|
|
'ref': fields.char('Reference'),
|
|
})
|
|
|
|
def _compute_values_for_statement_line(self, cr, uid, box, record, context=None):
|
|
if not record.journal_id.internal_account_id.id:
|
|
raise UserError(_("You should have defined an 'Internal Transfer Account' in your cash register's journal!"))
|
|
return {
|
|
'statement_id': record.id,
|
|
'journal_id': record.journal_id.id,
|
|
'amount': box.amount or 0.0,
|
|
'account_id': record.journal_id.internal_account_id.id,
|
|
'ref': '%s' % (box.ref or ''),
|
|
'name': box.name,
|
|
}
|
|
|
|
|
|
class CashBoxOut(CashBox):
|
|
_name = 'cash.box.out'
|
|
|
|
_columns = CashBox._columns.copy()
|
|
|
|
def _compute_values_for_statement_line(self, cr, uid, box, record, context=None):
|
|
if not record.journal_id.internal_account_id.id:
|
|
raise UserError(_("You should have defined an 'Internal Transfer Account' in your cash register's journal!"))
|
|
amount = box.amount or 0.0
|
|
return {
|
|
'statement_id': record.id,
|
|
'journal_id': record.journal_id.id,
|
|
'amount': -amount if amount > 0.0 else amount,
|
|
'account_id': record.journal_id.internal_account_id.id,
|
|
'name': box.name,
|
|
}
|