Goffin Simon
0fd773a486
Unify and refactor exception handling in framework and addons. The generic `except_osv` is now deprecated, and replaced by more specialized exception subtypes: - `UserError` (renamed from Warning, as it conflicts with the built-in `Warning`) raised when a non-technical error occurs during a business operation. It could be a missing information in the data provided by the user, or a misconfiguration. - `AccessError`: raised when any operation is denied because the user conducting it does not have the required access rights. - `AccessDenied`: raised when an operation that requires authenticated access is attempted via an unauthenticated request. - `MissingError`: raised when an operation is attempted on a record that does not exist. - `ValidationError`: raised when an operation violates a SQL or Python constraint. - All other exceptions are internal errors due to a system problem or bug, and raised untouched to the client-side, which should display a traceback. All exceptions take a single message argument. The `test_exceptions` module has been updated to showcase both new and old (deprecated) exceptions. A great many old `except_osv` had a useless title with "Error!" or "Warning", those have been removed, as this is handled by the client-side widget that displays the messages. This commit introduces a more consistent policy for logging errors and warnings: - All messages that do not require administrator attention should be logged at INFO level or lower. This includes all errors that are notified to the user in a friendly manner, even for access right problems or validation errors during business operations. - All messages that indicate a likely misconfiguration or malicious use by the users should be logged at WARNING level, as they typically require administrator attention. - All other unhandled internal errors cannot typically be handled by the user and should be logged at ERROR or higher level, as they require immediate administrator attention.
73 lines
3.5 KiB
Python
73 lines
3.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
##############################################################################
|
|
#
|
|
# OpenERP, Open Source Management Solution
|
|
# Copyright (C) 2004-2010 Tiny SPRL (<http://tiny.be>).
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
# License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU Affero General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Affero General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
##############################################################################
|
|
|
|
from openerp.osv import fields, osv
|
|
from openerp.tools.translate import _
|
|
from openerp.exceptions import UserError
|
|
|
|
class product_category(osv.osv):
|
|
_inherit = "product.category"
|
|
_columns = {
|
|
'property_account_income_categ': fields.property(
|
|
type='many2one',
|
|
relation='account.account',
|
|
string="Income Account",
|
|
help="This account will be used for invoices to value sales."),
|
|
'property_account_expense_categ': fields.property(
|
|
type='many2one',
|
|
relation='account.account',
|
|
string="Expense Account",
|
|
help="This account will be used for invoices to value expenses."),
|
|
}
|
|
|
|
#----------------------------------------------------------
|
|
# Products
|
|
#----------------------------------------------------------
|
|
|
|
class product_template(osv.osv):
|
|
_inherit = "product.template"
|
|
_columns = {
|
|
'taxes_id': fields.many2many('account.tax', 'product_taxes_rel',
|
|
'prod_id', 'tax_id', 'Customer Taxes',
|
|
domain=[('parent_id','=',False),('type_tax_use','in',['sale','all'])]),
|
|
'supplier_taxes_id': fields.many2many('account.tax',
|
|
'product_supplier_taxes_rel', 'prod_id', 'tax_id',
|
|
'Supplier Taxes', domain=[('parent_id', '=', False),('type_tax_use','in',['purchase','all'])]),
|
|
'property_account_income': fields.property(
|
|
type='many2one',
|
|
relation='account.account',
|
|
string="Income Account",
|
|
help="This account will be used for invoices instead of the default one to value sales for the current product."),
|
|
'property_account_expense': fields.property(
|
|
type='many2one',
|
|
relation='account.account',
|
|
string="Expense Account",
|
|
help="This account will be used for invoices instead of the default one to value expenses for the current product."),
|
|
}
|
|
|
|
def write(self, cr, uid, ids, vals, context=None):
|
|
if 'uom_po_id' in vals:
|
|
product_ids = self.pool.get('product.product').search(cr, uid, [('product_tmpl_id', 'in', ids)], context=context)
|
|
if self.pool.get('account.move.line').search(cr, uid, [('product_id', 'in', product_ids)], context=context, limit=1):
|
|
raise UserError(_("You can not change the unit of measure of a product that has been already used in an \
|
|
account journal item. If you need to change the unit of measure, you may deactivate this product."))
|
|
return super(product_template, self).write(cr, uid, ids, vals, context=context)
|