tsm-odoo
633e031aa8
This PR fixes two issues: - Incorrect write on `channel_member_ids` (trying to link guest instead of channel member) - Incorrect condition in `livechatService.leaveSession` that relies on the live chat to be initialized while it can acutally be called before if the current session is outdated. This could result in server errors in the following scenario: - Open a live chat - Log in - Open a live chat from the website app - Log out - Reload the page closes odoo/odoo#137834 Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
90 lines
4.9 KiB
Python
90 lines
4.9 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import tests
|
|
from odoo.addons.website_livechat.tests.common import TestLivechatCommon
|
|
|
|
|
|
@tests.tagged('post_install', '-at_install')
|
|
class TestLivechatRequestHttpCase(tests.HttpCase, TestLivechatCommon):
|
|
def test_livechat_request_complete_flow(self):
|
|
self._clean_livechat_sessions()
|
|
|
|
# Send first chat request - Open chat from operator side
|
|
channel_1 = self._common_chat_request_flow()
|
|
# Visitor Rates the conversation (Good)
|
|
self._send_rating(channel_1, self.visitor, 5)
|
|
|
|
# Operator Re-Send a chat request
|
|
channel_2 = self._common_chat_request_flow()
|
|
# Visitor Rates the conversation (Bad)
|
|
self._send_rating(channel_2, self.visitor, 1, "Stop bothering me! I hate you </3 !")
|
|
|
|
def test_cancel_chat_request_on_visitor_demand(self):
|
|
self._clean_livechat_sessions()
|
|
|
|
self.operator_b = self.env['res.users'].create({
|
|
'name': 'Operator Marc',
|
|
'login': 'operator_b',
|
|
'email': 'operatormarc@example.com',
|
|
'password': "operatormarc",
|
|
'livechat_username': "Marco'r El",
|
|
})
|
|
|
|
# Open Chat Request
|
|
self.visitor.with_user(self.operator_b).sudo().action_send_chat_request()
|
|
chat_request = self.env['discuss.channel'].search([('livechat_visitor_id', '=', self.visitor.id), ('livechat_active', '=', True)])
|
|
self.assertEqual(chat_request.livechat_operator_id, self.operator_b.partner_id, "Operator for active livechat session must be Operator Marc")
|
|
|
|
# Click on livechatbutton at client side
|
|
res = self.opener.post(url=self.open_chat_url, json=self.open_chat_params)
|
|
self.assertEqual(res.status_code, 200)
|
|
channel = self.env['discuss.channel'].search([('livechat_visitor_id', '=', self.visitor.id),
|
|
('livechat_active', '=', True)])
|
|
|
|
# Check that the chat request has been canceled.
|
|
chat_request.invalidate_recordset()
|
|
self.assertEqual(chat_request.livechat_active, False, "The livechat request must be inactive as the visitor started himself a livechat session.")
|
|
self.assertEqual(len(channel), 1)
|
|
self.assertEqual(channel.livechat_operator_id, self.operator.partner_id, "Operator for active livechat session must be Michel Operator")
|
|
|
|
def _common_chat_request_flow(self):
|
|
self.visitor.with_user(self.operator).sudo().action_send_chat_request()
|
|
channel = self.env['discuss.channel'].search([('livechat_visitor_id', '=', self.visitor.id), ('livechat_active', '=', True)])
|
|
self.assertEqual(len(channel), 1)
|
|
self.assertEqual(channel.livechat_operator_id, self.operator.partner_id, "Michel Operator should be the operator of this channel.")
|
|
self.assertEqual(len(channel.message_ids), 0)
|
|
self.assertEqual(channel.anonymous_name, f"Visitor #{self.visitor.id} ({self.visitor.country_id.name})")
|
|
|
|
# Operator Sends message
|
|
self._send_message(channel, self.operator.email, "Hello Again !", author_id=self.operator.partner_id.id)
|
|
self.assertEqual(len(channel.message_ids), 1)
|
|
|
|
# Visitor Answers
|
|
self._send_message(channel, self.visitor.display_name, "Answer from Visitor")
|
|
self.assertEqual(len(channel.message_ids), 2)
|
|
|
|
# Visitor Leave the conversation
|
|
channel._close_livechat_session()
|
|
self.assertEqual(len(channel.message_ids), 3)
|
|
self.assertEqual(channel.message_ids[0].author_id, self.env.ref('base.partner_root'), "Odoobot must be the sender of the 'left the conversation' message.")
|
|
self.assertIn(f"Visitor #{channel.livechat_visitor_id.id}", channel.message_ids[0].body)
|
|
self.assertEqual(channel.livechat_active, False, "The livechat session must be inactive as the visitor sent his feedback.")
|
|
|
|
return channel
|
|
|
|
def _clean_livechat_sessions(self):
|
|
# clean every possible mail channel linked to the visitor
|
|
active_channels = self.env['discuss.channel'].search([('livechat_visitor_id', '=', self.visitor.id), ('livechat_active', '=', True)])
|
|
for active_channel in active_channels:
|
|
active_channel._close_livechat_session()
|
|
|
|
def test_update_guest_of_chat_request_if_outdated(self):
|
|
self.visitor.with_user(self.operator).sudo().action_send_chat_request()
|
|
chat_request = self.env['discuss.channel'].search([('livechat_visitor_id', '=', self.visitor.id), ('livechat_active', '=', True)])
|
|
chat_request.message_post(body="Hello", author_id=self.operator.partner_id.id)
|
|
guest = self.env["mail.guest"].create({"name": "Guest"})
|
|
self.assertNotEqual(chat_request.channel_member_ids.guest_id, guest)
|
|
self.env.ref('website.default_website').with_context(guest=guest)._get_livechat_request_session()
|
|
self.assertEqual(chat_request.channel_member_ids.guest_id, guest)
|