The activities systray item didn't work anymore. Nothing happened on click. It was because the do action event was never caught. The systray item logic had a different flow and didn't go through the ViewAdapter code. We fix this by adding a listener on window (through legacy service provider) to execute this code when the do_action bubbles up. Instead of using the legacy service provided, we could have done this in the SystrayItemAdapter, but we then have the legacy environment and would need more work for the same result. closes odoo/odoo#72406 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
386 lines
13 KiB
JavaScript
386 lines
13 KiB
JavaScript
/** @odoo-module **/
|
|
|
|
import { registry } from "@web/core/registry";
|
|
import testUtils from "web.test_utils";
|
|
import ListController from "web.ListController";
|
|
import ListView from "web.ListView";
|
|
import { click, legacyExtraNextTick, patchWithCleanup } from "../../helpers/utils";
|
|
import { registerCleanup } from "../../helpers/cleanup";
|
|
import { createWebClient, doAction, getActionManagerServerData } from "./../helpers";
|
|
|
|
import { ClientActionAdapter } from "@web/legacy/action_adapters";
|
|
import { useDebugMenu } from "@web/core/debug/debug_menu";
|
|
import { debugService } from "@web/core/debug/debug_service";
|
|
|
|
import ControlPanel from "web.ControlPanel";
|
|
import core from "web.core";
|
|
import AbstractAction from "web.AbstractAction";
|
|
import Widget from "web.Widget";
|
|
import SystrayMenu from "web.SystrayMenu";
|
|
|
|
let serverData;
|
|
|
|
QUnit.module("ActionManager", (hooks) => {
|
|
hooks.beforeEach(() => {
|
|
serverData = getActionManagerServerData();
|
|
});
|
|
|
|
QUnit.module("Legacy tests (to eventually drop)");
|
|
|
|
QUnit.test("display warning as notification", async function (assert) {
|
|
// this test can be removed as soon as the legacy layer is dropped
|
|
assert.expect(5);
|
|
let list;
|
|
patchWithCleanup(ListController.prototype, {
|
|
init() {
|
|
this._super(...arguments);
|
|
list = this;
|
|
},
|
|
});
|
|
|
|
const webClient = await createWebClient({ serverData });
|
|
await doAction(webClient, 3);
|
|
assert.containsOnce(webClient, ".o_list_view");
|
|
list.trigger_up("warning", {
|
|
title: "Warning!!!",
|
|
message: "This is a warning...",
|
|
});
|
|
await testUtils.nextTick();
|
|
await legacyExtraNextTick();
|
|
assert.containsOnce(webClient, ".o_list_view");
|
|
assert.containsOnce(document.body, ".o_notification.bg-warning");
|
|
assert.strictEqual($(".o_notification_title").text(), "Warning!!!");
|
|
assert.strictEqual($(".o_notification_content").text(), "This is a warning...");
|
|
});
|
|
|
|
QUnit.test("display warning as modal", async function (assert) {
|
|
// this test can be removed as soon as the legacy layer is dropped
|
|
assert.expect(5);
|
|
let list;
|
|
patchWithCleanup(ListController.prototype, {
|
|
init() {
|
|
this._super(...arguments);
|
|
list = this;
|
|
},
|
|
});
|
|
|
|
const webClient = await createWebClient({ serverData });
|
|
await doAction(webClient, 3);
|
|
assert.containsOnce(webClient, ".o_list_view");
|
|
list.trigger_up("warning", {
|
|
title: "Warning!!!",
|
|
message: "This is a warning...",
|
|
type: "dialog",
|
|
});
|
|
await testUtils.nextTick();
|
|
await legacyExtraNextTick();
|
|
assert.containsOnce(webClient, ".o_list_view");
|
|
assert.containsOnce(document.body, ".modal");
|
|
assert.strictEqual($(".modal-title").text(), "Warning!!!");
|
|
assert.strictEqual($(".modal-body").text(), "This is a warning...");
|
|
});
|
|
|
|
QUnit.test("redraw a controller and open debugManager does not crash", async (assert) => {
|
|
assert.expect(11);
|
|
|
|
const LegacyAction = AbstractAction.extend({
|
|
start() {
|
|
const ret = this._super(...arguments);
|
|
const el = document.createElement("div");
|
|
el.classList.add("custom-action");
|
|
this.el.append(el);
|
|
return ret;
|
|
},
|
|
});
|
|
core.action_registry.add("customLegacy", LegacyAction);
|
|
|
|
patchWithCleanup(ClientActionAdapter.prototype, {
|
|
setup() {
|
|
useDebugMenu("custom", { widget: this });
|
|
this._super();
|
|
},
|
|
});
|
|
|
|
registry
|
|
.category("debug")
|
|
.category("custom")
|
|
.add("item1", ({ widget }) => {
|
|
assert.step("debugItems executed");
|
|
assert.ok(widget);
|
|
return {};
|
|
});
|
|
registry.category("services").add("debug", debugService);
|
|
patchWithCleanup(odoo, { debug: true });
|
|
|
|
const mockRPC = (route) => {
|
|
if (route.includes("check_access_rights")) {
|
|
return true;
|
|
}
|
|
};
|
|
|
|
const webClient = await createWebClient({ serverData, mockRPC });
|
|
await doAction(webClient, "customLegacy");
|
|
assert.containsOnce(webClient, ".custom-action");
|
|
assert.verifySteps([]);
|
|
|
|
await click(webClient.el, ".o_debug_manager button");
|
|
assert.verifySteps(["debugItems executed"]);
|
|
|
|
await doAction(webClient, 5); // action in Dialog
|
|
await click(webClient.el, ".modal .o_form_button_cancel");
|
|
assert.containsNone(webClient, ".modal");
|
|
assert.containsOnce(webClient, ".custom-action");
|
|
assert.verifySteps([]);
|
|
|
|
// close debug menu
|
|
await click(webClient.el, ".o_debug_manager button");
|
|
// open debug menu
|
|
await click(webClient.el, ".o_debug_manager button");
|
|
assert.verifySteps(["debugItems executed"]);
|
|
delete core.action_registry.map.customLegacy;
|
|
});
|
|
|
|
QUnit.test("willUnmount is called down the legacy layers", async (assert) => {
|
|
assert.expect(7);
|
|
|
|
let mountCount = 0;
|
|
patchWithCleanup(ControlPanel.prototype, {
|
|
mounted() {
|
|
mountCount = mountCount + 1;
|
|
this.__uniqueId = mountCount;
|
|
assert.step(`mounted ${this.__uniqueId}`);
|
|
this._super(...arguments);
|
|
},
|
|
willUnmount() {
|
|
assert.step(`willUnmount ${this.__uniqueId}`);
|
|
this._super(...arguments);
|
|
},
|
|
});
|
|
|
|
const LegacyAction = AbstractAction.extend({
|
|
hasControlPanel: true,
|
|
start() {
|
|
const ret = this._super(...arguments);
|
|
const el = document.createElement("div");
|
|
el.classList.add("custom-action");
|
|
this.el.append(el);
|
|
return ret;
|
|
},
|
|
});
|
|
core.action_registry.add("customLegacy", LegacyAction);
|
|
|
|
const webClient = await createWebClient({ serverData });
|
|
await doAction(webClient, 1);
|
|
await doAction(webClient, "customLegacy");
|
|
await click(webClient.el.querySelectorAll(".breadcrumb-item")[0]);
|
|
await legacyExtraNextTick();
|
|
|
|
webClient.destroy();
|
|
|
|
assert.verifySteps([
|
|
"mounted 1",
|
|
"willUnmount 1",
|
|
"mounted 2",
|
|
"willUnmount 2",
|
|
"mounted 3",
|
|
"willUnmount 3",
|
|
]);
|
|
|
|
delete core.action_registry.map.customLegacy;
|
|
});
|
|
|
|
QUnit.test("Checks the availability of all views in the action", async (assert) => {
|
|
assert.expect(2);
|
|
patchWithCleanup(ListView.prototype, {
|
|
init(viewInfo, params) {
|
|
const action = params.action;
|
|
const views = action.views.map((view) => [view.viewID, view.type]);
|
|
assert.deepEqual(views, [
|
|
[1, "list"],
|
|
[2, "kanban"],
|
|
[3, "form"],
|
|
]);
|
|
assert.deepEqual(action._views, [
|
|
[1, "list"],
|
|
[2, "kanban"],
|
|
[3, "form"],
|
|
[false, "search"],
|
|
]);
|
|
this._super(...arguments);
|
|
},
|
|
});
|
|
const models = {
|
|
partner: {
|
|
fields: {
|
|
display_name: { string: "Displayed name", type: "char", searchable: true },
|
|
foo: {
|
|
string: "Foo",
|
|
type: "char",
|
|
default: "My little Foo Value",
|
|
searchable: true,
|
|
},
|
|
bar: { string: "Bar", type: "boolean" },
|
|
int_field: { string: "Integer field", type: "integer", group_operator: "sum" },
|
|
},
|
|
records: [
|
|
{
|
|
id: 1,
|
|
display_name: "first record",
|
|
foo: "yop",
|
|
int_field: 3,
|
|
},
|
|
{
|
|
id: 2,
|
|
display_name: "second record",
|
|
foo: "lalala",
|
|
int_field: 5,
|
|
},
|
|
{
|
|
id: 4,
|
|
display_name: "aaa",
|
|
foo: "abc",
|
|
int_field: 2,
|
|
},
|
|
],
|
|
},
|
|
};
|
|
const views = {
|
|
"partner,1,list": '<list><field name="foo"/></list>',
|
|
"partner,2,kanban": "<kanban></kanban>",
|
|
"partner,3,form": `<form></form>`,
|
|
"partner,false,search": "<search></search>",
|
|
};
|
|
const serverData = { models, views };
|
|
|
|
const webClient = await createWebClient({
|
|
serverData,
|
|
});
|
|
|
|
await doAction(webClient, {
|
|
id: 1,
|
|
res_model: "partner",
|
|
type: "ir.actions.act_window",
|
|
views: [
|
|
[1, "list"],
|
|
[2, "kanban"],
|
|
[3, "form"],
|
|
],
|
|
});
|
|
});
|
|
|
|
QUnit.test("client actions may take and push their params", async function (assert) {
|
|
assert.expect(2);
|
|
|
|
const ClientAction = AbstractAction.extend({
|
|
init(parent, action) {
|
|
this._super(...arguments);
|
|
assert.deepEqual(action.params, {
|
|
active_id: 99,
|
|
take: "five",
|
|
active_ids: "1,2",
|
|
list: [9, 10],
|
|
});
|
|
},
|
|
});
|
|
core.action_registry.add("clientAction", ClientAction);
|
|
registerCleanup(() => delete core.action_registry.map.clientAction);
|
|
const webClient = await createWebClient({});
|
|
|
|
await doAction(webClient, {
|
|
type: "ir.actions.client",
|
|
tag: "clientAction",
|
|
params: {
|
|
active_id: 99,
|
|
take: "five",
|
|
active_ids: "1,2",
|
|
list: [9, 10],
|
|
},
|
|
});
|
|
|
|
assert.deepEqual(webClient.env.services.router.current.hash, {
|
|
action: "clientAction",
|
|
active_id: 99,
|
|
take: "five",
|
|
active_ids: "1,2",
|
|
});
|
|
});
|
|
|
|
QUnit.test("client actions honour do_push_state", async function (assert) {
|
|
assert.expect(2);
|
|
|
|
const ClientAction = AbstractAction.extend({
|
|
init(parent) {
|
|
this._super(...arguments);
|
|
this.parent = parent;
|
|
this.parent.do_push_state({ pinball: "wizard" });
|
|
},
|
|
|
|
async start() {
|
|
await this._super(...arguments);
|
|
const btn = document.createElement("button");
|
|
btn.classList.add("tommy");
|
|
btn.addEventListener("click", () => {
|
|
this.parent.do_push_state({ gipsy: "the acid queen" });
|
|
});
|
|
this.el.append(btn);
|
|
},
|
|
|
|
getState() {
|
|
return {
|
|
doctor: "quackson",
|
|
};
|
|
},
|
|
});
|
|
core.action_registry.add("clientAction", ClientAction);
|
|
registerCleanup(() => delete core.action_registry.map.clientAction);
|
|
const webClient = await createWebClient({});
|
|
|
|
await doAction(webClient, {
|
|
type: "ir.actions.client",
|
|
tag: "clientAction",
|
|
});
|
|
|
|
assert.deepEqual(webClient.env.services.router.current.hash, {
|
|
action: "clientAction",
|
|
pinball: "wizard",
|
|
doctor: "quackson",
|
|
});
|
|
|
|
await click(webClient.el, ".tommy");
|
|
assert.deepEqual(webClient.env.services.router.current.hash, {
|
|
action: "clientAction",
|
|
pinball: "wizard",
|
|
gipsy: "the acid queen",
|
|
doctor: "quackson",
|
|
});
|
|
});
|
|
|
|
QUnit.test("Systray item triggers do action on legacy service provider", async (assert) => {
|
|
assert.expect(3);
|
|
function createMockActionService(assert) {
|
|
return {
|
|
dependencies: [],
|
|
start() {
|
|
return {
|
|
doAction(params) {
|
|
assert.step("do action");
|
|
assert.strictEqual(params, 128, "The doAction parameters are invalid.");
|
|
},
|
|
loadState() {},
|
|
};
|
|
},
|
|
};
|
|
}
|
|
registry.category("services").add("action", createMockActionService(assert));
|
|
const FakeSystrayItemWidget = Widget.extend({
|
|
on_attach_callback() {
|
|
this.do_action(128);
|
|
},
|
|
});
|
|
SystrayMenu.Items.push(FakeSystrayItemWidget);
|
|
await createWebClient({ serverData });
|
|
assert.verifySteps(["do action"]);
|
|
delete SystrayMenu.Items.FakeSystrayItemWidget;
|
|
});
|
|
});
|