Before this commit, when accessing the discuss call settings in non-localhost without SSL, there was the following crash: ``` "Cannot read 'enumerateDevices' of undefined" ``` Odoo uses zxing-js to detect devices within the discuss app. zxing-js provides methods such as "hasNavigator", "isMediaDevicesSuported" or "canEnumerateDevices" to check if features are available. These are not called by Odoo before using the related features what can result in a JS traceback. This commit fixes the issue by showing a warning as a toaster notification and in the dev tools, instead of a traceback. The zxing-js methods are not exposed, hence the reliance on truthy mediaDevices. See also https://github.com/zxing-js/library/issues/225 Closes https://github.com/odoo/odoo/issues/112255 Closes https://github.com/odoo/odoo/pull/112813 closes odoo/odoo#119903 X-original-commit: 32238dd680396c6ccb519aa8b3fb7487c38395f7 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
276 B
276 B
Germany, 2023-02-15
I hereby agree to the terms of the Odoo Individual Contributor License Agreement v1.0.
I declare that I am authorized and able to make this agreement and sign this declaration.
Signed,
Jan Brodersen janbrodersen@armitxes.net https://github.com/Armitxes