Guillaume (gdi)
1b77b3c214
When a new user is created from the website, the company id was always set to the first company of the database even if the website was the one of another company. This flow has been already fixed if there is the "Specific User Account" setting activated (see [this other commit]). This commit fixes the same issue but for every case. Steps to reproduce the issue: - Create 2 companies A & B - For each company, create a website linked to a different URL - Activate 'Free sign up' for company B - As a public user, go to website of company B - Go to 'Sign in > Don't have an account?' and create an account => If as an admin you check the company of the created user, it is company A instead of company B. [this other commit]: https://github.com/odoo/odoo/commit/77c708c516beb322df37220634e178ba82e894c9 task-3277317 closes odoo/odoo#121834 X-original-commit: 3fbfb5301c7583583e4f46c9b4ef16e048e5800c Signed-off-by: Benoit Socias (bso) <bso@odoo.com> Signed-off-by: Dieleman Guillaume (gdi) <gdi@odoo.com>
105 lines
4.5 KiB
Python
105 lines
4.5 KiB
Python
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from psycopg2 import IntegrityError
|
|
from unittest import TestCase
|
|
|
|
from odoo.tests.common import TransactionCase, new_test_user
|
|
from odoo.exceptions import ValidationError
|
|
from odoo.tools import mute_logger
|
|
from odoo.service.model import retrying
|
|
from odoo.addons.website.tools import MockRequest
|
|
|
|
|
|
class TestWebsiteResUsers(TransactionCase):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
websites = self.env['website'].create([
|
|
{'name': 'Test Website'},
|
|
{'name': 'Test Website 2'},
|
|
])
|
|
self.website_1, self.website_2 = websites
|
|
|
|
def test_no_website(self):
|
|
new_test_user(self.env, login='Pou', website_id=False)
|
|
with self.assertRaises(ValidationError):
|
|
new_test_user(self.env, login='Pou', website_id=False)
|
|
|
|
def test_websites_set_null(self):
|
|
user_1 = new_test_user(self.env, login='Pou', website_id=self.website_1.id)
|
|
user_2 = new_test_user(self.env, login='Pou', website_id=self.website_2.id)
|
|
with self.assertRaises(ValidationError):
|
|
(user_1 | user_2).write({'website_id': False})
|
|
|
|
def test_null_and_website(self):
|
|
new_test_user(self.env, login='Pou', website_id=self.website_1.id)
|
|
new_test_user(self.env, login='Pou', website_id=False)
|
|
|
|
def test_change_login(self):
|
|
new_test_user(self.env, login='Pou', website_id=self.website_1.id)
|
|
user_belle = new_test_user(self.env, login='Belle', website_id=self.website_1.id)
|
|
with self.assertRaises(IntegrityError), mute_logger('odoo.sql_db'):
|
|
user_belle.login = 'Pou'
|
|
|
|
def test_change_login_no_website(self):
|
|
new_test_user(self.env, login='Pou', website_id=False)
|
|
user_belle = new_test_user(self.env, login='Belle', website_id=False)
|
|
with self.assertRaises(ValidationError):
|
|
user_belle.login = 'Pou'
|
|
|
|
def test_same_website_message(self):
|
|
# Use a test cursor because retrying() does commit.
|
|
self.env.registry.enter_test_mode(self.env.cr)
|
|
self.addCleanup(self.env.registry.leave_test_mode)
|
|
env = self.env(context={'lang': 'en_US'}, cr=self.env.registry.cursor())
|
|
|
|
def create_user_pou():
|
|
return new_test_user(env, login='Pou', website_id=self.website_1.id)
|
|
|
|
# First user creation works.
|
|
create_user_pou()
|
|
|
|
# Second user creation fails with ValidationError instead of
|
|
# IntegrityError. Do not use self.assertRaises as it would try
|
|
# to create and rollback to a savepoint that is removed by the
|
|
# rollback in retrying().
|
|
with TestCase.assertRaises(self, ValidationError), mute_logger('odoo.sql_db'):
|
|
retrying(create_user_pou, env)
|
|
|
|
def _create_user_via_website(self, website, login):
|
|
# We need a fake request to _signup_create_user.
|
|
with MockRequest(self.env, website=website):
|
|
return self.env['res.users'].with_context(website_id=website.id)._signup_create_user({
|
|
'name': login,
|
|
'login': login,
|
|
})
|
|
|
|
def _create_and_check_portal_user(self, website_specific, company_1, company_2, website_1, website_2):
|
|
# Disable/Enable cross-website for portal users.
|
|
website_1.specific_user_account = website_specific
|
|
website_2.specific_user_account = website_specific
|
|
|
|
user_1 = self._create_user_via_website(website_1, 'user1')
|
|
user_2 = self._create_user_via_website(website_2, 'user2')
|
|
self.assertEqual(user_1.company_id, company_1)
|
|
self.assertEqual(user_2.company_id, company_2)
|
|
|
|
if website_specific:
|
|
self.assertEqual(user_1.website_id, website_1)
|
|
self.assertEqual(user_2.website_id, website_2)
|
|
else:
|
|
self.assertEqual(user_1.website_id.id, False)
|
|
self.assertEqual(user_2.website_id.id, False)
|
|
|
|
def test_multi_website_multi_company(self):
|
|
company_1 = self.env['res.company'].create({'name': "Company 1"})
|
|
company_2 = self.env['res.company'].create({'name': "Company 2"})
|
|
website_1 = self.env['website'].create({'name': "Website 1", 'company_id': company_1.id})
|
|
website_2 = self.env['website'].create({'name': "Website 2", 'company_id': company_2.id})
|
|
# Permit uninvited signup.
|
|
website_1.auth_signup_uninvited = 'b2c'
|
|
website_2.auth_signup_uninvited = 'b2c'
|
|
|
|
self._create_and_check_portal_user(False, company_1, company_2, website_1, website_2)
|
|
self._create_and_check_portal_user(True, company_1, company_2, website_1, website_2)
|