ijas ahammed
7791a49e3e
Currently, when we try to shorten the links from content with help of `_shorten_links_text` method, it throws traceback if the body(content) we pass is `False`(might happen when we directly pass a model field of textual type but the field doesn't have a value yet). It's because the `re` expects the content to be string / bytestring. This commit fixes the issue by adding a check in this method, which will simply return `False` if there's no body. Task-2628586 closes odoo/odoo#76041 X-original-commit: 3cc5217f1196108d5c7a52202054263a480963b2 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
79 lines
3.4 KiB
Python
79 lines
3.4 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
import re
|
|
|
|
import markupsafe
|
|
from werkzeug import urls, utils
|
|
|
|
from odoo import api, models, tools
|
|
|
|
|
|
class MailRenderMixin(models.AbstractModel):
|
|
_inherit = "mail.render.mixin"
|
|
|
|
# ------------------------------------------------------------
|
|
# TOOLS
|
|
# ------------------------------------------------------------
|
|
|
|
@api.model
|
|
def _shorten_links(self, html, link_tracker_vals, blacklist=None, base_url=None):
|
|
""" Shorten links in an html content. It uses the '/r' short URL routing
|
|
introduced in this module. Using the standard Odoo regex local links are
|
|
found and replaced by global URLs (not including mailto, tel, sms).
|
|
|
|
TDE FIXME: could be great to have a record to enable website-based URLs
|
|
|
|
:param link_tracker_vals: values given to the created link.tracker, containing
|
|
for example: campaign_id, medium_id, source_id, and any other relevant fields
|
|
like mass_mailing_id in mass_mailing;
|
|
:param list blacklist: list of (local) URLs to not shorten (e.g.
|
|
'/unsubscribe_from_list')
|
|
:param str base_url: either given, either based on config parameter
|
|
|
|
:return: updated html
|
|
"""
|
|
base_url = base_url or self.env['ir.config_parameter'].sudo().get_param('web.base.url')
|
|
short_schema = base_url + '/r/'
|
|
for match in re.findall(tools.HTML_TAG_URL_REGEX, html):
|
|
href = markupsafe.Markup(match[0])
|
|
long_url = match[1]
|
|
label = (match[3] or '').strip()
|
|
|
|
if not blacklist or not [s for s in blacklist if s in long_url] and not long_url.startswith(short_schema):
|
|
create_vals = dict(link_tracker_vals, url=utils.unescape(long_url), label=utils.unescape(label))
|
|
link = self.env['link.tracker'].search_or_create(create_vals)
|
|
if link.short_url:
|
|
new_href = href.replace(long_url, link.short_url)
|
|
html = html.replace(href, new_href)
|
|
|
|
return html
|
|
|
|
@api.model
|
|
def _shorten_links_text(self, content, link_tracker_vals, blacklist=None, base_url=None):
|
|
""" Shorten links in a string content. Works like ``_shorten_links`` but
|
|
targetting string content, not html.
|
|
|
|
:return: updated content
|
|
"""
|
|
if not content:
|
|
return content
|
|
base_url = base_url or self.env['ir.config_parameter'].sudo().get_param('web.base.url')
|
|
shortened_schema = base_url + '/r/'
|
|
unsubscribe_schema = base_url + '/sms/'
|
|
for original_url in re.findall(tools.TEXT_URL_REGEX, content):
|
|
# don't shorten already-shortened links or links towards unsubscribe page
|
|
if original_url.startswith(shortened_schema) or original_url.startswith(unsubscribe_schema):
|
|
continue
|
|
# support blacklist items in path, like /u/
|
|
parsed = urls.url_parse(original_url, scheme='http')
|
|
if blacklist and any(item in parsed.path for item in blacklist):
|
|
continue
|
|
|
|
create_vals = dict(link_tracker_vals, url= utils.unescape(original_url))
|
|
link = self.env['link.tracker'].search_or_create(create_vals)
|
|
if link.short_url:
|
|
content = content.replace(original_url, link.short_url, 1)
|
|
|
|
return content
|