Files
odoo_source/addons/account
althaf shaik 29097e10d8 [FIX] account: restrict to create payment without payment date
This traceback raises when user tries to create payment without payment date.

To reproduce this issue:

1) Install 'account'
2) Open any existing invoice (not a DRAFT one)
3) Click 'REGISTER PAYMENT' button.
4) Now remove 'Payment Date'

Error: 'Expected singleton: account.payment.term()'

Note:- 'TypeError: unsupported operand type(s) for +=: 'float' and 'NoneType''
is also produced for some invoices.

When user removes 'payment_date' '_compute_amount' method will be called, In which
'_get_total_amount_in_wizard_currency_to_full_reconcile' method is used.

In '_get_total_amount_in_wizard_currency_to_full_reconcile' method,
'_get_total_amount_using_same_currency' is used to get total amount.

On '_get_total_amount_using_same_currency' method payment_date is passed as an
argument for '_is_eligible_for_early_payment_discount' method.

See: https://github.com/odoo/odoo/blob/ed2e26633458f1284437286f71eba43c8d1818a7/addons/account/wizard/account_payment_register.py#L490-L498

On '_is_eligible_for_early_payment_discount' method if no reference date,
its returning True. which leads to above traceback
See:
https://github.com/odoo/odoo/blob/ed2e26633458f1284437286f71eba43c8d1818a7/addons/account/models/account_move.py#L1902-L1905

sentry-4337953422

closes odoo/odoo#134721

X-original-commit: a05be50b9cf75fb0226f7b464b3a8f580465d462
Signed-off-by: Laurent Smet (las) <las@odoo.com>
2023-09-08 13:45:34 +00:00
..
…
2023-06-30 23:37:50 +02:00
…

Odoo Accounting

The Odoo Open Source Accounting app allows a better way to collaborate with your accountants, your customers and control your suppliers.

Activate features on demand, from integrated analytic accounting to budget, assets and multiple companies consolidation.

A Smart User Interface

Record transactions in a few clicks and easily manage all financial activities in one place. Odoo's user interface is designed with productivity in mind.

A Better Way To Work – Together

Share access to your latest business numbers with your team and your accountant – so everyone is up to speed. From work, home or on the go.

Connect Your Bank Accounts

Import your bank statements and reconcile them in just a few clicks. Prepare payment orders based on your supplier invoices and payment terms.

Electronic invoicing and automated follow-ups

Create and send professional invoices & get paid online. Get rid of the stress of having to constantly remind your debtors. Simply set-up and automate follow-ups to get paid quickly.

Sales Integration

Automatically create invoices from sales orders, delivery orders or base them on time and material. Re-invoice expenses on projects to your customer in just a few clicks.

Purchase Integration

Control supplier invocies based on purchase orders. Get real-time inventory valuation reports automatically posted in your accounts.

Multi-Level Analytic Accounting

Integrate your analytic accounting operations with timesheets, projects, invoices, expenses, etc. No need to record transactions, all analytic entries are posted automatically following your business rules.

Everything you need to grow

Manage your assets, track expenses, control budgets, multi-level analytic accounting; Odoo has all the features you need to sustain all your business activities.

Scale With Your Organization

Odoo supports multiple currencies, multiple users with different access rights, multiple companies with real time consolidation and unlimited analytic plans.