Files
odoo_source/addons/purchase/tests/test_purchase.py
T
Walid HANNICHE (waha) 360ec46b16 [FIX] purchase: unit price order line price_precision
Steps to reproduce:
- increase price_precision in decimal accuracy (in debug mode)
- create a product with multiple digits
- create a PO with that product
- unit price is rounded to 2 digits (currency pricision)

Bug:
in previous versions conversion was only done if currency
was different

Fix:
do not round during conversion and round to the highest digits
(alternatively we could revert to only converting if currecy is
different and accept the loss of precission in that case)

the wrong currency was used also for the conversion

opw-3050044

closes odoo/odoo#111223

X-original-commit: 2e46bf073c2251ce3d3ab5d5184feceb741df6db
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
2023-01-27 15:11:18 +01:00

336 lines
14 KiB
Python

# -*- coding: utf-8 -*-
# Part of Odoo. See LICENSE file for full copyright and licensing details.
from odoo.addons.account.tests.common import AccountTestInvoicingCommon
from odoo.tests import tagged, Form
from odoo import Command, fields
from datetime import timedelta
@tagged('-at_install', 'post_install')
class TestPurchase(AccountTestInvoicingCommon):
def test_date_planned(self):
"""Set a date planned on 2 PO lines. Check that the PO date_planned is the earliest PO line date
planned. Change one of the dates so it is even earlier and check that the date_planned is set to
this earlier date.
"""
po = Form(self.env['purchase.order'])
po.partner_id = self.partner_a
with po.order_line.new() as po_line:
po_line.product_id = self.product_a
po_line.product_qty = 1
po_line.price_unit = 100
with po.order_line.new() as po_line:
po_line.product_id = self.product_b
po_line.product_qty = 10
po_line.price_unit = 200
po = po.save()
# Check that the same date is planned on both PO lines.
self.assertNotEqual(po.order_line[0].date_planned, False)
self.assertAlmostEqual(po.order_line[0].date_planned, po.order_line[1].date_planned, delta=timedelta(seconds=10))
self.assertAlmostEqual(po.order_line[0].date_planned, po.date_planned, delta=timedelta(seconds=10))
orig_date_planned = po.order_line[0].date_planned
# Set an earlier date planned on a PO line and check that the PO expected date matches it.
new_date_planned = orig_date_planned - timedelta(hours=1)
po.order_line[0].date_planned = new_date_planned
self.assertAlmostEqual(po.order_line[0].date_planned, po.date_planned, delta=timedelta(seconds=10))
# Set an even earlier date planned on the other PO line and check that the PO expected date matches it.
new_date_planned = orig_date_planned - timedelta(hours=72)
po.order_line[1].date_planned = new_date_planned
self.assertAlmostEqual(po.order_line[1].date_planned, po.date_planned, delta=timedelta(seconds=10))
def test_purchase_order_sequence(self):
PurchaseOrder = self.env['purchase.order'].with_context(tracking_disable=True)
company = self.env.user.company_id
self.env['ir.sequence'].search([
('code', '=', 'purchase.order'),
]).write({
'use_date_range': True, 'prefix': 'PO/%(range_year)s/',
})
vals = {
'partner_id': self.partner_a.id,
'company_id': company.id,
'currency_id': company.currency_id.id,
'date_order': '2019-01-01',
}
purchase_order = PurchaseOrder.create(vals.copy())
self.assertTrue(purchase_order.name.startswith('PO/2019/'))
vals['date_order'] = '2020-01-01'
purchase_order = PurchaseOrder.create(vals.copy())
self.assertTrue(purchase_order.name.startswith('PO/2020/'))
# In EU/BXL tz, this is actually already 01/01/2020
vals['date_order'] = '2019-12-31 23:30:00'
purchase_order = PurchaseOrder.with_context(tz='Europe/Brussels').create(vals.copy())
self.assertTrue(purchase_order.name.startswith('PO/2020/'))
def test_reminder_1(self):
"""Set to send reminder today, check if a reminder can be send to the
partner.
"""
po = Form(self.env['purchase.order'])
po.partner_id = self.partner_a
with po.order_line.new() as po_line:
po_line.product_id = self.product_a
po_line.product_qty = 1
po_line.price_unit = 100
with po.order_line.new() as po_line:
po_line.product_id = self.product_b
po_line.product_qty = 10
po_line.price_unit = 200
# set to send reminder today
po.date_planned = fields.Datetime.now() + timedelta(days=1)
po.receipt_reminder_email = True
po.reminder_date_before_receipt = 1
po = po.save()
po.button_confirm()
# check vendor is a message recipient
self.assertTrue(po.partner_id in po.message_partner_ids)
old_messages = po.message_ids
po._send_reminder_mail()
messages_send = po.message_ids - old_messages
# check reminder send
self.assertTrue(messages_send)
self.assertTrue(po.partner_id in messages_send.mapped('partner_ids'))
# check confirm button
po.confirm_reminder_mail()
self.assertTrue(po.mail_reminder_confirmed)
def test_reminder_2(self):
"""Set to send reminder tomorrow, check if no reminder can be send.
"""
po = Form(self.env['purchase.order'])
po.partner_id = self.partner_a
with po.order_line.new() as po_line:
po_line.product_id = self.product_a
po_line.product_qty = 1
po_line.price_unit = 100
with po.order_line.new() as po_line:
po_line.product_id = self.product_b
po_line.product_qty = 10
po_line.price_unit = 200
# set to send reminder tomorrow
po.date_planned = fields.Datetime.now() + timedelta(days=2)
po.receipt_reminder_email = True
po.reminder_date_before_receipt = 1
po = po.save()
po.button_confirm()
# check vendor is a message recipient
self.assertTrue(po.partner_id in po.message_partner_ids)
old_messages = po.message_ids
po._send_reminder_mail()
messages_send = po.message_ids - old_messages
# check no reminder send
self.assertFalse(messages_send)
def test_update_date_planned(self):
po = Form(self.env['purchase.order'])
po.partner_id = self.partner_a
with po.order_line.new() as po_line:
po_line.product_id = self.product_a
po_line.product_qty = 1
po_line.price_unit = 100
po_line.date_planned = '2020-06-06 00:00:00'
with po.order_line.new() as po_line:
po_line.product_id = self.product_b
po_line.product_qty = 10
po_line.price_unit = 200
po_line.date_planned = '2020-06-06 00:00:00'
po = po.save()
po.button_confirm()
# update first line
po._update_date_planned_for_lines([(po.order_line[0], fields.Datetime.today())])
self.assertEqual(po.order_line[0].date_planned, fields.Datetime.today())
activity = self.env['mail.activity'].search([
('summary', '=', 'Date Updated'),
('res_model_id', '=', 'purchase.order'),
('res_id', '=', po.id),
])
self.assertTrue(activity)
self.assertIn(
'<p>partner_a modified receipt dates for the following products:</p>\n'
'<p> - product_a from 2020-06-06 to %s</p>' % fields.Date.today(),
activity.note,
)
# update second line
po._update_date_planned_for_lines([(po.order_line[1], fields.Datetime.today())])
self.assertEqual(po.order_line[1].date_planned, fields.Datetime.today())
self.assertIn(
'<p>partner_a modified receipt dates for the following products:</p>\n'
'<p> - product_a from 2020-06-06 to %(today)s</p>\n'
'<p> - product_b from 2020-06-06 to %(today)s</p>' % {'today': fields.Date.today()},
activity.note,
)
def test_onchange_packaging_00(self):
"""Create a PO and use packaging. Check we suggested suitable packaging
according to the product_qty. Also check product_qty or product_packaging
are correctly calculated when one of them changed.
"""
# Required for `product_packaging_qty` to be visible in the view
self.env.user.groups_id += self.env.ref('product.group_stock_packaging')
packaging_single = self.env['product.packaging'].create({
'name': "I'm a packaging",
'product_id': self.product_a.id,
'qty': 1.0,
})
packaging_dozen = self.env['product.packaging'].create({
'name': "I'm also a packaging",
'product_id': self.product_a.id,
'qty': 12.0,
})
po = self.env['purchase.order'].create({
'partner_id': self.partner_a.id,
})
po_form = Form(po)
with po_form.order_line.new() as line:
line.product_id = self.product_a
line.product_qty = 1.0
po_form.save()
self.assertEqual(po.order_line.product_packaging_id, packaging_single)
self.assertEqual(po.order_line.product_packaging_qty, 1.0)
with po_form.order_line.edit(0) as line:
line.product_packaging_qty = 2.0
po_form.save()
self.assertEqual(po.order_line.product_qty, 2.0)
with po_form.order_line.edit(0) as line:
line.product_qty = 24.0
po_form.save()
self.assertEqual(po.order_line.product_packaging_id, packaging_dozen)
self.assertEqual(po.order_line.product_packaging_qty, 2.0)
with po_form.order_line.edit(0) as line:
line.product_packaging_qty = 1.0
po_form.save()
self.assertEqual(po.order_line.product_qty, 12)
# Do the same test but without form, to check the `product_packaging_id` and `product_packaging_qty` are set
# without manual call to onchanges
po = self.env['purchase.order'].create({
'partner_id': self.partner_a.id,
'order_line': [
Command.create({'product_id': self.product_a.id, 'product_qty': 1.0}),
]
})
self.assertEqual(po.order_line.product_packaging_id, packaging_single)
self.assertEqual(po.order_line.product_packaging_qty, 1.0)
po.order_line.product_packaging_qty = 2.0
self.assertEqual(po.order_line.product_qty, 2.0)
po.order_line.product_qty = 24.0
self.assertEqual(po.order_line.product_packaging_id, packaging_dozen)
self.assertEqual(po.order_line.product_packaging_qty, 2.0)
po.order_line.product_packaging_qty = 1.0
self.assertEqual(po.order_line.product_qty, 12)
def test_with_different_uom(self):
""" This test ensures that the unit price is correctly computed"""
# Required for `product_uom` to be visibile in the view
self.env.user.groups_id += self.env.ref('uom.group_uom')
uom_units = self.env.ref('uom.product_uom_unit')
uom_dozens = self.env.ref('uom.product_uom_dozen')
uom_pairs = self.env['uom.uom'].create({
'name': 'Pairs',
'category_id': uom_units.category_id.id,
'uom_type': 'bigger',
'factor_inv': 2,
'rounding': 1,
})
product_data = {
'name': 'SuperProduct',
'type': 'consu',
'uom_id': uom_units.id,
'uom_po_id': uom_pairs.id,
'standard_price': 100
}
product_01 = self.env['product.product'].create(product_data)
product_02 = self.env['product.product'].create(product_data)
po_form = Form(self.env['purchase.order'])
po_form.partner_id = self.partner_a
with po_form.order_line.new() as po_line:
po_line.product_id = product_01
with po_form.order_line.new() as po_line:
po_line.product_id = product_02
po_line.product_uom = uom_dozens
po = po_form.save()
self.assertEqual(po.order_line[0].price_unit, 200)
self.assertEqual(po.order_line[1].price_unit, 1200)
def test_on_change_quantity_description(self):
"""
When a user changes the quantity of a product in a purchase order it
should not change the description if the descritpion was changed by
the user before
"""
self.env.user.write({'company_id': self.company_data['company'].id})
po = Form(self.env['purchase.order'])
po.partner_id = self.partner_a
with po.order_line.new() as pol:
pol.product_id = self.product_a
pol.product_qty = 1
pol.name = "New custom description"
pol.product_qty += 1
self.assertEqual(pol.name, "New custom description")
def test_unit_price_precision_multicurrency(self):
"""
Purchase order lines should keep unit price precision of products
"""
self.env['decimal.precision'].search([
('name', '=', 'Product Price'),
]).digits = 5
product = self.env['product.product'].create({
'name': 'product_test',
'uom_id': self.env.ref('uom.product_uom_unit').id,
'lst_price': 10.0,
'standard_price': 0.12345,
})
currency = self.env['res.currency'].create({
'name': 'Dark Chocolate Coin',
'symbol': '🍫',
'rounding': 0.001,
'position': 'after',
'currency_unit_label': 'Dark Choco',
'currency_subunit_label': 'Dark Cacao Powder',
})
currency_rate = self.env['res.currency.rate'].create({
'name': '2016-01-01',
'rate': 2,
'currency_id': currency.id,
'company_id': self.env.company.id,
})
po_form = Form(self.env['purchase.order'])
po_form.partner_id = self.partner_a
with po_form.order_line.new() as po_line:
po_line.product_id = product
purchase_order_usd = po_form.save()
self.assertEqual(purchase_order_usd.order_line.price_unit, product.standard_price, "Value shouldn't be rounded $")
po_form = Form(self.env['purchase.order'])
po_form.partner_id = self.partner_a
po_form.currency_id = currency
with po_form.order_line.new() as po_line:
po_line.product_id = product
purchase_order_coco = po_form.save()
self.assertEqual(purchase_order_coco.order_line.price_unit, currency_rate.rate * product.standard_price, "Value shouldn't be rounded 🍫")