Touati Djamel (otd)
30f3f8d816
Steps to reproduce the bug: - Create a storable product “Test” - Go to inventory > Operations > Inventory Adjustments - Add a new line > Choose the “Test” product > Qty = 1* - Select this line > Click on the “Apply” button - You have the possibility to enter an “Inventory Reference / Reason” - Go To reporting > stock moves Problem: The reference is “Product Quantity Updated” instead of the inventory adjustment name. In the "action_apply" function, we give the name in the context: https://github.com/odoo/odoo/blob/15.0/addons/stock/wizard/stock_inventory_adjustment_name.py#L27 So that it is then used when creating the `stock.move`: https://github.com/odoo/odoo/blob/15.0/addons/stock/models/stock_quant.py#L800 But the context is destroyed here because we give a dict instead of a key : https://github.com/odoo/odoo/blob/15.0/addons/stock/models/stock_quant.py#L296 Solution: Remove the context override because it was done here: #83884 with the explanation that it's due to the write being called too many times here: https://github.com/odoo/odoo/blob/8b155b695823dfa954464ad0d5dd07445ece2471/addons/stock/models/stock_quant.py#L244-L248 but then this later PR: #84771 deletes the same problem lines. opw-2762169 closes odoo/odoo#85961 X-original-commit: eac6ca0db043fe59cf83988e6b000e700350930f Signed-off-by: Tiffany Chang <tic@odoo.com> Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
297 lines
12 KiB
Python
297 lines
12 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.addons.mail.tests.common import mail_new_test_user
|
|
from odoo.tests.common import Form, TransactionCase
|
|
from odoo.exceptions import AccessError, UserError
|
|
|
|
|
|
class TestEditableQuant(TransactionCase):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super(TestEditableQuant, cls).setUpClass()
|
|
|
|
# Shortcut to call `stock.quant` with `inventory mode` set in the context
|
|
cls.Quant = cls.env['stock.quant'].with_context(inventory_mode=True)
|
|
|
|
Product = cls.env['product.product']
|
|
Location = cls.env['stock.location']
|
|
cls.product = Product.create({
|
|
'name': 'Product A',
|
|
'type': 'product',
|
|
'categ_id': cls.env.ref('product.product_category_all').id,
|
|
})
|
|
cls.product2 = Product.create({
|
|
'name': 'Product B',
|
|
'type': 'product',
|
|
'categ_id': cls.env.ref('product.product_category_all').id,
|
|
})
|
|
cls.product_tracked_sn = Product.create({
|
|
'name': 'Product tracked by SN',
|
|
'type': 'product',
|
|
'tracking': 'serial',
|
|
'categ_id': cls.env.ref('product.product_category_all').id,
|
|
})
|
|
cls.warehouse = Location.create({
|
|
'name': 'Warehouse',
|
|
'usage': 'internal',
|
|
})
|
|
cls.stock = Location.create({
|
|
'name': 'Stock',
|
|
'usage': 'internal',
|
|
'location_id': cls.warehouse.id,
|
|
})
|
|
cls.room1 = Location.create({
|
|
'name': 'Room A',
|
|
'usage': 'internal',
|
|
'location_id': cls.stock.id,
|
|
})
|
|
cls.room2 = Location.create({
|
|
'name': 'Room B',
|
|
'usage': 'internal',
|
|
'location_id': cls.stock.id,
|
|
})
|
|
cls.inventory_loss = cls.product.property_stock_inventory
|
|
|
|
def test_create_quant_1(self):
|
|
""" Create a new quant who don't exist yet.
|
|
"""
|
|
# Checks we don't have any quant for this product.
|
|
quants = self.env['stock.quant'].search([('product_id', '=', self.product.id)])
|
|
self.assertEqual(len(quants), 0)
|
|
self.Quant.create({
|
|
'product_id': self.product.id,
|
|
'location_id': self.stock.id,
|
|
'inventory_quantity': 24
|
|
}).action_apply_inventory()
|
|
quants = self.env['stock.quant'].search([
|
|
('product_id', '=', self.product.id),
|
|
('quantity', '>', 0),
|
|
])
|
|
# Checks we have now a quant, and also checks the quantity is equals to
|
|
# what we set in `inventory_quantity` field.
|
|
self.assertEqual(len(quants), 1)
|
|
self.assertEqual(quants.quantity, 24)
|
|
|
|
stock_move = self.env['stock.move'].search([
|
|
('product_id', '=', self.product.id),
|
|
])
|
|
self.assertEqual(stock_move.location_id.id, self.inventory_loss.id)
|
|
self.assertEqual(stock_move.location_dest_id.id, self.stock.id)
|
|
|
|
def test_create_quant_2(self):
|
|
""" Try to create a quant who already exist.
|
|
Must update the existing quant instead of creating a new one.
|
|
"""
|
|
# Creates a quants...
|
|
first_quant = self.Quant.create({
|
|
'product_id': self.product.id,
|
|
'location_id': self.room1.id,
|
|
'quantity': 12,
|
|
})
|
|
quants = self.env['stock.quant'].search([
|
|
('product_id', '=', self.product.id),
|
|
('quantity', '>', 0),
|
|
])
|
|
self.assertEqual(len(quants), 1)
|
|
# ... then try to create an another quant for the same product/location.
|
|
second_quant = self.Quant.create({
|
|
'product_id': self.product.id,
|
|
'location_id': self.room1.id,
|
|
'inventory_quantity': 24,
|
|
})
|
|
second_quant.action_apply_inventory()
|
|
quants = self.env['stock.quant'].search([
|
|
('product_id', '=', self.product.id),
|
|
('quantity', '>', 0),
|
|
])
|
|
# Checks we still have only one quant, and first quant quantity was
|
|
# updated, and second quant had the same ID than the first quant.
|
|
self.assertEqual(len(quants), 1)
|
|
self.assertEqual(first_quant.quantity, 24)
|
|
self.assertEqual(first_quant.id, second_quant.id)
|
|
stock_move = self.env['stock.move'].search([
|
|
('product_id', '=', self.product.id),
|
|
])
|
|
self.assertEqual(len(stock_move), 1)
|
|
|
|
def test_create_quant_3(self):
|
|
""" Try to create a quant with `inventory_quantity` but without applying it.
|
|
Creates two quants:
|
|
- One with `quantity` (this one must be OK)
|
|
- One with `inventory_quantity` (this one will have null quantity)
|
|
"""
|
|
valid_quant = self.env['stock.quant'].create({
|
|
'product_id': self.product.id,
|
|
'location_id': self.room1.id,
|
|
'quantity': 10,
|
|
})
|
|
invalid_quant = self.env['stock.quant'].create({
|
|
'product_id': self.product2.id,
|
|
'location_id': self.room1.id,
|
|
'inventory_quantity': 20,
|
|
})
|
|
self.assertEqual(valid_quant.quantity, 10)
|
|
self.assertEqual(invalid_quant.quantity, 0)
|
|
|
|
def test_create_quant_4(self):
|
|
""" Try to create tree quants in inventory mode with `quantity` and/or `inventory_quantity`.
|
|
Creates two quants not in inventory mode:
|
|
- One with `quantity` (this one must be OK, but `inventory_mode` is useless here as it
|
|
doesn't enter in the inventory mode case and create quant as usual)
|
|
- One with `inventory_quantity` (this one must be OK)
|
|
- One with the two values (this one must raises an error as it enters in the inventory
|
|
mode but user can't edit directly `quantity` in inventory mode)
|
|
"""
|
|
valid_quant = self.env['stock.quant'].with_context(inventory_mode=True).create({
|
|
'product_id': self.product.id,
|
|
'location_id': self.room1.id,
|
|
'quantity': 10,
|
|
})
|
|
inventoried_quant = self.env['stock.quant'].with_context(inventory_mode=True).create({
|
|
'product_id': self.product2.id,
|
|
'location_id': self.room1.id,
|
|
'inventory_quantity': 20,
|
|
})
|
|
inventoried_quant.action_apply_inventory()
|
|
with self.assertRaises(UserError):
|
|
invalid_quant = self.env['stock.quant'].with_context(inventory_mode=True).create({
|
|
'product_id': self.product.id,
|
|
'location_id': self.room2.id,
|
|
'quantity': 10,
|
|
'inventory_quantity': 20,
|
|
})
|
|
self.assertEqual(valid_quant.quantity, 10)
|
|
self.assertEqual(inventoried_quant.quantity, 20)
|
|
|
|
def test_edit_quant_1(self):
|
|
""" Increases manually quantity of a quant.
|
|
"""
|
|
quant = self.Quant.create({
|
|
'product_id': self.product.id,
|
|
'location_id': self.room1.id,
|
|
'quantity': 12,
|
|
})
|
|
quant.inventory_quantity = 24
|
|
quant.action_apply_inventory()
|
|
self.assertEqual(quant.quantity, 24)
|
|
stock_move = self.env['stock.move'].search([
|
|
('product_id', '=', self.product.id),
|
|
])
|
|
self.assertEqual(stock_move.location_id.id, self.inventory_loss.id)
|
|
self.assertEqual(stock_move.location_dest_id.id, self.room1.id)
|
|
|
|
def test_edit_quant_2(self):
|
|
""" Decreases manually quantity of a quant.
|
|
"""
|
|
quant = self.Quant.create({
|
|
'product_id': self.product.id,
|
|
'location_id': self.room1.id,
|
|
'quantity': 12,
|
|
})
|
|
quant.inventory_quantity = 8
|
|
quant.action_apply_inventory()
|
|
self.assertEqual(quant.quantity, 8)
|
|
stock_move = self.env['stock.move'].search([
|
|
('product_id', '=', self.product.id),
|
|
])
|
|
self.assertEqual(stock_move.location_id.id, self.room1.id)
|
|
self.assertEqual(stock_move.location_dest_id.id, self.inventory_loss.id)
|
|
|
|
def test_edit_quant_3(self):
|
|
""" Try to edit a record without the inventory mode.
|
|
Must raise an error.
|
|
"""
|
|
self.demo_user = mail_new_test_user(
|
|
self.env,
|
|
name='Pauline Poivraisselle',
|
|
login='pauline',
|
|
email='p.p@example.com',
|
|
groups='base.group_user',
|
|
)
|
|
user_admin = self.env.ref('base.user_admin')
|
|
quant = self.Quant.create({
|
|
'product_id': self.product.id,
|
|
'location_id': self.room1.id,
|
|
'quantity': 12
|
|
})
|
|
self.assertEqual(quant.quantity, 12)
|
|
# Try to write on quant without permission
|
|
with self.assertRaises(AccessError):
|
|
quant.with_user(self.demo_user).write({'inventory_quantity': 8})
|
|
self.assertEqual(quant.quantity, 12)
|
|
|
|
# Try to write on quant with permission
|
|
quant.with_user(user_admin).write({'inventory_quantity': 8})
|
|
quant.action_apply_inventory()
|
|
self.assertEqual(quant.quantity, 8)
|
|
|
|
def test_edit_quant_4(self):
|
|
""" Update the quantity with the inventory report mode """
|
|
default_wh = self.env['stock.warehouse'].search([('company_id', '=', self.env.company.id)], limit=1)
|
|
default_stock_location = default_wh.lot_stock_id
|
|
quant = self.Quant.create({
|
|
'product_id': self.product.id,
|
|
'location_id': default_stock_location.id,
|
|
'inventory_quantity': 100,
|
|
})
|
|
quant.action_apply_inventory()
|
|
self.assertEqual(self.product.qty_available, 100)
|
|
quant.with_context(inventory_report_mode=True).inventory_quantity_auto_apply = 75
|
|
self.assertEqual(self.product.qty_available, 75)
|
|
quant.with_context(inventory_report_mode=True).inventory_quantity_auto_apply = 75
|
|
self.assertEqual(self.product.qty_available, 75)
|
|
smls = self.env['stock.move.line'].search([('product_id', '=', self.product.id)])
|
|
self.assertRecordValues(smls, [
|
|
{'qty_done': 100},
|
|
{'qty_done': 25},
|
|
{'qty_done': 0},
|
|
])
|
|
|
|
def test_edit_quant_5(self):
|
|
""" Create a quant with inventory mode and check that the inventory adjustment reason
|
|
is used as a reference in the `stock.move` """
|
|
default_wh = self.env['stock.warehouse'].search([('company_id', '=', self.env.company.id)], limit=1)
|
|
default_stock_location = default_wh.lot_stock_id
|
|
quant = self.Quant.create({
|
|
'product_id': self.product.id,
|
|
'location_id': default_stock_location.id,
|
|
'inventory_quantity': 1,
|
|
})
|
|
form_wizard = Form(self.env['stock.inventory.adjustment.name'].with_context(
|
|
default_quant_ids=quant.ids
|
|
))
|
|
form_wizard.inventory_adjustment_name = "Inventory Adjustment - Test"
|
|
form_wizard.save().action_apply()
|
|
self.assertTrue(self.env['stock.move'].search([('reference', '=', 'Inventory Adjustment - Test')], limit=1))
|
|
|
|
def test_sn_warning(self):
|
|
""" Checks that a warning is given when reusing an existing SN
|
|
in inventory mode.
|
|
"""
|
|
|
|
sn1 = self.env['stock.lot'].create({
|
|
'name': 'serial1',
|
|
'product_id': self.product_tracked_sn.id,
|
|
'company_id': self.env.company.id,
|
|
})
|
|
|
|
self.Quant.create({
|
|
'product_id': self.product_tracked_sn.id,
|
|
'location_id': self.room1.id,
|
|
'inventory_quantity': 1,
|
|
'lot_id': sn1.id
|
|
}).action_apply_inventory()
|
|
|
|
dupe_sn = self.Quant.create({
|
|
'product_id': self.product_tracked_sn.id,
|
|
'location_id': self.room2.id,
|
|
'inventory_quantity': 1,
|
|
'lot_id': sn1.id
|
|
})
|
|
dupe_sn.action_apply_inventory()
|
|
warning = False
|
|
warning = dupe_sn._onchange_serial_number()
|
|
self.assertTrue(warning, 'Reuse of existing serial number not detected')
|
|
self.assertEqual(list(warning.keys())[0], 'warning', 'Warning message was not returned')
|