Achraf (abz)
6c39b566d6
When a user double clicks on a record in the kanban view of the form view of project a crash occurs. This happens because there is an init which is called twice and during the second time the component created during the first click is destroyed and a DOM_updated event is still trigger which leads to a crash because in the case of project_form there is has a use of the element's dom which is then no longer available. There is the same case in "FieldHtmlWithAction" and in "MassMailingFullWidthFormController" The problem can be easily fixed by using on_attached_callback and on_detach_callback instead of setting a listener on DOM_updated in the init method. opw-2685867 closes odoo/odoo#81680 X-original-commit: 8d83433d463dd3d1aef321921939962883f57d68 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com> Signed-off-by: Achraf <abz@odoo.com>
44 lines
1.4 KiB
JavaScript
44 lines
1.4 KiB
JavaScript
/** @odoo-module */
|
|
import { createView } from 'web.test_utils';
|
|
import {ProjectFormView} from "@project/js/project_form";
|
|
import {patch} from "@web/core/utils/patch";
|
|
import core from "web.core";
|
|
let serverData = null;
|
|
|
|
const ProjectFormController = ProjectFormView.prototype.config.Controller;
|
|
QUnit.module("Project", hooks => {
|
|
hooks.beforeEach(() => {
|
|
serverData = {
|
|
project: {
|
|
fields: {
|
|
id: { string: "Id", type: "integer" },
|
|
},
|
|
records: [
|
|
{ id: 1, display_name: "First record"},
|
|
],
|
|
},
|
|
}
|
|
})
|
|
QUnit.module("Form");
|
|
QUnit.test("project form view", async function (assert) {
|
|
/*
|
|
This is a test whitebox because the flow cannot be reproduced correctly otherwise.
|
|
The idea is to check that the DOM_updated event is not triggered twice to avoid a crash.
|
|
*/
|
|
patch(ProjectFormController.prototype, "patchedInit", {
|
|
init: function () {
|
|
this._super(...arguments);
|
|
core.bus.trigger("DOM_updated");
|
|
}
|
|
});
|
|
const form = await createView({
|
|
View: ProjectFormView,
|
|
model: 'project',
|
|
data: serverData,
|
|
arch: '<form><field name="display_name"/></form>',
|
|
});
|
|
assert.containsOnce(document.body, form.el);
|
|
form.destroy()
|
|
})
|
|
});
|