Tiffany Chang (tic)
83a43af4cb
Add and improve onchange warnings when a duplicate SN is used in following cases: inventory, picking (any type), manufacturing, scrap, and "Update Quantity" (i.e. directly edit quants from product form). Improvement includes: - include location where the existing SN is - auto-correct source location when appropriate (e.g. trying to scrap a SN in the wrong location) The goal of this is to prevent but not restrict duplicate SNs so users can have some flexibility (especially if a dupe SN occurs because of an error such as doing pick-pack-ship out of order.) closes odoo/odoo#61287 Task: 1924758 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
53 lines
2.5 KiB
Python
53 lines
2.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import _, api, fields, models
|
|
|
|
|
|
class StockScrap(models.Model):
|
|
_inherit = 'stock.scrap'
|
|
|
|
production_id = fields.Many2one(
|
|
'mrp.production', 'Manufacturing Order',
|
|
states={'done': [('readonly', True)]}, check_company=True)
|
|
workorder_id = fields.Many2one(
|
|
'mrp.workorder', 'Work Order',
|
|
states={'done': [('readonly', True)]},
|
|
help='Not to restrict or prefer quants, but informative.', check_company=True)
|
|
|
|
@api.onchange('workorder_id')
|
|
def _onchange_workorder_id(self):
|
|
if self.workorder_id:
|
|
self.location_id = self.workorder_id.production_id.location_src_id.id
|
|
|
|
@api.onchange('production_id')
|
|
def _onchange_production_id(self):
|
|
if self.production_id:
|
|
self.location_id = self.production_id.move_raw_ids.filtered(lambda x: x.state not in ('done', 'cancel')) and self.production_id.location_src_id.id or self.production_id.location_dest_id.id
|
|
|
|
def _prepare_move_values(self):
|
|
vals = super(StockScrap, self)._prepare_move_values()
|
|
if self.production_id:
|
|
vals['origin'] = vals['origin'] or self.production_id.name
|
|
if self.product_id in self.production_id.move_finished_ids.mapped('product_id'):
|
|
vals.update({'production_id': self.production_id.id})
|
|
else:
|
|
vals.update({'raw_material_production_id': self.production_id.id})
|
|
return vals
|
|
|
|
@api.onchange('lot_id')
|
|
def _onchange_serial_number(self):
|
|
if self.product_id.tracking == 'serial' and self.lot_id:
|
|
if self.production_id:
|
|
message, recommended_location = self.env['stock.quant']._check_serial_number(self.product_id,
|
|
self.lot_id,
|
|
self.company_id,
|
|
self.location_id,
|
|
self.production_id.location_dest_id)
|
|
if message:
|
|
if recommended_location:
|
|
self.location_id = recommended_location
|
|
return {'warning': {'title': _('Warning'), 'message': message}}
|
|
else:
|
|
return super()._onchange_serial_number()
|