Alvaro FuentesandChristophe Simonis
c18b9f44be
When we use the `|` (or) version of this rule the ORM generates two
sub-queries when checking the company. This causes sub-optimal and in
some cases really bad planning for the queries and thus PG takes hours
to complete them.
Example (formatted):
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE ("mrp_bom"."company_id" in (1))
)
)
OR ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE "mrp_bom"."company_id" IS NULL
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
If we use the single term version the generated query has only one
sub-query:
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE (("mrp_bom"."company_id" in (1))
OR ("mrp_bom"."company_id" IS NULL))
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
In this version PG is able to produce a better query plan resulting in
better execution times.
Also, the `company_id` field is required on some models, so the "= False" comparison is useless.
closes odoo/odoo#159123
X-original-commit: 1b5c41f36801fb886ec591f29dba42787d698526
Related: odoo/enterprise#59378
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
Co-authored-by: Christophe Simonis <chs@odoo.com>
112 lines
6.5 KiB
XML
112 lines
6.5 KiB
XML
<?xml version="1.0" ?>
|
|
<odoo>
|
|
<record id="module_fleet_category" model="ir.module.category">
|
|
<field name="name">Fleet</field>
|
|
<field name="sequence">17</field>
|
|
</record>
|
|
<record id="fleet_group_user" model="res.groups">
|
|
<field name="name">Officer: Manage all vehicles</field>
|
|
<field name="category_id" ref="base.module_category_human_resources_fleet"/>
|
|
<field name="implied_ids" eval="[(4, ref('base.group_user'))]"/>
|
|
</record>
|
|
<record id="fleet_group_manager" model="res.groups">
|
|
<field name="name">Administrator</field>
|
|
<field name="implied_ids" eval="[(4, ref('fleet_group_user'))]"/>
|
|
<field name="category_id" ref="base.module_category_human_resources_fleet"/>
|
|
<field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>
|
|
</record>
|
|
|
|
<data noupdate="1">
|
|
<record id="base.default_user" model="res.users">
|
|
<field name="groups_id" eval="[(4,ref('fleet.fleet_group_manager'))]"/>
|
|
</record>
|
|
<record id="fleet_rule_contract_visibility_user" model="ir.rule">
|
|
<field name="name">User can only see his/her contracts</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_log_contract"/>
|
|
<field name="groups" eval="[(4, ref('fleet_group_user'))]"/>
|
|
<field name="perm_read" eval="True"/>
|
|
<field name="perm_write" eval="False"/>
|
|
<field name="perm_create" eval="False"/>
|
|
<field name="perm_unlink" eval="False"/>
|
|
<field name="domain_force">[('vehicle_id.driver_id','=',user.partner_id.id)]</field>
|
|
</record>
|
|
<record id="fleet_rule_service_visibility_user" model="ir.rule">
|
|
<field name="name">User can only see his/her vehicle's services</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_log_services"/>
|
|
<field name="groups" eval="[(4, ref('fleet_group_user'))]"/>
|
|
<field name="perm_read" eval="True"/>
|
|
<field name="perm_write" eval="False"/>
|
|
<field name="perm_create" eval="False"/>
|
|
<field name="perm_unlink" eval="False"/>
|
|
<field name="domain_force">[('vehicle_id.driver_id','=',user.partner_id.id)]</field>
|
|
</record>
|
|
<record id="fleet_rule_odometer_visibility_user" model="ir.rule">
|
|
<field name="name">User can only see his/her vehicle's odometer</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_odometer"/>
|
|
<field name="groups" eval="[(4, ref('fleet_group_user'))]"/>
|
|
<field name="perm_read" eval="True"/>
|
|
<field name="perm_write" eval="True"/>
|
|
<field name="perm_create" eval="True"/>
|
|
<field name="perm_unlink" eval="True"/>
|
|
<field name="domain_force">[('vehicle_id.driver_id','=',user.partner_id.id)]</field>
|
|
</record>
|
|
<record id="fleet_rule_vehicle_visibility_user" model="ir.rule">
|
|
<field name="name">User can only see his/her vehicle</field>
|
|
<field name="model_id" ref="model_fleet_vehicle"/>
|
|
<field name="groups" eval="[(4, ref('fleet_group_user'))]"/>
|
|
<field name="perm_read" eval="True"/>
|
|
<field name="perm_write" eval="True"/>
|
|
<field name="perm_create" eval="False"/>
|
|
<field name="perm_unlink" eval="False"/>
|
|
<field name="domain_force">[('driver_id','=',user.partner_id.id)]</field>
|
|
</record>
|
|
<record id="fleet_rule_contract_visibility_manager" model="ir.rule">
|
|
<field name="name">Administrator has all rights on vehicle's contracts</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_log_contract"/>
|
|
<field name="groups" eval="[Command.link(ref('fleet_group_manager'))]"/>
|
|
</record>
|
|
<record id="fleet_rule_service_visibility_manager" model="ir.rule">
|
|
<field name="name">Administrator has all rights on vehicle's services</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_log_services"/>
|
|
<field name="groups" eval="[Command.link(ref('fleet_group_manager'))]"/>
|
|
</record>
|
|
<record id="fleet_rule_odometer_visibility_manager" model="ir.rule">
|
|
<field name="name">Administrator has all rights on vehicle's vehicle's odometer</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_odometer"/>
|
|
<field name="groups" eval="[Command.link(ref('fleet_group_manager'))]"/>
|
|
</record>
|
|
<record id="fleet_rule_vehicle_visibility_manager" model="ir.rule">
|
|
<field name="name">Administrator has all rights on vehicle</field>
|
|
<field name="model_id" ref="model_fleet_vehicle"/>
|
|
<field name="groups" eval="[Command.link(ref('fleet_group_manager'))]"/>
|
|
</record>
|
|
<record id="ir_rule_fleet_vehicle" model="ir.rule">
|
|
<field name="name">Fleet vehicle: Multi Company</field>
|
|
<field name="model_id" ref="model_fleet_vehicle"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
<record id="ir_rule_fleet_vehicle_log_contract" model="ir.rule">
|
|
<field name="name">Fleet vehicle log contract: Multi Company</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_log_contract"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
<record id="ir_rule_fleet_report" model="ir.rule">
|
|
<field name="name">Costs Analysis: Multi Company</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_cost_report"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
<record id="ir_rule_fleet_odometer" model="ir.rule">
|
|
<field name="name">Fleet odometer: Multi Company</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_odometer"/>
|
|
<field name="global" eval="True"/>
|
|
<field name="domain_force">[('vehicle_id.company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
<record id="ir_rule_fleet_log_services" model="ir.rule">
|
|
<field name="name">Fleet log services: Multi Company</field>
|
|
<field name="model_id" ref="model_fleet_vehicle_log_services"/>
|
|
<field name="global" eval="True"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
</data>
|
|
</odoo>
|