Xavier Morel
9ebbfdac73
Fixes a large number of cases where strings are translated then
formatted, instead of letting `_()` do the formatting internally,
which allows it to recover from incorrect translations (missing,
broken, or extra placeholders).
Also
- removes translation markers entirely when there's nothing to
translate e.g. `_("%s - %s")` is not useful
- fixes a few messes which lead to only partial translatability
(DRY is generally a bad idea when translations are involved, even
more so when you don't make the variable part translatable)
- fixes a few nearby issues noticed at the same time
- replaces a few `"%s"` by `%r`, which should automatically quote
strings relatively appropriately
- fixes translated strings which use `\` to escape a newline (in order
to fill-paragraph): `\` escapes only the newline, if the
continuation string is indented this results in a bunch of spaces
ending in the string to translate, which is pretty garbage for the
translator, using implicit concatenation works much better
Note: some of the updates revert f-string parameters to %, because
babel (2.9) apparently has trouble with f-strings and blows up trying
to extract them.
Not in scope:
Helping translators fix translatable strings e.g. any translation
string with more than one placeholder probably should use keyword
placeholders
- Provides more context / data to the translator to make sense of the
sentence.
- Allows reordering the translated terms, which can be necessary
depending on the sentence and language.
closes odoo/odoo#139314
Related: odoo/enterprise#49311
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
26 lines
1.0 KiB
Python
26 lines
1.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from babel.dates import format_datetime
|
|
|
|
from odoo import _
|
|
from odoo.http import request
|
|
from odoo.addons.website_event.controllers import main
|
|
|
|
|
|
class WebsiteEventController(main.WebsiteEventController):
|
|
def _prepare_event_register_values(self, event, **post):
|
|
values = super(WebsiteEventController, self)._prepare_event_register_values(event, **post)
|
|
|
|
if "from_room_id" in post and not event.is_ongoing:
|
|
meeting_room = request.env["event.meeting.room"].browse(int(post["from_room_id"])).sudo().exists()
|
|
if meeting_room and meeting_room.is_published:
|
|
date_begin = format_datetime(event.date_begin, format="medium", tzinfo=event.date_tz)
|
|
|
|
values["toast_message"] = (
|
|
_('The event %s starts on %s (%s). \nJoin us there to chat about "%s"!',
|
|
event.name, date_begin, event.date_tz, meeting_room.name)
|
|
)
|
|
|
|
return values
|