Umesh Gupta
48737a8ffc
Currently, in demo data (or data) of some surveys, there are records of 'survey.question' having 'is_page' field value as true and 'question_type' is not defined. When question type is not defined, default value 'simple_choice' is assigned to the 'question_type' field. Now when we create a live session of that survey and go to the page, it tries to read the data for bar chart but data is not available (undefined) and the traceback is thrown. This happens because question types 'simple_choice' and 'multiple_choice') are expected to load a bar chart. It used to work before commit[1] where default 'question_type' value was being set to 'text_box' (so attempt to load bar chart was not made). This commit improves the behavior by adapting data/demo data/test cases and by adding a python constraint that prevents question creation of page type if there is a question type set, and compute `question_type` based on `is_page` field. Now that we have python constraint and a compute method, we no longer need the `default_get` method, so it is also removed. commit[1] - https://github.com/odoo/odoo/commit/1fb99d79b1567d4c150dc07f309ce54a3beea8e3 taskID-2841582 closes odoo/odoo#93414 Related: odoo/enterprise#28305 Related: odoo/upgrade#3600 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
123 lines
5.6 KiB
Python
123 lines
5.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.addons.survey.tests import common
|
|
from odoo.tests import tagged
|
|
from odoo.tests.common import HttpCase
|
|
|
|
|
|
@tagged('-at_install', 'post_install', 'functional')
|
|
class TestSurveyFlow(common.TestSurveyCommon, HttpCase):
|
|
def _format_submission_data(self, page, answer_data, additional_post_data):
|
|
post_data = {}
|
|
post_data['page_id'] = page.id
|
|
for question_id, answer_vals in answer_data.items():
|
|
question = page.question_ids.filtered(lambda q: q.id == question_id)
|
|
post_data.update(self._prepare_post_data(question, answer_vals['value'], post_data))
|
|
post_data.update(**additional_post_data)
|
|
return post_data
|
|
|
|
def test_flow_public(self):
|
|
# Step: survey manager creates the survey
|
|
# --------------------------------------------------
|
|
with self.with_user('survey_manager'):
|
|
survey = self.env['survey.survey'].create({
|
|
'title': 'Public Survey for Tarte Al Djotte',
|
|
'access_mode': 'public',
|
|
'users_login_required': False,
|
|
'questions_layout': 'page_per_section',
|
|
})
|
|
|
|
# First page is about customer data
|
|
page_0 = self.env['survey.question'].create({
|
|
'is_page': True,
|
|
'question_type': False,
|
|
'sequence': 1,
|
|
'title': 'Page1: Your Data',
|
|
'survey_id': survey.id,
|
|
})
|
|
page0_q0 = self._add_question(
|
|
page_0, 'What is your name', 'text_box',
|
|
comments_allowed=False,
|
|
constr_mandatory=True, constr_error_msg='Please enter your name', survey_id=survey.id)
|
|
page0_q1 = self._add_question(
|
|
page_0, 'What is your age', 'numerical_box',
|
|
comments_allowed=False,
|
|
constr_mandatory=True, constr_error_msg='Please enter your name', survey_id=survey.id)
|
|
|
|
# Second page is about tarte al djotte
|
|
page_1 = self.env['survey.question'].create({
|
|
'is_page': True,
|
|
'question_type': False,
|
|
'sequence': 4,
|
|
'title': 'Page2: Tarte Al Djotte',
|
|
'survey_id': survey.id,
|
|
})
|
|
page1_q0 = self._add_question(
|
|
page_1, 'What do you like most in our tarte al djotte', 'multiple_choice',
|
|
labels=[{'value': 'The gras'},
|
|
{'value': 'The bette'},
|
|
{'value': 'The tout'},
|
|
{'value': 'The regime is fucked up'}], survey_id=survey.id)
|
|
|
|
# fetch starting data to check only newly created data during this flow
|
|
answers = self.env['survey.user_input'].search([('survey_id', '=', survey.id)])
|
|
answer_lines = self.env['survey.user_input.line'].search([('survey_id', '=', survey.id)])
|
|
self.assertEqual(answers, self.env['survey.user_input'])
|
|
self.assertEqual(answer_lines, self.env['survey.user_input.line'])
|
|
|
|
# Step: customer takes the survey
|
|
# --------------------------------------------------
|
|
|
|
# Customer opens start page
|
|
r = self._access_start(survey)
|
|
self.assertResponse(r, 200, [survey.title])
|
|
|
|
# -> this should have generated a new answer with a token
|
|
answers = self.env['survey.user_input'].search([('survey_id', '=', survey.id)])
|
|
self.assertEqual(len(answers), 1)
|
|
answer_token = answers.access_token
|
|
self.assertTrue(answer_token)
|
|
self.assertAnswer(answers, 'new', self.env['survey.question'])
|
|
|
|
# Customer begins survey with first page
|
|
r = self._access_page(survey, answer_token)
|
|
self.assertResponse(r, 200)
|
|
self.assertAnswer(answers, 'new', self.env['survey.question'])
|
|
csrf_token = self._find_csrf_token(r.text)
|
|
|
|
r = self._access_begin(survey, answer_token)
|
|
self.assertResponse(r, 200)
|
|
|
|
# Customer submit first page answers
|
|
answer_data = {
|
|
page0_q0.id: {'value': ['Alfred Poilvache']},
|
|
page0_q1.id: {'value': ['44.0']},
|
|
}
|
|
post_data = self._format_submission_data(page_0, answer_data, {'csrf_token': csrf_token, 'token': answer_token, 'button_submit': 'next'})
|
|
r = self._access_submit(survey, answer_token, post_data)
|
|
self.assertResponse(r, 200)
|
|
answers.invalidate_recordset() # TDE note: necessary as lots of sudo in controllers messing with cache
|
|
|
|
# -> this should have generated answer lines
|
|
self.assertAnswer(answers, 'in_progress', page_0)
|
|
self.assertAnswerLines(page_0, answers, answer_data)
|
|
|
|
# Customer is redirected on second page and begins filling it
|
|
r = self._access_page(survey, answer_token)
|
|
self.assertResponse(r, 200)
|
|
csrf_token = self._find_csrf_token(r.text)
|
|
|
|
# Customer submit second page answers
|
|
answer_data = {
|
|
page1_q0.id: {'value': [page1_q0.suggested_answer_ids.ids[0], page1_q0.suggested_answer_ids.ids[1]]},
|
|
}
|
|
post_data = self._format_submission_data(page_1, answer_data, {'csrf_token': csrf_token, 'token': answer_token, 'button_submit': 'next'})
|
|
r = self._access_submit(survey, answer_token, post_data)
|
|
self.assertResponse(r, 200)
|
|
answers.invalidate_recordset() # TDE note: necessary as lots of sudo in controllers messing with cache
|
|
|
|
# -> this should have generated answer lines and closed the answer
|
|
self.assertAnswer(answers, 'done', page_1)
|
|
self.assertAnswerLines(page_1, answers, answer_data)
|